I2P Address: [http://git.idk.i2p]

Skip to content

NetDB: Fix lifecycle issues for subsessions (Gitlab #460, #406)

zzz requested to merge zzz/i2p.i2p:460-subsessions-v2 into master

This fixes bugs introduced in MR !120 (merged), fixes minor issues from that MR that were not addressed, and merges in my proposed changes from that MR that were not used. Refactored/rebased from previous MR !136 (closed)

  • Don't create subdb for subsession and lose ref for primary subsession; this caused the primary LS to not be found when attempting to create subsession LS at startup, so subsession LS was not created until primary LS was rebuilt
  • Remove useless null checks
  • Simplify CCR.getFNDF() to simply return the subdb or null; nothing else is necessary
  • Do not unpublish LS from main db on session shutdown; not necessary, it is not in there
  • Remove logging in KNDF.publish() that is incorrect for subsessions
  • Fix javadocs to correct errors and clearly state whether returns non-null or may be null.
  • Add KNDF.toString() for use in logging

Closes #460 (closed)

Merge request reports