I2P Address: [http://i2pgit.org]

Skip to content

NetDB: Fix lifecycle issues for subsessions (Gitlab #460, #406)

zzz requested to merge zzz/i2p.i2p:460-subsessions into master

This fixes bugs introduced in MR !120 (merged), fixes minor issues from that MR that were not addressed, and merges in my proposed changes from that MR that were not used.

  • Don't create subdb for subsession and lose ref for primary subsession; this caused the primary LS to not be found when attempting to create subsession LS at startup, so subsession LS was not created until primary LS was rebuilt
  • Remove useless null checks
  • Simplify CCR.getFNDF() to simply return the subdb or null; nothing else is necessary because the null return is handled in FNDS.
  • Fix javadocs to correct errors and clearly state whether returns non-null or may be null.
  • Add KNDF.toString() for use in logging
  • Log tweaks

Closes #460 (closed)

Merge request reports

Base32 Address: [http://7qeve4v2chmjdqlwpa3vl7aojf3nodbku7vepnjwrsxljzqipz6a.b32.i2p] Onion Address: [http://47ggr2fa3vnwfyhvgskzdmr3i32eijwymxohtxsls45dulmriwxszjad.onion]