dual-keys by default, tidy up

Use dual keys by default
Merge pull request #3 from bonedaddy/fix/mutex
2020-09-03 16:21:53 -04:00 · 2020-09-03 16:19:12 -04:00 · 2020-09-02 12:04:38 +00:00 · 2020-09-02 12:03:43 +00:00 · 2020-08-30 18:34:41 -07:00 · 2020-08-30 17:59:30 -07:00
31 changed files with 1308 additions and 682 deletions
--- a/.gitignore
+++ b/.gitignore
@@ -20,3 +20,6 @@ _cgo_export.*
 _testmain.go

 *.exe
+itp-golang-github-eyedeekay-gosam.txt
+.pc
+deb/
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -0,0 +1,195 @@
+How to make contributions to goSam
+==================================
+
+Welcome to goSam, the easy-to-use http client for i2p. We're glad you're here
+and interested in contributing. Here's some help getting started.
+
+Table of Contents
+-----------------
+
+  * (1) Environment
+  * (2) Testing
+  * (3) Filing Issues/Reporting Bugs/Making Suggestions
+  * (4) Contributing Code/Style Guide
+    - (a) Adding i2cp and tunnel Options
+    - (b) Writing Tests
+    - (c) Style
+    - (d) Other kinds of modification?
+  * (5) Conduct
+
+### (1) Environment
+
+goSam is a simple go library. You are free to use an IDE if you wish, but all
+that is required to build and test the library are a go compiler and the gofmt
+tool. Git is the version control system. All the files in the library are in a
+single root directory. Invoking go build from this directory not generate any
+files.
+
+### (2) Testing
+
+Tests are implemented using the standard go "testing" library in files named
+"file\_test.go," so tests of the client go in client\_test.go, name lookups
+in naming\_test.go, et cetera. Everything that can be tested, should be tested.
+
+Testing is done by running
+
+        go test
+
+More information about designing tests is below in the
+**Contributing Code/Style Guide** section below.
+
+### (3) Filing issues/Reporting bugs/Making suggestions
+
+If you discover the library doing something you don't think is right, please let
+us know! Just filing an issue here is OK.
+
+If you need to suggest a feature, we're happy to hear from you too. Filing an
+issue will give us a place to discuss how it's implemented openly and publicly.
+
+Please file an issue for your new code contributions in order to provide us with
+a place to discuss them for inclusion.
+
+### (4) Contributing Code/Style Guide
+
+Welcome new coders. We have good news for you, this library is really easy to
+contribute to. The easiest contributions take the form of i2cp and tunnel
+options.
+
+#### (a) Adding i2cp and tunnel Options
+
+First, add a variable to store the state of your new option. For example, the
+existing variables are in the Client class [here:](https://github.com/cryptix/goSam/blob/701d7fcf03ddb354262fe213163dcf6f202a24f1/client.go#L29)
+
+i2cp and tunnel options are added in a highly uniform process of basically three
+steps. First, you create a functional argument in the options.go file, in the
+form:
+
+``` Go
+        // SetOPTION sets $OPTION
+        func SetOPTION(arg type) func(*Client) error {  // arg type
+            return func(c *Client) error {              // pass a client to the inner function and declare error return function
+                if arg == valid {                       // validate the argument
+                    c.option = s                        // set the variable to the argument value
+                    return nil                          // if option is set successfully return nil error
+                }
+                return fmt.Errorf("Invalid argument:" arg) // return a descriptive error if arg is invalid
+            }
+        }
+```
+
+[example](https://github.com/cryptix/goSam/blob/701d7fcf03ddb354262fe213163dcf6f202a24f1/options.go#L187)
+
+Next, you create a getter which prepares the option. Regardless of the type of
+option that is set, these must return strings representing valid i2cp options.
+
+``` Go
+        //return the OPTION as a string.
+        func (c *Client) option() string {
+            return fmt.Sprintf("i2cp.option=%d", c.option)
+        }
+```
+
+[example](https://github.com/cryptix/goSam/blob/701d7fcf03ddb354262fe213163dcf6f202a24f1/options.go#L299)
+
+Lastly, you'll need to add it to the allOptions function and the
+Client.NewClient() function. To add it to allOptions, it looks like this:
+
+``` Go
+        //return all options as string ready for passing to sendcmd
+        func (c *Client) allOptions() string {
+            return c.inlength() + " " +
+                c.outlength() + " " +
+                ... //other options removed from example for brevity
+                c.option()
+        }
+```
+
+``` Go
+        //return all options as string ready for passing to sendcmd
+        func (c *Client) NewClient() (*Client, error) {
+            return NewClientFromOptions(
+                SetHost(c.host),
+                SetPort(c.port),
+                ... //other options removed from example for brevity
+                SetCompression(c.compression),
+                setlastaddr(c.lastaddr),
+                setid(c.id),
+            )
+        }
+```
+
+[example](https://github.com/cryptix/goSam/blob/701d7fcf03ddb354262fe213163dcf6f202a24f1/options.go#L333)
+
+#### (b) Writing Tests
+
+Before the feature can be added, you'll need to add a test for it to
+options_test.go. To do this, just add your new option to the long TestOptions
+functions in options_test.go.
+
+``` Go
+        func TestOptionHost(t *testing.T) {
+            client, err := NewClientFromOptions(
+                SetHost("127.0.0.1"),
+                SetPort("7656"),
+                ... //other options removed from example for brevity
+                SetCloseIdleTime(300001),
+            )
+            if err != nil {
+                t.Fatalf("NewClientFromOptions() Error: %q\n", err)
+            }
+            if result, err := client.validCreate(); err != nil {
+                t.Fatalf(err.Error())
+            } else {
+                t.Log(result)
+            }
+            client.CreateStreamSession("")
+            if err := client.Close(); err != nil {
+                t.Fatalf("client.Close() Error: %q\n", err)
+            }
+        }
+
+        func TestOptionPortInt(t *testing.T) {
+            client, err := NewClientFromOptions(
+                SetHost("127.0.0.1"),
+                SetPortInt(7656),
+                ... //other options removed from example for brevity
+                SetUnpublished(true),
+            )
+            if err != nil {
+                t.Fatalf("NewClientFromOptions() Error: %q\n", err)
+            }
+            if result, err := client.validCreate(); err != nil {
+                t.Fatalf(err.Error())
+            } else {
+                t.Log(result)
+            }
+            client.CreateStreamSession("")
+            if err := client.Close(); err != nil {
+                t.Fatalf("client.Close() Error: %q\n", err)
+            }
+        }
+
+```
+
+If any of these tasks fail, then the test should fail.
+
+#### (c) Style
+
+It's pretty simple to make sure the code style is right, just run gofmt over it
+to adjust the indentation, and golint over it to ensure that your comments are
+of the correct form for the documentation generator.
+
+#### (d) Other kinds of modification?
+
+It may be useful to extend goSam in other ways. Since there's not a
+one-size-fits-all uniform way of dealing with these kinds of changes, open an
+issue for discussion and
+
+### (5) Conduct
+
+This is a small-ish, straightforward library intended to enable a clear
+technical task. We should be able to be civil with eachother, and give and
+accept criticism contructively and respectfully.
+
+This document was drawn from the examples given by Mozilla
+[here](mozillascience.github.io/working-open-workshop/contributing/)
--- a/351
+++ b/351
@@ -1,339 +1,22 @@
-GNU GENERAL PUBLIC LICENSE
-                       Version 2, June 1991
+The MIT License (MIT)

- Copyright (C) 1989, 1991 Free Software Foundation, Inc., <http://fsf.org/>
- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- Everyone is permitted to copy and distribute verbatim copies
- of this license document, but changing it is not allowed.
+Copyright (c) 2014 Henry

-                            Preamble
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:

-  The licenses for most software are designed to take away your
-freedom to share and change it.  By contrast, the GNU General Public
-License is intended to guarantee your freedom to share and change free
-software--to make sure the software is free for all its users.  This
-General Public License applies to most of the Free Software
-Foundation's software and to any other program whose authors commit to
-using it.  (Some other Free Software Foundation software is covered by
-the GNU Lesser General Public License instead.)  You can apply it to
-your programs, too.
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.

-  When we speak of free software, we are referring to freedom, not
-price.  Our General Public Licenses are designed to make sure that you
-have the freedom to distribute copies of free software (and charge for
-this service if you wish), that you receive source code or can get it
-if you want it, that you can change the software or use pieces of it
-in new free programs; and that you know you can do these things.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

-  To protect your rights, we need to make restrictions that forbid
-anyone to deny you these rights or to ask you to surrender the rights.
-These restrictions translate to certain responsibilities for you if you
-distribute copies of the software, or if you modify it.
-
-  For example, if you distribute copies of such a program, whether
-gratis or for a fee, you must give the recipients all the rights that
-you have.  You must make sure that they, too, receive or can get the
-source code.  And you must show them these terms so they know their
-rights.
-
-  We protect your rights with two steps: (1) copyright the software, and
-(2) offer you this license which gives you legal permission to copy,
-distribute and/or modify the software.
-
-  Also, for each author's protection and ours, we want to make certain
-that everyone understands that there is no warranty for this free
-software.  If the software is modified by someone else and passed on, we
-want its recipients to know that what they have is not the original, so
-that any problems introduced by others will not reflect on the original
-authors' reputations.
-
-  Finally, any free program is threatened constantly by software
-patents.  We wish to avoid the danger that redistributors of a free
-program will individually obtain patent licenses, in effect making the
-program proprietary.  To prevent this, we have made it clear that any
-patent must be licensed for everyone's free use or not licensed at all.
-
-  The precise terms and conditions for copying, distribution and
-modification follow.
-
-                    GNU GENERAL PUBLIC LICENSE
-   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
-
-  0. This License applies to any program or other work which contains
-a notice placed by the copyright holder saying it may be distributed
-under the terms of this General Public License.  The "Program", below,
-refers to any such program or work, and a "work based on the Program"
-means either the Program or any derivative work under copyright law:
-that is to say, a work containing the Program or a portion of it,
-either verbatim or with modifications and/or translated into another
-language.  (Hereinafter, translation is included without limitation in
-the term "modification".)  Each licensee is addressed as "you".
-
-Activities other than copying, distribution and modification are not
-covered by this License; they are outside its scope.  The act of
-running the Program is not restricted, and the output from the Program
-is covered only if its contents constitute a work based on the
-Program (independent of having been made by running the Program).
-Whether that is true depends on what the Program does.
-
-  1. You may copy and distribute verbatim copies of the Program's
-source code as you receive it, in any medium, provided that you
-conspicuously and appropriately publish on each copy an appropriate
-copyright notice and disclaimer of warranty; keep intact all the
-notices that refer to this License and to the absence of any warranty;
-and give any other recipients of the Program a copy of this License
-along with the Program.
-
-You may charge a fee for the physical act of transferring a copy, and
-you may at your option offer warranty protection in exchange for a fee.
-
-  2. You may modify your copy or copies of the Program or any portion
-of it, thus forming a work based on the Program, and copy and
-distribute such modifications or work under the terms of Section 1
-above, provided that you also meet all of these conditions:
-
-    a) You must cause the modified files to carry prominent notices
-    stating that you changed the files and the date of any change.
-
-    b) You must cause any work that you distribute or publish, that in
-    whole or in part contains or is derived from the Program or any
-    part thereof, to be licensed as a whole at no charge to all third
-    parties under the terms of this License.
-
-    c) If the modified program normally reads commands interactively
-    when run, you must cause it, when started running for such
-    interactive use in the most ordinary way, to print or display an
-    announcement including an appropriate copyright notice and a
-    notice that there is no warranty (or else, saying that you provide
-    a warranty) and that users may redistribute the program under
-    these conditions, and telling the user how to view a copy of this
-    License.  (Exception: if the Program itself is interactive but
-    does not normally print such an announcement, your work based on
-    the Program is not required to print an announcement.)
-
-These requirements apply to the modified work as a whole.  If
-identifiable sections of that work are not derived from the Program,
-and can be reasonably considered independent and separate works in
-themselves, then this License, and its terms, do not apply to those
-sections when you distribute them as separate works.  But when you
-distribute the same sections as part of a whole which is a work based
-on the Program, the distribution of the whole must be on the terms of
-this License, whose permissions for other licensees extend to the
-entire whole, and thus to each and every part regardless of who wrote it.
-
-Thus, it is not the intent of this section to claim rights or contest
-your rights to work written entirely by you; rather, the intent is to
-exercise the right to control the distribution of derivative or
-collective works based on the Program.
-
-In addition, mere aggregation of another work not based on the Program
-with the Program (or with a work based on the Program) on a volume of
-a storage or distribution medium does not bring the other work under
-the scope of this License.
-
-  3. You may copy and distribute the Program (or a work based on it,
-under Section 2) in object code or executable form under the terms of
-Sections 1 and 2 above provided that you also do one of the following:
-
-    a) Accompany it with the complete corresponding machine-readable
-    source code, which must be distributed under the terms of Sections
-    1 and 2 above on a medium customarily used for software interchange; or,
-
-    b) Accompany it with a written offer, valid for at least three
-    years, to give any third party, for a charge no more than your
-    cost of physically performing source distribution, a complete
-    machine-readable copy of the corresponding source code, to be
-    distributed under the terms of Sections 1 and 2 above on a medium
-    customarily used for software interchange; or,
-
-    c) Accompany it with the information you received as to the offer
-    to distribute corresponding source code.  (This alternative is
-    allowed only for noncommercial distribution and only if you
-    received the program in object code or executable form with such
-    an offer, in accord with Subsection b above.)
-
-The source code for a work means the preferred form of the work for
-making modifications to it.  For an executable work, complete source
-code means all the source code for all modules it contains, plus any
-associated interface definition files, plus the scripts used to
-control compilation and installation of the executable.  However, as a
-special exception, the source code distributed need not include
-anything that is normally distributed (in either source or binary
-form) with the major components (compiler, kernel, and so on) of the
-operating system on which the executable runs, unless that component
-itself accompanies the executable.
-
-If distribution of executable or object code is made by offering
-access to copy from a designated place, then offering equivalent
-access to copy the source code from the same place counts as
-distribution of the source code, even though third parties are not
-compelled to copy the source along with the object code.
-
-  4. You may not copy, modify, sublicense, or distribute the Program
-except as expressly provided under this License.  Any attempt
-otherwise to copy, modify, sublicense or distribute the Program is
-void, and will automatically terminate your rights under this License.
-However, parties who have received copies, or rights, from you under
-this License will not have their licenses terminated so long as such
-parties remain in full compliance.
-
-  5. You are not required to accept this License, since you have not
-signed it.  However, nothing else grants you permission to modify or
-distribute the Program or its derivative works.  These actions are
-prohibited by law if you do not accept this License.  Therefore, by
-modifying or distributing the Program (or any work based on the
-Program), you indicate your acceptance of this License to do so, and
-all its terms and conditions for copying, distributing or modifying
-the Program or works based on it.
-
-  6. Each time you redistribute the Program (or any work based on the
-Program), the recipient automatically receives a license from the
-original licensor to copy, distribute or modify the Program subject to
-these terms and conditions.  You may not impose any further
-restrictions on the recipients' exercise of the rights granted herein.
-You are not responsible for enforcing compliance by third parties to
-this License.
-
-  7. If, as a consequence of a court judgment or allegation of patent
-infringement or for any other reason (not limited to patent issues),
-conditions are imposed on you (whether by court order, agreement or
-otherwise) that contradict the conditions of this License, they do not
-excuse you from the conditions of this License.  If you cannot
-distribute so as to satisfy simultaneously your obligations under this
-License and any other pertinent obligations, then as a consequence you
-may not distribute the Program at all.  For example, if a patent
-license would not permit royalty-free redistribution of the Program by
-all those who receive copies directly or indirectly through you, then
-the only way you could satisfy both it and this License would be to
-refrain entirely from distribution of the Program.
-
-If any portion of this section is held invalid or unenforceable under
-any particular circumstance, the balance of the section is intended to
-apply and the section as a whole is intended to apply in other
-circumstances.
-
-It is not the purpose of this section to induce you to infringe any
-patents or other property right claims or to contest validity of any
-such claims; this section has the sole purpose of protecting the
-integrity of the free software distribution system, which is
-implemented by public license practices.  Many people have made
-generous contributions to the wide range of software distributed
-through that system in reliance on consistent application of that
-system; it is up to the author/donor to decide if he or she is willing
-to distribute software through any other system and a licensee cannot
-impose that choice.
-
-This section is intended to make thoroughly clear what is believed to
-be a consequence of the rest of this License.
-
-  8. If the distribution and/or use of the Program is restricted in
-certain countries either by patents or by copyrighted interfaces, the
-original copyright holder who places the Program under this License
-may add an explicit geographical distribution limitation excluding
-those countries, so that distribution is permitted only in or among
-countries not thus excluded.  In such case, this License incorporates
-the limitation as if written in the body of this License.
-
-  9. The Free Software Foundation may publish revised and/or new versions
-of the General Public License from time to time.  Such new versions will
-be similar in spirit to the present version, but may differ in detail to
-address new problems or concerns.
-
-Each version is given a distinguishing version number.  If the Program
-specifies a version number of this License which applies to it and "any
-later version", you have the option of following the terms and conditions
-either of that version or of any later version published by the Free
-Software Foundation.  If the Program does not specify a version number of
-this License, you may choose any version ever published by the Free Software
-Foundation.
-
-  10. If you wish to incorporate parts of the Program into other free
-programs whose distribution conditions are different, write to the author
-to ask for permission.  For software which is copyrighted by the Free
-Software Foundation, write to the Free Software Foundation; we sometimes
-make exceptions for this.  Our decision will be guided by the two goals
-of preserving the free status of all derivatives of our free software and
-of promoting the sharing and reuse of software generally.
-
-                            NO WARRANTY
-
-  11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
-FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW.  EXCEPT WHEN
-OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
-PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED
-OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
-MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.  THE ENTIRE RISK AS
-TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU.  SHOULD THE
-PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING,
-REPAIR OR CORRECTION.
-
-  12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
-WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
-REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES,
-INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING
-OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED
-TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY
-YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER
-PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
-POSSIBILITY OF SUCH DAMAGES.
-
-                     END OF TERMS AND CONDITIONS
-
-            How to Apply These Terms to Your New Programs
-
-  If you develop a new program, and you want it to be of the greatest
-possible use to the public, the best way to achieve this is to make it
-free software which everyone can redistribute and change under these terms.
-
-  To do so, attach the following notices to the program.  It is safest
-to attach them to the start of each source file to most effectively
-convey the exclusion of warranty; and each file should have at least
-the "copyright" line and a pointer to where the full notice is found.
-
-    {description}
-    Copyright (C) {year}  {fullname}
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License along
-    with this program; if not, write to the Free Software Foundation, Inc.,
-    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-
-Also add information on how to contact you by electronic and paper mail.
-
-If the program is interactive, make it output a short notice like this
-when it starts in an interactive mode:
-
-    Gnomovision version 69, Copyright (C) year name of author
-    Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
-    This is free software, and you are welcome to redistribute it
-    under certain conditions; type `show c' for details.
-
-The hypothetical commands `show w' and `show c' should show the appropriate
-parts of the General Public License.  Of course, the commands you use may
-be called something other than `show w' and `show c'; they could even be
-mouse-clicks or menu items--whatever suits your program.
-
-You should also get your employer (if you work as a programmer) or your
-school, if any, to sign a "copyright disclaimer" for the program, if
-necessary.  Here is a sample; alter the names:
-
-  Yoyodyne, Inc., hereby disclaims all copyright interest in the program
-  `Gnomovision' (which makes passes at compilers) written by James Hacker.
-
-  {signature of Ty Coon}, 1 April 1989
-  Ty Coon, President of Vice
-
-This General Public License does not permit incorporating your program into
-proprietary programs.  If your program is a subroutine library, you may
-consider it more useful to permit linking proprietary applications with the
-library.  If this is what you want to do, use the GNU Lesser General
-Public License instead of this License.
--- a/24
+++ b/24
@@ -0,0 +1,24 @@
+
+USER_GH=eyedeekay
+VERSION=0.32.25
+packagename=gosam
+
+echo:
+	@echo "type make version to do release $(VERSION)"
+
+version:
+	gothub release -s $(GITHUB_TOKEN) -u $(USER_GH) -r $(packagename) -t v$(VERSION) -d "version $(VERSION)"
+
+del:
+	gothub delete -s $(GITHUB_TOKEN) -u $(USER_GH) -r $(packagename) -t v$(VERSION)
+
+tar:
+	tar --exclude .git \
+		--exclude .go \
+		--exclude bin \
+		--exclude examples \
+		-cJvf ../$(packagename)_$(VERSION).orig.tar.xz .
+
+link:
+	rm -f ../goSam
+	ln -sf . ../goSam
--- a/README.md
+++ b/README.md
@@ -1,13 +1,16 @@
 goSam
 =====

-A go library for using the [I2P](https://geti2p.net/en/) Simple Anonymous Messaging ([SAM version 3.0](https://geti2p.net/en/docs/api/samv3)) bridge
+A go library for using the [I2P](https://geti2p.net/en/) Simple Anonymous
+Messaging ([SAM version 3.0](https://geti2p.net/en/docs/api/samv3)) bridge. It
+has support for SAM version 3.1 signature types.

-This is in an **early development stage**. I would love to hear about any issues or ideas for improvement.
+This is in an **early development stage**. I would love to hear about any
+issues or ideas for improvement.

 ## Installation
 ```
-go get github.com/cryptix/goSam
+go get github.com/eyedeekay/goSam
 ```

 ## Using it for HTTP Transport
@@ -67,7 +70,22 @@ func checkErr(err error) {
 }
 ```

+### .deb package
+
+A package for installing this on Debian is buildable, and a version for Ubuntu
+is available as a PPA and mirrored via i2p. To build the deb package, from the
+root of this repository with the build dependencies installed(git, i2p, go,
+debuild) run the command
+
+        debuild -us -uc
+
+to produce an unsigned deb for personal use only. For packagers,
+
+        debuild -S
+
+will produce a viable source package for use with Launchpad PPA's and other
+similar systems.
 ### TODO

 * Implement `STREAM ACCEPT` and `STREAM FORWARD`
-* Implement datagrams (Repliable and Anon)
+* Implement datagrams (Repliable and Anon)
--- a/accept.go
+++ b/accept.go
@@ -3,34 +3,61 @@ package goSam
 import (
 	"fmt"
 	"net"
-
-	"github.com/cryptix/go/debug"
 )

-// Accept creates a new Client and accepts a connection on it
-func (c *Client) Accept() (net.Conn, error) {
-	id, newAddr, err := c.CreateStreamSession("")
+// AcceptI2P creates a new Client and accepts a connection on it
+func (c *Client) AcceptI2P() (net.Conn, error) {
+	listener, err := c.Listen()
+	if err != nil {
+		return nil, err
+	}
+	return listener.Accept()
+}
+
+// Listen creates a new Client and returns a net.listener which *must* be started
+// with Accept
+func (c *Client) Listen() (net.Listener, error) {
+	return c.ListenI2P(c.destination)
+}
+
+// ListenI2P creates a new Client and returns a net.listener which *must* be started
+// with Accept
+func (c *Client) ListenI2P(dest string) (net.Listener, error) {
+	var err error
+	var id int32
+	c.id = c.NewID()
+	c.destination, err = c.CreateStreamSession(id, dest)
 	if err != nil {
 		return nil, err
 	}

-	fmt.Println("NewAddr:", newAddr)
+	fmt.Println("destination:", c.destination)

-	newC, err := NewDefaultClient()
+	c, err = c.NewClient()
 	if err != nil {
 		return nil, err
 	}

 	if c.debug {
-		newC.SamConn = debug.WrapConn(newC.SamConn)
+		c.SamConn = WrapConn(c.SamConn)
 	}

-	resp, err := newC.StreamAccept(id)
+	return c, nil
+}
+
+// Accept accepts a connection on a listening goSam.Client(Implements net.Listener)
+// or, if the connection isn't listening yet, just calls AcceptI2P for compatibility
+// with older versions.
+func (c *Client) Accept() (net.Conn, error) {
+	if c.id == 0 {
+		return c.AcceptI2P()
+	}
+	resp, err := c.StreamAccept(c.id)
 	if err != nil {
 		return nil, err
 	}

 	fmt.Println("Accept Resp:", resp)

-	return newC.SamConn, nil
+	return c.SamConn, nil
 }
--- a/client.go
+++ b/client.go
@@ -2,20 +2,31 @@ package goSam

 import (
 	"bufio"
+	"crypto/sha256"
+	"encoding/base32"
+	"encoding/base64"
+	"encoding/binary"
 	"fmt"
+	"math"
+	"math/rand"
 	"net"
-
-	"github.com/cryptix/go/debug"
+	"strings"
+	"sync"
 )

 // A Client represents a single Connection to the SAM bridge
 type Client struct {
-	host string
-	port string
+	host     string
+	port     string
+	fromport string
+	toport   string

 	SamConn net.Conn
 	rd      *bufio.Reader

+	sigType     string
+	destination string
+
 	inLength   uint
 	inVariance int
 	inQuantity uint
@@ -28,6 +39,7 @@ type Client struct {

 	dontPublishLease bool
 	encryptLease     bool
+	leaseSetEncType  string

 	reduceIdle         bool
 	reduceIdleTime     uint
@@ -36,9 +48,28 @@ type Client struct {
 	closeIdle     bool
 	closeIdleTime uint

+	compression bool
+
 	debug bool
+	//NEVER, EVER modify lastaddr or id yourself. They are used internally only.
+	lastaddr string
+	id       int32
+	ml       sync.Mutex
 }

+var SAMsigTypes = []string{
+	"SIGNATURE_TYPE=DSA_SHA1",
+	"SIGNATURE_TYPE=ECDSA_SHA256_P256",
+	"SIGNATURE_TYPE=ECDSA_SHA384_P384",
+	"SIGNATURE_TYPE=ECDSA_SHA512_P521",
+	"SIGNATURE_TYPE=EdDSA_SHA512_Ed25519",
+}
+
+var (
+	i2pB64enc *base64.Encoding = base64.NewEncoding("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-~")
+	i2pB32enc *base32.Encoding = base32.NewEncoding("abcdefghijklmnopqrstuvwxyz234567")
+)
+
 // NewDefaultClient creates a new client, connecting to the default host:port at localhost:7656
 func NewDefaultClient() (*Client, error) {
 	return NewClient("localhost:7656")
@@ -49,6 +80,41 @@ func NewClient(addr string) (*Client, error) {
 	return NewClientFromOptions(SetAddr(addr))
 }

+// NewID generates a random number to use as an tunnel name
+func (c *Client) NewID() int32 {
+	return rand.Int31n(math.MaxInt32)
+}
+
+// Destination returns the full destination of the local tunnel
+func (c *Client) Destination() string {
+	return c.destination
+}
+
+// Base32 returns the base32 of the local tunnel
+func (c *Client) Base32() string {
+	hash := sha256.New()
+	b64, err := i2pB64enc.DecodeString(c.Base64())
+	if err != nil {
+		return ""
+	}
+	hash.Write([]byte(b64))
+	return strings.ToLower(strings.Replace(i2pB32enc.EncodeToString(hash.Sum(nil)), "=", "", -1))
+}
+
+func (c *Client) base64() []byte {
+	if c.destination != "" {
+		s, _ := i2pB64enc.DecodeString(c.destination)
+		alen := binary.BigEndian.Uint16(s[385:387])
+		return s[:387+alen]
+	}
+	return []byte("")
+}
+
+// Base64 returns the base64 of the local tunnel
+func (c *Client) Base64() string {
+	return i2pB64enc.EncodeToString(c.base64())
+}
+
 // NewClientFromOptions creates a new client, connecting to a specified port
 func NewClientFromOptions(opts ...func(*Client) error) (*Client, error) {
 	var c Client
@@ -56,20 +122,25 @@ func NewClientFromOptions(opts ...func(*Client) error) (*Client, error) {
 	c.port = "7656"
 	c.inLength = 3
 	c.inVariance = 0
-	c.inQuantity = 4
-	c.inBackups = 2
+	c.inQuantity = 1
+	c.inBackups = 1
 	c.outLength = 3
 	c.outVariance = 0
-	c.outQuantity = 4
-	c.outBackups = 2
+	c.outQuantity = 1
+	c.outBackups = 1
 	c.dontPublishLease = true
 	c.encryptLease = false
 	c.reduceIdle = false
 	c.reduceIdleTime = 300000
-	c.reduceIdleQuantity = 4
+	c.reduceIdleQuantity = 1
 	c.closeIdle = true
 	c.closeIdleTime = 600000
-	c.debug = false
+	c.debug = true
+	c.sigType = SAMsigTypes[4]
+	c.id = 0
+	c.lastaddr = "invalid"
+	c.destination = ""
+	c.leaseSetEncType = "4,0"
 	for _, o := range opts {
 		if err := o(&c); err != nil {
 			return nil, err
@@ -80,13 +151,21 @@ func NewClientFromOptions(opts ...func(*Client) error) (*Client, error) {
 		return nil, err
 	}
 	if c.debug {
-		conn = debug.WrapConn(conn)
+		conn = WrapConn(conn)
 	}
 	c.SamConn = conn
 	c.rd = bufio.NewReader(conn)
 	return &c, c.hello()
 }

+func (p *Client) ID() string {
+	return fmt.Sprintf("%d", p.id)
+}
+
+func (p *Client) Addr() net.Addr {
+	return nil
+}
+
 //return the combined host:port of the SAM bridge
 func (c *Client) samaddr() string {
 	return fmt.Sprintf("%s:%s", c.host, c.port)
@@ -103,7 +182,7 @@ func (c *Client) hello() error {
 		return fmt.Errorf("Unknown Reply: %+v\n", r)
 	}

-	if r.Pairs["RESULT"] != "OK" || r.Pairs["VERSION"] != "3.0" {
+	if r.Pairs["RESULT"] != "OK" {
 		return fmt.Errorf("Handshake did not succeed\nReply:%+v\n", r)
 	}

@@ -129,3 +208,30 @@ func (c *Client) Close() error {
 	c.rd = nil
 	return c.SamConn.Close()
 }
+
+// NewClient generates an exact copy of the client with the same options
+func (c *Client) NewClient() (*Client, error) {
+	return NewClientFromOptions(
+		SetHost(c.host),
+		SetPort(c.port),
+		SetDebug(c.debug),
+		SetInLength(c.inLength),
+		SetOutLength(c.outLength),
+		SetInVariance(c.inVariance),
+		SetOutVariance(c.outVariance),
+		SetInQuantity(c.inQuantity),
+		SetOutQuantity(c.outQuantity),
+		SetInBackups(c.inBackups),
+		SetOutBackups(c.outBackups),
+		SetUnpublished(c.dontPublishLease),
+		SetEncrypt(c.encryptLease),
+		SetReduceIdle(c.reduceIdle),
+		SetReduceIdleTime(c.reduceIdleTime),
+		SetReduceIdleQuantity(c.reduceIdleQuantity),
+		SetCloseIdle(c.closeIdle),
+		SetCloseIdleTime(c.closeIdleTime),
+		SetCompression(c.compression),
+		setlastaddr(c.lastaddr),
+		setid(c.id),
+	)
+}
--- a/client_test.go
+++ b/client_test.go
@@ -1,3 +1,5 @@
+// +build nettest
+
 package goSam

 import "testing"
@@ -12,7 +14,6 @@ func setup(t *testing.T) {
 	if err != nil {
 		t.Fatalf("NewDefaultClient() Error: %q\n", err)
 	}
-
 }

 func teardown(t *testing.T) {
@@ -23,5 +24,15 @@ func teardown(t *testing.T) {

 func TestClientHello(t *testing.T) {
 	setup(t)
+	t.Log(client.Base32())
+	teardown(t)
+}
+
+func TestNewDestination(t *testing.T) {
+	setup(t)
+	t.Log(client.Base32())
+	if _, err := client.NewDestination(SAMsigTypes[3]); err != nil {
+		t.Error(err)
+	}
 	teardown(t)
 }
--- a/compat/compat.go
+++ b/compat/compat.go
@@ -0,0 +1,23 @@
+package samkeys
+
+import (
+	"fmt"
+	"github.com/eyedeekay/sam3/i2pkeys"
+	"strings"
+)
+
+func DestToKeys(dest string) (i2pkeys.I2PKeys, error) {
+	addr, err := i2pkeys.NewI2PAddrFromString(dest)
+	if err != nil {
+		return i2pkeys.I2PKeys{}, err
+	}
+	return i2pkeys.NewKeys(addr, dest), nil
+}
+
+func KeysToDest(keys i2pkeys.I2PKeys) (string, error) {
+	pksk := strings.SplitN(keys.String(), "\n", 2)
+	if len(pksk) != 2 {
+		return "", fmt.Errorf("Error converting from keys to destination")
+	}
+	return pksk[1], nil
+}
--- a/conn.go
+++ b/conn.go
@@ -0,0 +1,68 @@
+/*
+The MIT License (MIT)
+
+Copyright (c) 2014 Henry
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+*/
+
+package goSam
+
+import (
+	"log"
+	"net"
+	"time"
+)
+
+type Conn struct {
+	RWC
+	conn net.Conn
+}
+
+func WrapConn(c net.Conn) *Conn {
+	wrap := Conn{
+		conn: c,
+	}
+	wrap.Reader = NewReadLogger("<", c)
+	wrap.Writer = NewWriteLogger(">", c)
+	wrap.RWC.c = c
+	return &wrap
+}
+
+func (c *Conn) LocalAddr() net.Addr {
+	return c.conn.LocalAddr()
+}
+
+func (c *Conn) RemoteAddr() net.Addr {
+	return c.conn.RemoteAddr()
+}
+
+func (c *Conn) SetDeadline(t time.Time) error {
+	log.Println("WARNING: SetDeadline() not sure this works")
+	return c.conn.SetDeadline(t)
+}
+
+func (c *Conn) SetReadDeadline(t time.Time) error {
+	log.Println("WARNING: SetReadDeadline() not sure this works")
+	return c.conn.SetReadDeadline(t)
+}
+func (c *Conn) SetWriteDeadline(t time.Time) error {
+	log.Println("WARNING: SetWriteDeadline() not sure this works")
+	return c.conn.SetWriteDeadline(t)
+}
--- a/debian/changelog
+++ b/debian/changelog
@@ -0,0 +1,75 @@
+golang-github-eyedeekay-gosam (0.32.24) UNRELEASED; urgency=medium
+
+  * Improve the mutex thingy
+
+ -- idk <hankhill19580@gmail.com>  Tue, 25 Aug 2020 04:52:11 -0500
+  
+golang-github-eyedeekay-gosam (0.32.23) UNRELEASED; urgency=medium
+
+  * Protect Dial with a mutex to fix a lookup bug
+
+ -- idk <hankhill19580@gmail.com>  Tue, 25 Aug 2020 10:29:26 -0500
+
+golang-github-eyedeekay-gosam (0.3.2.1) bionic; urgency=medium
+
+  * Get rid of the debug directory, just move it into the source
+  * Get rid of the old example, just use the one in the README
+
+ -- idk <hankhill19580@gmail.com>  Sat, 08 Dec 2019 19:11:41 -0500
+
+golang-github-eyedeekay-gosam (0.3.2.0) bionic; urgency=medium
+
+  * Enable persistent destinations
+  * Make Base32 and Base64 addresses retrievable from client
+  * bug fixes
+
+ -- idk <hankhill19580@gmail.com>  Fri, 18 May 2019 18:12:21 -0500
+
+golang-github-eyedeekay-gosam (0.1.1) bionic; urgency=medium
+
+  * Incorporate all the recent bug-fixes and improvements and stabilize.
+
+ -- idk <hankhill19580@gmail.com>  Fri, 15 Mar 2019 14:46:21 -0500
+
+golang-github-eyedeekay-gosam (0.1.0+git20190221.2896c83ubuntu1+nmu2ubuntu1) bionic; urgency=medium
+
+  * only run the offline tests by default
+
+ -- idk <hankhill19580@gmail.com>  Thu, 28 Feb 2019 20:35:51 -0500
+
+golang-github-eyedeekay-gosam (0.1.0+git20190221.2896c83ubuntu1+nmu2) bionic; urgency=medium
+
+  [ idk ]
+  * incorporate cryptix-debug without the counter
+  * incorporate cryptix-debug without the counter
+  * fix module
+
+ -- idk <hankhill19580@gmail.com>  Thu, 28 Feb 2019 20:32:58 -0500
+
+golang-github-eyedeekay-gosam (0.1.0+git20190221.2896c83ubuntu1+nmu1) bionic; urgency=medium
+
+  * add sid
+  *
+
+ -- idk <hankhill19580@gmail.com>  Thu, 28 Feb 2019 18:52:01 -0500
+
+golang-github-eyedeekay-gosam (0.1.0+git20190221.2896c83ubuntu1) bionic; urgency=medium
+
+  [ idk ]
+  * Update changelog for 0.1.0+git20190221.2896c83-1 release
+  * add signature type support
+  * Don't check version if handshake succeeds, just accept that OK is OK
+  * Don't check version if handshake succeeds, just accept that OK is OK
+  * make dialer context aware and avoid redundant session create's
+  * make dialer context aware and avoid redundant session create's
+  * correct CONTRIBUTING.md
+  * correct CONTRIBUTING.md
+  * correct CONTRIBUTING.md
+  * explicitly et invalid initial lastaddr
+  * remove 'commented-out' id
+  * Initial release (Closes: TODO)
+
+  [ idk ]
+  * add bionic
+
+ -- idk <hankhill19580@gmail.com>  Thu, 28 Feb 2019 18:51:23 -0500
--- a/debian/compat
+++ b/debian/compat
@@ -0,0 +1 @@
+11
--- a/debian/control
+++ b/debian/control
@@ -0,0 +1,27 @@
+Source: golang-github-eyedeekay-gosam
+Section: devel
+Priority: optional
+Maintainer: idk <hankhill19580@gmail.com>
+Uploaders: idk <hankhill19580@gmail.com>
+Build-Depends: debhelper (>= 11),
+               dh-golang,
+               golang-any,
+               i2pd | i2p,
+               git,
+Standards-Version: 4.2.1
+Homepage: https://github.com/eyedeekay/gosam
+Vcs-Browser: https:/github.com/eyedeekay/gosam
+Vcs-Git: https://github.com/eyedeekay/gosam.git
+XS-Go-Import-Path: github.com/eyedeekay/gosam
+Testsuite: autopkgtest-pkg-go
+Launchpad-Bugs-Fixed: #1818159
+
+Package: golang-github-eyedeekay-gosam-dev
+Architecture: all
+Depends: ${misc:Depends},
+    i2pd | i2p
+Description: A go library for using the I2P (https://geti2p.net/en/)
+ Simple Anonymous Messaging (SAM version 3.1
+ (https://geti2p.net/en/docs/api/samv3)) bridge
+ .
+Launchpad-Bugs-Fixed: #1818159
--- a/debian/copyright
+++ b/debian/copyright
@@ -0,0 +1,22 @@
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: gosam
+Source: https://github.com/eyedeekay/gosam
+Files-Excluded:
+  Godeps/_workspace
+
+Files: *
+Copyright: 2014 cryptix
+Copyright: 2018 idk
+License: GPL-2.0
+
+Files: debug
+Copyright: 2014 cryptix
+LICENSE: MIT
+
+Files: debian/*
+Copyright: 2019 idk <hankhill19580@gmail.com>
+License: GPL-2.0
+Comment: Debian packaging is licensed under the same terms as upstream
+
+License: GPL-2.0
+TODO
--- a/debian/gbp.conf
+++ b/debian/gbp.conf
@@ -0,0 +1,2 @@
+[DEFAULT]
+pristine-tar = False
--- a/debian/rules
+++ b/debian/rules
@@ -0,0 +1,4 @@
+#!/usr/bin/make -f
+
+%:
+	dh $@ --buildsystem=golang --with=golang
--- a/debian/source/format
+++ b/debian/source/format
@@ -0,0 +1 @@
+3.0 (native)
--- a/debian/watch
+++ b/debian/watch
@@ -0,0 +1,4 @@
+version=4
+opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/golang-github-eyedeekay-gosam-\$1\.tar\.gz/,\
+uversionmangle=s/(\d)[_\.\-\+]?(RC|rc|pre|dev|beta|alpha)[.]?(\d*)$/\$1~\$2\$3/ \
+  https://github.com/eyedeekay/gosam/tags .*/v?(\d\S*)\.tar\.gz
--- a/dial.go
+++ b/dial.go
@@ -1,12 +1,50 @@
 package goSam

 import (
+	"context"
+	"fmt"
 	"net"
 	"strings"
 )

+// DialContext implements the net.DialContext function and can be used for http.Transport
+func (c *Client) DialContext(ctx context.Context, network, addr string) (net.Conn, error) {
+	errCh := make(chan error, 1)
+	connCh := make(chan net.Conn, 1)
+	go func() {
+		if conn, err := c.Dial(network, addr); err != nil {
+			errCh <- err
+		} else if ctx.Err() != nil {
+			conn.Close()
+		} else {
+			connCh <- conn
+		}
+	}()
+	select {
+	case err := <-errCh:
+		return nil, err
+	case conn := <-connCh:
+		return conn, nil
+	case <-ctx.Done():
+		return nil, ctx.Err()
+	}
+}
+
+func (c *Client) dialCheck(addr string) (int32, bool) {
+	if c.lastaddr == "invalid" {
+		fmt.Println("Preparing to dial new address.")
+		return c.NewID(), true
+	} else if c.lastaddr != addr {
+		fmt.Println("Preparing to dial next new address.")
+		return c.NewID(), true
+	}
+	return c.id, false
+}
+
 // Dial implements the net.Dial function and can be used for http.Transport
 func (c *Client) Dial(network, addr string) (net.Conn, error) {
+	c.ml.Lock()
+	defer c.ml.Unlock()
 	portIdx := strings.Index(addr, ":")
 	if portIdx >= 0 {
 		addr = addr[:portIdx]
@@ -16,20 +54,22 @@ func (c *Client) Dial(network, addr string) (net.Conn, error) {
 		return nil, err
 	}

-	id, _, err := c.CreateStreamSession("")
+	var test bool
+	if c.id, test = c.dialCheck(addr); test == true {
+		c.destination, err = c.CreateStreamSession(c.id, c.destination)
+		if err != nil {
+			return nil, err
+		}
+		c.lastaddr = addr
+	}
+	c, err = c.NewClient()
 	if err != nil {
 		return nil, err
 	}

-	newC, err := NewClient(c.samaddr())
+	err = c.StreamConnect(c.id, addr)
 	if err != nil {
 		return nil, err
 	}
-
-	err = newC.StreamConnect(id, addr)
-	if err != nil {
-		return nil, err
-	}
-
-	return newC.SamConn, nil
+	return c.SamConn, nil
 }
--- a/example/httpTest.go
+++ b/example/httpTest.go
@@ -1,53 +0,0 @@
-package main
-
-import (
-	"io"
-	"log"
-	"net/http"
-	"os"
-
-	"github.com/cryptix/goSam"
-)
-
-func main() {
-	//In order to enable debugging, pass the SetDebug(true) option.
-    //sam, err := goSam.NewClientFromOptions(SetDebug(true))
-
-	// create a default sam client
-	sam, err := goSam.NewDefaultClient()
-	checkErr(err)
-
-	log.Println("Client Created")
-
-	// create a transport that uses SAM to dial TCP Connections
-	tr := &http.Transport{
-		Dial: sam.Dial,
-	}
-
-	// create  a client using this transport
-	client := &http.Client{Transport: tr}
-
-	// send a get request
-	resp, err := client.Get("http://stats.i2p/")
-	checkErr(err)
-	defer resp.Body.Close()
-
-	log.Printf("Get returned %+v\n", resp)
-
-	// create a file for the response
-	file, err := os.Create("stats.html")
-	checkErr(err)
-	defer file.Close()
-
-	// copy the response to the file
-	_, err = io.Copy(file, resp.Body)
-	checkErr(err)
-
-	log.Println("Done.")
-}
-
-func checkErr(err error) {
-	if err != nil {
-		log.Fatal(err)
-	}
-}
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,11 @@
-module github.com/cryptix/goSam
+module github.com/eyedeekay/goSam

-require (
-	github.com/cryptix/go v1.3.1
-	github.com/miolini/datacounter v0.0.0-20171104152933-fd4e42a1d5e0 // indirect
-)
+require github.com/eyedeekay/sam3 v0.32.2
+
+//replace github.com/eyedeekay/gosam v0.1.1-0.20190814195658-27e786578944 => github.com/eyedeekay/goSam ./
+
+replace github.com/eyedeekay/gosam v0.32.1 => ./
+
+replace github.com/eyedeekay/goSam v0.32.1 => ./
+
+go 1.13
--- a/go.sum
+++ b/go.sum
@@ -1,8 +1,3 @@
-github.com/cryptix/go v1.3.1 h1:I9opbROgEpldI0PwkMku0UY2DLFYgelZd9u0uaxmMgY=
-github.com/cryptix/go v1.3.1/go.mod h1:mFQotm9rTzptzvNjJM+1vSIDa/rVOVqMu0889GIXg70=
-github.com/go-kit/kit v0.6.0/go.mod h1:xBxKIO96dXMWWy0MnWVtmwkA9/13aqxPnvrjFYMA2as=
-github.com/go-logfmt/logfmt v0.3.0/go.mod h1:Qt1PoO58o5twSAckw1HlFXLmHsOX5/0LbT9GBnD5lWE=
-github.com/go-stack/stack v1.7.0/go.mod h1:v0f6uXyyMGvRgIKkXu+yp6POWl0qKG85gN/melR3HDY=
-github.com/miolini/datacounter v0.0.0-20171104152933-fd4e42a1d5e0 h1:clkDYGefEWUCwyCrwYn900sOaVGDpinPJgD0W6ebEjs=
-github.com/miolini/datacounter v0.0.0-20171104152933-fd4e42a1d5e0/go.mod h1:P6fDJzlxN+cWYR09KbE9/ta+Y6JofX9tAUhJpWkWPaM=
-github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
+github.com/eyedeekay/ramp v0.0.0-20190429201811-305b382042ab/go.mod h1:h7mvUAMgZ/rtRDUOkvKTK+8LnDMeUhJSoa5EPdB51fc=
+github.com/eyedeekay/sam3 v0.32.2 h1:xODDY5nBVg0oK7KaYk7ofkXFoHPsmI1umhSv1TZlS7s=
+github.com/eyedeekay/sam3 v0.32.2/go.mod h1:Y3igFVzN4ybqkkpfUWULGhw7WRp8lieq0ORXbLBbcZM=
--- a/i2pkeys.go
+++ b/i2pkeys.go
@@ -0,0 +1,35 @@
+package goSam
+
+import (
+	"errors"
+
+	"github.com/eyedeekay/sam3/i2pkeys"
+)
+
+// NewDestination generates a new I2P destination, creating the underlying
+// public/private keys in the process. The public key can be used to send messages
+// to the destination, while the private key can be used to reply to messages
+func (c *Client) NewDestination(sigType ...string) (i2pkeys.I2PKeys, error) {
+	var (
+		sigtmp string
+		keys   i2pkeys.I2PKeys
+	)
+	if len(sigType) > 0 {
+		sigtmp = sigType[0]
+	}
+	r, err := c.sendCmd(
+		"DEST GENERATE %s\n",
+		sigtmp,
+	)
+	if err != nil {
+		return keys, err
+	}
+	var pub, priv string
+	if priv = r.Pairs["PRIV"]; priv == "" {
+		return keys, errors.New("failed to generate private destination key")
+	}
+	if pub = r.Pairs["PUB"]; pub == "" {
+		return keys, errors.New("failed to generate public destination key")
+	}
+	return i2pkeys.NewKeys(i2pkeys.I2PAddr(pub), priv), nil
+}
--- a/naming_test.go
+++ b/naming_test.go
@@ -1,3 +1,5 @@
+// +build nettest
+
 package goSam

 import (
@@ -20,8 +22,8 @@ func TestClientLookupInvalid(t *testing.T) {
 	if !ok {
 		t.Fatalf("client.Lookup() should return a ReplyError")
 	}
-	if repErr.Result != ResultInvalidKey {
-		t.Errorf("client.Lookup() should throw an ResultKeyNotFound error.\nGot:%+v\n", repErr)
+	if repErr.Result != ResultKeyNotFound {
+		t.Errorf("client.Lookup() should throw an ResultKeyNotFound error.\nGot:%+v%s%s\n", repErr, "!=", ResultKeyNotFound)
 	}
 }

@@ -44,5 +46,5 @@ func ExampleClient_Lookup() {

 	// Output:
 	//Address of zzz.i2p:
-	//GKapJ8koUcBj~jmQzHsTYxDg2tpfWj0xjQTzd8BhfC9c3OS5fwPBNajgF-eOD6eCjFTqTlorlh7Hnd8kXj1qblUGXT-tDoR9~YV8dmXl51cJn9MVTRrEqRWSJVXbUUz9t5Po6Xa247Vr0sJn27R4KoKP8QVj1GuH6dB3b6wTPbOamC3dkO18vkQkfZWUdRMDXk0d8AdjB0E0864nOT~J9Fpnd2pQE5uoFT6P0DqtQR2jsFvf9ME61aqLvKPPWpkgdn4z6Zkm-NJOcDz2Nv8Si7hli94E9SghMYRsdjU-knObKvxiagn84FIwcOpepxuG~kFXdD5NfsH0v6Uri3usE3uSzpWS0EHmrlfoLr5uGGd9ZHwwCIcgfOATaPRMUEQxiK9q48PS0V3EXXO4-YLT0vIfk4xO~XqZpn8~PW1kFe2mQMHd7oO89yCk-3yizRG3UyFtI7-mO~eCI6-m1spYoigStgoupnC3G85gJkqEjMm49gUjbhfWKWI-6NwTj0ZnAAAA
+	//GKapJ8koUcBj~jmQzHsTYxDg2tpfWj0xjQTzd8BhfC9c3OS5fwPBNajgF-eOD6eCjFTqTlorlh7Hnd8kXj1qblUGXT-tDoR9~YV8dmXl51cJn9MVTRrEqRWSJVXbUUz9t5Po6Xa247Vr0sJn27R4KoKP8QVj1GuH6dB3b6wTPbOamC3dkO18vkQkfZWUdRMDXk0d8AdjB0E0864nOT~J9Fpnd2pQE5uoFT6P0DqtQR2jsFvf9ME61aqLvKPPWpkgdn4z6Zkm-NJOcDz2Nv8Si7hli94E9SghMYRsdjU-knObKvxiagn84FIwcOpepxuG~kFXdD5NfsH0v6Uri3usE3XWD7Pw6P8qVYF39jUIq4OiNMwPnNYzy2N4mDMQdsdHO3LUVh~DEppOy9AAmEoHDjjJxt2BFBbGxfdpZCpENkwvmZeYUyNCCzASqTOOlNzdpne8cuesn3NDXIpNnqEE6Oe5Qm5YOJykrX~Vx~cFFT3QzDGkIjjxlFBsjUJyYkFjBQAEAAcAAA==
 }
--- a/options.go
+++ b/options.go
@@ -62,6 +62,29 @@ func SetHost(s string) func(*Client) error {
 	}
 }

+//SetLocalDestination sets the local destination of the tunnel from a private
+//key
+func SetLocalDestination(s string) func(*Client) error {
+	return func(c *Client) error {
+		c.destination = s
+		return nil
+	}
+}
+
+func setlastaddr(s string) func(*Client) error {
+	return func(c *Client) error {
+		c.lastaddr = s
+		return nil
+	}
+}
+
+func setid(s int32) func(*Client) error {
+	return func(c *Client) error {
+		c.id = s
+		return nil
+	}
+}
+
 //SetPort sets the port of the client's SAM bridge using a string
 func SetPort(s string) func(*Client) error {
 	return func(c *Client) error {
@@ -88,6 +111,58 @@ func SetPortInt(i int) func(*Client) error {
 	}
 }

+//SetFromPort sets the port of the client's SAM bridge using a string
+func SetFromPort(s string) func(*Client) error {
+	return func(c *Client) error {
+		port, err := strconv.Atoi(s)
+		if err != nil {
+			return fmt.Errorf("Invalid port; non-number")
+		}
+		if port < 65536 && port > -1 {
+			c.fromport = s
+			return nil
+		}
+		return fmt.Errorf("Invalid port")
+	}
+}
+
+//SetFromPortInt sets the port of the client's SAM bridge using a string
+func SetFromPortInt(i int) func(*Client) error {
+	return func(c *Client) error {
+		if i < 65536 && i > -1 {
+			c.fromport = strconv.Itoa(i)
+			return nil
+		}
+		return fmt.Errorf("Invalid port")
+	}
+}
+
+//SetToPort sets the port of the client's SAM bridge using a string
+func SetToPort(s string) func(*Client) error {
+	return func(c *Client) error {
+		port, err := strconv.Atoi(s)
+		if err != nil {
+			return fmt.Errorf("Invalid port; non-number")
+		}
+		if port < 65536 && port > -1 {
+			c.toport = s
+			return nil
+		}
+		return fmt.Errorf("Invalid port")
+	}
+}
+
+//SetToPortInt sets the port of the client's SAM bridge using a string
+func SetToPortInt(i int) func(*Client) error {
+	return func(c *Client) error {
+		if i < 65536 && i > -1 {
+			c.fromport = strconv.Itoa(i)
+			return nil
+		}
+		return fmt.Errorf("Invalid port")
+	}
+}
+
 //SetDebug enables debugging messages
 func SetDebug(b bool) func(*Client) error {
 	return func(c *Client) error {
@@ -200,7 +275,15 @@ func SetEncrypt(b bool) func(*Client) error {
 	}
 }

-//SetReduceIdle tells the router to use an encrypted leaseset
+//SetLeaseSetEncType tells the router to use an encrypted leaseset
+func SetLeaseSetEncType(b string) func(*Client) error {
+	return func(c *Client) error {
+		c.leaseSetEncType = b
+		return nil
+	}
+}
+
+//SetReduceIdle sets the created tunnels to be reduced during extended idle time to avoid excessive resource usage
 func SetReduceIdle(b bool) func(*Client) error {
 	return func(c *Client) error {
 		c.reduceIdle = b
@@ -208,10 +291,10 @@ func SetReduceIdle(b bool) func(*Client) error {
 	}
 }

-//SetReduceIdleTime sets the inbound tunnel backups
+//SetReduceIdleTime sets time to wait before the tunnel quantity is reduced
 func SetReduceIdleTime(u uint) func(*Client) error {
 	return func(c *Client) error {
-		if u > 300000 {
+		if u > 299999 {
 			c.reduceIdleTime = u
 			return nil
 		}
@@ -219,7 +302,7 @@ func SetReduceIdleTime(u uint) func(*Client) error {
 	}
 }

-//SetReduceIdleQuantity sets the inbound tunnel backups
+//SetReduceIdleQuantity sets number of tunnels to keep alive during an extended idle period
 func SetReduceIdleQuantity(u uint) func(*Client) error {
 	return func(c *Client) error {
 		if u < 5 {
@@ -230,7 +313,7 @@ func SetReduceIdleQuantity(u uint) func(*Client) error {
 	}
 }

-//SetCloseIdle tells the router to use an encrypted leaseset
+//SetCloseIdle sets the tunnels to close after a specific amount of time
 func SetCloseIdle(b bool) func(*Client) error {
 	return func(c *Client) error {
 		c.closeIdle = b
@@ -238,10 +321,10 @@ func SetCloseIdle(b bool) func(*Client) error {
 	}
 }

-//SetCloseIdleTime sets the inbound tunnel backups
+//SetCloseIdleTime sets the time in milliseconds to wait before closing tunnels
 func SetCloseIdleTime(u uint) func(*Client) error {
 	return func(c *Client) error {
-		if u > 300000 {
+		if u > 299999 {
 			c.closeIdleTime = u
 			return nil
 		}
@@ -249,103 +332,193 @@ func SetCloseIdleTime(u uint) func(*Client) error {
 	}
 }

+//SetCompression sets the tunnels to close after a specific amount of time
+func SetCompression(b bool) func(*Client) error {
+	return func(c *Client) error {
+		c.compression = b
+		return nil
+	}
+}
+
+/* SAM v 3.1 Options*/
+
+//SetSignatureType tells gosam to pass SAM a signature_type parameter with one
+// of the following values:
+//    "SIGNATURE_TYPE=DSA_SHA1",
+//    "SIGNATURE_TYPE=ECDSA_SHA256_P256",
+//    "SIGNATURE_TYPE=ECDSA_SHA384_P384",
+//    "SIGNATURE_TYPE=ECDSA_SHA512_P521",
+//    "SIGNATURE_TYPE=EdDSA_SHA512_Ed25519",
+// or an empty string
+func SetSignatureType(s string) func(*Client) error {
+	return func(c *Client) error {
+		if s == "" {
+			c.sigType = ""
+			return nil
+		}
+		for _, valid := range SAMsigTypes {
+			if s == valid {
+				c.sigType = valid
+				return nil
+			}
+		}
+		return fmt.Errorf("Invalid signature type specified at construction time")
+	}
+}
+
+//return the from port as a string.
+func (c *Client) from() string {
+	if c.fromport == "" {
+		return ""
+	}
+	return fmt.Sprintf(" FROM_PORT=%v ", c.fromport)
+}
+
+//return the to port as a string.
+func (c *Client) to() string {
+	if c.toport == "" {
+		return ""
+	}
+	return fmt.Sprintf(" TO_PORT=%v ", c.toport)
+}
+
+//return the signature type as a string.
+func (c *Client) sigtype() string {
+	return fmt.Sprintf(" %s ", c.sigType)
+}
+
 //return the inbound length as a string.
 func (c *Client) inlength() string {
-	return fmt.Sprintf("inbound.length=%d", c.inLength)
+	return fmt.Sprintf(" inbound.length=%d ", c.inLength)
 }

 //return the outbound length as a string.
 func (c *Client) outlength() string {
-	return fmt.Sprintf("outbound.length=%d", c.outLength)
+	return fmt.Sprintf(" outbound.length=%d ", c.outLength)
 }

 //return the inbound length variance as a string.
 func (c *Client) invariance() string {
-	return fmt.Sprintf("inbound.lengthVariance=%d", c.inVariance)
+	return fmt.Sprintf(" inbound.lengthVariance=%d ", c.inVariance)
 }

 //return the outbound length variance as a string.
 func (c *Client) outvariance() string {
-	return fmt.Sprintf("outbound.lengthVariance=%d", c.outVariance)
+	return fmt.Sprintf(" outbound.lengthVariance=%d ", c.outVariance)
 }

 //return the inbound tunnel quantity as a string.
 func (c *Client) inquantity() string {
-	return fmt.Sprintf("inbound.quantity=%d", c.inQuantity)
+	return fmt.Sprintf(" inbound.quantity=%d ", c.inQuantity)
 }

 //return the outbound tunnel quantity as a string.
 func (c *Client) outquantity() string {
-	return fmt.Sprintf("outbound.quantity=%d", c.outQuantity)
+	return fmt.Sprintf(" outbound.quantity=%d ", c.outQuantity)
 }

 //return the inbound tunnel quantity as a string.
 func (c *Client) inbackups() string {
-	return fmt.Sprintf("inbound.backupQuantity=%d", c.inQuantity)
+	return fmt.Sprintf(" inbound.backupQuantity=%d ", c.inQuantity)
 }

 //return the outbound tunnel quantity as a string.
 func (c *Client) outbackups() string {
-	return fmt.Sprintf("outbound.backupQuantity=%d", c.outQuantity)
+	return fmt.Sprintf(" outbound.backupQuantity=%d ", c.outQuantity)
 }

 func (c *Client) encryptlease() string {
 	if c.encryptLease {
-		return "i2cp.encryptLeaseSet=true"
+		return " i2cp.encryptLeaseSet=true "
 	}
-	return "i2cp.encryptLeaseSet=false"
+	return " i2cp.encryptLeaseSet=false "
+}
+
+func (c *Client) leasesetenctype() string {
+	if c.encryptLease {
+		return fmt.Sprintf(" i2cp.leaseSetEncType=%s ", c.leaseSetEncType)
+	}
+	return " i2cp.leaseSetEncType=4,0 "
 }

 func (c *Client) dontpublishlease() string {
 	if c.dontPublishLease {
-		return "i2cp.dontPublishLeaseSet=true"
+		return " i2cp.dontPublishLeaseSet=true "
 	}
-	return "i2cp.dontPublishLeaseSet=false"
+	return " i2cp.dontPublishLeaseSet=false "
 }

 func (c *Client) closeonidle() string {
 	if c.closeIdle {
-		return "i2cp.closeOnIdle=true"
+		return " i2cp.closeOnIdle=true "
 	}
-	return "i2cp.closeOnIdle=false"
+	return " i2cp.closeOnIdle=false "
 }

 func (c *Client) closeidletime() string {
-	return fmt.Sprintf("i2cp.closeIdleTime=%d", c.closeIdleTime)
+	return fmt.Sprintf(" i2cp.closeIdleTime=%d ", c.closeIdleTime)
 }

 func (c *Client) reduceonidle() string {
 	if c.reduceIdle {
-		return "i2cp.reduceOnIdle=true"
+		return " i2cp.reduceOnIdle=true "
 	}
-	return "i2cp.reduceOnIdle=false"
+	return " i2cp.reduceOnIdle=false "
 }

 func (c *Client) reduceidletime() string {
-	return fmt.Sprintf("i2cp.reduceIdleTime=%d", c.reduceIdleTime)
+	return fmt.Sprintf(" i2cp.reduceIdleTime=%d ", c.reduceIdleTime)
 }

 func (c *Client) reduceidlecount() string {
-	return fmt.Sprintf("i2cp.reduceIdleQuantity=%d", c.reduceIdleQuantity)
+	return fmt.Sprintf(" i2cp.reduceIdleQuantity=%d ", c.reduceIdleQuantity)
 }

-//return all options as string array ready for passing to sendcmd
-func (c *Client) allOptions() []string {
-	return []string{
-		c.inlength(),
-		c.outlength(),
-		c.invariance(),
-		c.outvariance(),
-		c.inquantity(),
-		c.outquantity(),
-		c.inbackups(),
-		c.outbackups(),
-		c.dontpublishlease(),
-		c.encryptlease(),
-		c.reduceonidle(),
-		c.reduceidletime(),
-		c.reduceidlecount(),
-		c.closeonidle(),
-		c.closeidletime(),
+func (c *Client) compresion() string {
+	if c.compression {
+		return " i2cp.gzip=true "
 	}
+	return " i2cp.gzip=false "
+}
+
+//return all options as string ready for passing to sendcmd
+func (c *Client) allOptions() string {
+	return c.inlength() +
+		c.outlength() +
+		c.invariance() +
+		c.outvariance() +
+		c.inquantity() +
+		c.outquantity() +
+		c.inbackups() +
+		c.outbackups() +
+		c.dontpublishlease() +
+		c.encryptlease() +
+		c.leasesetenctype() +
+		c.reduceonidle() +
+		c.reduceidletime() +
+		c.reduceidlecount() +
+		c.closeonidle() +
+		c.closeidletime() +
+		c.compresion()
+}
+
+//Print return all options as string
+func (c *Client) Print() string {
+	return c.inlength() +
+		c.outlength() +
+		c.invariance() +
+		c.outvariance() +
+		c.inquantity() +
+		c.outquantity() +
+		c.inbackups() +
+		c.outbackups() +
+		c.dontpublishlease() +
+		c.encryptlease() +
+		c.leasesetenctype() +
+		c.reduceonidle() +
+		c.reduceidletime() +
+		c.reduceidlecount() +
+		c.closeonidle() +
+		c.closeidletime() +
+		c.compresion()
 }
--- a/options_test.go
+++ b/options_test.go
@@ -1,241 +1,188 @@
+// +build nettest
+
 package goSam

-import "testing"
+import (
+	"fmt"
+	"math"
+	"math/rand"
+	//"net/http"
+	"strings"
+	"testing"
+)
+
+// helper to validate sendCmd inputs
+func (c *Client) validCmd(str string, args ...interface{}) (string, error) {
+	if s := fmt.Sprintf(str, args...); strings.Contains(s, "\n") {
+		sl := strings.Split(s, "\n")
+		if len(sl) == 2 {
+			if sl[1] != "" {
+				return sl[1], fmt.Errorf("Error, there should be no options after the newline")
+			}
+			for li, in := range sl {
+				fmt.Println(li, in)
+			}
+			return s, nil
+		}
+		return "", fmt.Errorf("Error, invalid length: %d", len(sl))
+	}
+	return "", fmt.Errorf("Error, invalid input")
+}
+
+func (c *Client) validCreate() (string, error) {
+	id := rand.Int31n(math.MaxInt32)
+	result, err := c.validCmd("SESSION CREATE STYLE=STREAM ID=%d DESTINATION=%s %s\n", id, "abc.i2p", client.allOptions())
+	return result, err
+}

 func TestOptionAddrString(t *testing.T) {
 	client, err := NewClientFromOptions(SetAddr("127.0.0.1:7656"), SetDebug(true))
 	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
+		t.Fatalf("NewClientFromOptions() Error: %q\n", err)
 	}
+	if result, err := client.validCreate(); err != nil {
+		t.Fatalf(err.Error())
+	} else {
+		t.Log(result)
+	}
+	dest, _ := client.CreateStreamSession(client.NewID(), "")
 	if err := client.Close(); err != nil {
 		t.Fatalf("client.Close() Error: %q\n", err)
 	}
+	fmt.Printf("\t destination- %s \n", dest)
+	fmt.Printf("\t address64- %s \t", client.Base64())
+	fmt.Printf("\t address- %s \t", client.Base32())
 }

 func TestOptionAddrStringLh(t *testing.T) {
 	client, err := NewClientFromOptions(SetAddr("localhost:7656"), SetDebug(true))
 	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
+		t.Fatalf("NewClientFromOptions() Error: %q\n", err)
 	}
+	if result, err := client.validCreate(); err != nil {
+		t.Fatalf(err.Error())
+	} else {
+		t.Log(result)
+	}
+	dest, _ := client.CreateStreamSession(client.NewID(), "")
 	if err := client.Close(); err != nil {
 		t.Fatalf("client.Close() Error: %q\n", err)
 	}
+	fmt.Printf("\t destination- %s \n", dest)
+	fmt.Printf("\t address64- %s \t", client.Base64())
+	fmt.Printf("\t address- %s \t", client.Base32())
 }

 func TestOptionAddrSlice(t *testing.T) {
 	client, err := NewClientFromOptions(SetAddr("127.0.0.1", "7656"), SetDebug(true))
 	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
+		t.Fatalf("NewClientFromOptions() Error: %q\n", err)
 	}
+	if result, err := client.validCreate(); err != nil {
+		t.Fatalf(err.Error())
+	} else {
+		t.Log(result)
+	}
+	dest, _ := client.CreateStreamSession(client.NewID(), "")
 	if err := client.Close(); err != nil {
 		t.Fatalf("client.Close() Error: %q\n", err)
 	}
+	fmt.Printf("\t destination- %s \n", dest)
+	fmt.Printf("\t address64- %s \t", client.Base64())
+	fmt.Printf("\t address- %s \t", client.Base32())
 }

 func TestOptionAddrMixedSlice(t *testing.T) {
 	client, err := NewClientFromOptions(SetAddrMixed("127.0.0.1", 7656), SetDebug(true))
 	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
+		t.Fatalf("NewClientFromOptions() Error: %q\n", err)
 	}
+	if result, err := client.validCreate(); err != nil {
+		t.Fatalf(err.Error())
+	} else {
+		t.Log(result)
+	}
+	dest, _ := client.CreateStreamSession(client.NewID(), "")
 	if err := client.Close(); err != nil {
 		t.Fatalf("client.Close() Error: %q\n", err)
 	}
+	fmt.Printf("\t destination- %s \n", dest)
+	fmt.Printf("\t address64- %s \t", client.Base64())
+	fmt.Printf("\t address- %s \t", client.Base32())
 }

 func TestOptionHost(t *testing.T) {
-	client, err := NewClientFromOptions(SetHost("127.0.0.1"), SetDebug(true))
+	client, err := NewClientFromOptions(
+		SetHost("127.0.0.1"),
+		SetPort("7656"),
+		SetInLength(3),
+		SetOutLength(3),
+		SetInVariance(1),
+		SetOutVariance(1),
+		SetInQuantity(6),
+		SetOutQuantity(6),
+		SetInBackups(2),
+		SetOutBackups(2),
+		SetEncrypt(true),
+		SetDebug(true),
+		SetUnpublished(true),
+		SetReduceIdle(true),
+		SetReduceIdleTime(300001),
+		SetReduceIdleQuantity(4),
+		SetCloseIdle(true),
+		SetCloseIdleTime(300001),
+	)
 	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionPort(t *testing.T) {
-	client, err := NewClientFromOptions(SetPort("7656"), SetDebug(true))
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
+		t.Fatalf("NewClientFromOptions() Error: %q\n", err)
 	}
+	if result, err := client.validCreate(); err != nil {
+		t.Fatalf(err.Error())
+	} else {
+		t.Log(result)
+	}
+	dest, _ := client.CreateStreamSession(client.NewID(), "")
 	if err := client.Close(); err != nil {
 		t.Fatalf("client.Close() Error: %q\n", err)
 	}
+	fmt.Printf("\t destination- %s \n", dest)
+	fmt.Printf("\t address64- %s \t", client.Base64())
+	fmt.Printf("\t address- %s \t", client.Base32())
 }

 func TestOptionPortInt(t *testing.T) {
-	client, err := NewClientFromOptions(SetPortInt(7656), SetDebug(true))
+	client, err := NewClientFromOptions(
+		SetHost("127.0.0.1"),
+		SetPortInt(7656),
+		SetInLength(3),
+		SetOutLength(3),
+		SetInVariance(1),
+		SetOutVariance(1),
+		SetInQuantity(6),
+		SetOutQuantity(6),
+		SetInBackups(2),
+		SetOutBackups(2),
+		SetEncrypt(true),
+		SetDebug(true),
+		SetUnpublished(true),
+		SetReduceIdle(true),
+		SetReduceIdleTime(300001),
+		SetReduceIdleQuantity(4),
+		SetCloseIdle(true),
+		SetCloseIdleTime(300001),
+	)
 	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionDebug(t *testing.T) {
-	client, err := NewClientFromOptions(SetDebug(true))
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionInLength(t *testing.T) {
-	client, err := NewClientFromOptions(SetInLength(3), SetDebug(true))
-	client.inlength()
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionOutLength(t *testing.T) {
-	client, err := NewClientFromOptions(SetInLength(3), SetDebug(true))
-	client.outlength()
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionInVariance(t *testing.T) {
-	client, err := NewClientFromOptions(SetInVariance(1), SetDebug(true))
-	client.invariance()
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionOutVariance(t *testing.T) {
-	client, err := NewClientFromOptions(SetOutVariance(1), SetDebug(true))
-	client.outvariance()
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionInQuantity(t *testing.T) {
-	client, err := NewClientFromOptions(SetInQuantity(6), SetDebug(true))
-	client.inquantity()
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionOutQuantity(t *testing.T) {
-	client, err := NewClientFromOptions(SetOutQuantity(6), SetDebug(true))
-	client.outquantity()
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionInBackups(t *testing.T) {
-	client, err := NewClientFromOptions(SetInBackups(5), SetDebug(true))
-	client.inbackups()
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionOutBackups(t *testing.T) {
-	client, err := NewClientFromOptions(SetOutBackups(5), SetDebug(true))
-	client.outbackups()
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionEncryptLease(t *testing.T) {
-	client, err := NewClientFromOptions(SetEncrypt(true), SetDebug(true))
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionUnpublishedLease(t *testing.T) {
-	client, err := NewClientFromOptions(SetUnpublished(true), SetDebug(true))
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionReduceIdle(t *testing.T) {
-	client, err := NewClientFromOptions(SetReduceIdle(true), SetDebug(true))
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionReduceIdleTime(t *testing.T) {
-	client, err := NewClientFromOptions(SetReduceIdleTime(300001), SetDebug(true))
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionReduceIdleCount(t *testing.T) {
-	client, err := NewClientFromOptions(SetReduceIdleQuantity(4), SetDebug(true))
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionCloseIdle(t *testing.T) {
-	client, err := NewClientFromOptions(SetCloseIdle(true), SetDebug(true))
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatalf("client.Close() Error: %q\n", err)
-	}
-}
-
-func TestOptionCloseIdleTime(t *testing.T) {
-	client, err := NewClientFromOptions(SetCloseIdleTime(300001), SetDebug(true))
-	if err != nil {
-		t.Fatalf("NewDefaultClient() Error: %q\n", err)
+		t.Fatalf("NewClientFromOptions() Error: %q\n", err)
 	}
+	if result, err := client.validCreate(); err != nil {
+		t.Fatalf(err.Error())
+	} else {
+		t.Log(result)
+	}
+	dest, _ := client.CreateStreamSession(client.NewID(), "")
 	if err := client.Close(); err != nil {
 		t.Fatalf("client.Close() Error: %q\n", err)
 	}
+	fmt.Printf("\t destination- %s \n", dest)
+	fmt.Printf("\t address64- %s \t", client.Base64())
+	fmt.Printf("\t address- %s \t", client.Base32())
 }
--- a/replyParser.go
+++ b/replyParser.go
@@ -57,7 +57,7 @@ func parseReply(line string) (*Reply, error) {
 			}
 		}

-		r.Pairs[kvPair[0]] = kvPair[1]
+		r.Pairs[kvPair[0]] = kvPair[len(kvPair)-1]
 	}

 	return r, nil
--- a/rw.go
+++ b/rw.go
@@ -0,0 +1,101 @@
+/*
+The MIT License (MIT)
+
+Copyright (c) 2014 Henry
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+*/
+
+package goSam
+
+import (
+	"encoding/hex"
+	"io"
+	"log"
+)
+
+/*
+Copy of testing/iotest Read- and WriteLogger, but using %q instead of %x for printing
+*/
+
+type writeLogger struct {
+	prefix string
+	w      io.Writer
+}
+
+func (l *writeLogger) Write(p []byte) (n int, err error) {
+	n, err = l.w.Write(p)
+	if err != nil {
+		log.Printf("%s %q: %v", l.prefix, string(p[0:n]), err)
+	} else {
+		log.Printf("%s %q", l.prefix, string(p[0:n]))
+	}
+	return
+}
+
+// NewWriteLogger returns a writer that behaves like w except
+// that it logs (using log.Printf) each write to standard error,
+// printing the prefix and the hexadecimal data written.
+func NewWriteLogger(prefix string, w io.Writer) io.Writer {
+	return &writeLogger{prefix, w}
+}
+
+type readLogger struct {
+	prefix string
+	r      io.Reader
+}
+
+func (l *readLogger) Read(p []byte) (n int, err error) {
+	n, err = l.r.Read(p)
+	if err != nil {
+		log.Printf("%s %q: %v", l.prefix, string(p[0:n]), err)
+	} else {
+		log.Printf("%s %q", l.prefix, string(p[0:n]))
+	}
+	return
+}
+
+// NewReadLogger returns a reader that behaves like r except
+// that it logs (using log.Print) each read to standard error,
+// printing the prefix and the hexadecimal data written.
+func NewReadLogger(prefix string, r io.Reader) io.Reader {
+	return &readLogger{prefix, r}
+}
+
+type readHexLogger struct {
+	prefix string
+	r      io.Reader
+}
+
+func (l *readHexLogger) Read(p []byte) (n int, err error) {
+	n, err = l.r.Read(p)
+	if err != nil {
+		log.Printf("%s (%d bytes) Error: %v", l.prefix, n, err)
+	} else {
+		log.Printf("%s (%d bytes)", l.prefix, n)
+	}
+	log.Print("\n" + hex.Dump(p[:n]))
+	return
+}
+
+// NewReadHexLogger returns a reader that behaves like r except
+// that it logs to stderr using ecoding/hex.
+func NewReadHexLogger(prefix string, r io.Reader) io.Reader {
+	return &readHexLogger{prefix, r}
+}
--- a/rwc.go
+++ b/rwc.go
@@ -0,0 +1,80 @@
+/*
+The MIT License (MIT)
+
+Copyright (c) 2014 Henry
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+*/
+
+package goSam
+
+import (
+	"io"
+	//"github.com/miolini/datacounter"
+)
+
+type RWC struct {
+	io.Reader
+	io.Writer
+	c io.Closer
+}
+
+func WrapRWC(c io.ReadWriteCloser) io.ReadWriteCloser {
+	rl := NewReadLogger("<", c)
+	wl := NewWriteLogger(">", c)
+
+	return &RWC{
+		Reader: rl,
+		Writer: wl,
+		c:      c,
+	}
+}
+
+func (c *RWC) Close() error {
+	return c.c.Close()
+}
+
+/*
+type Counter struct {
+	io.Reader
+	io.Writer
+	c io.Closer
+
+	Cr *datacounter.ReaderCounter
+	Cw *datacounter.WriterCounter
+}
+
+func WrapCounter(c io.ReadWriteCloser) *Counter {
+	rc := datacounter.NewReaderCounter(c)
+	wc := datacounter.NewWriterCounter(c)
+
+	return &Counter{
+		Reader: rc,
+		Writer: wc,
+		c:      c,
+
+		Cr: rc,
+		Cw: wc,
+	}
+}
+
+func (c *Counter) Close() error {
+	return c.c.Close()
+}
+*/
--- a/sessions.go
+++ b/sessions.go
@@ -2,7 +2,7 @@ package goSam

 import (
 	"fmt"
-	"math"
+	//	"math"
 	"math/rand"
 	"time"
 )
@@ -13,26 +13,33 @@ func init() {

 // CreateStreamSession creates a new STREAM Session.
 // Returns the Id for the new Client.
-func (c *Client) CreateStreamSession(dest string) (int32, string, error) {
+func (c *Client) CreateStreamSession(id int32, dest string) (string, error) {
 	if dest == "" {
 		dest = "TRANSIENT"
 	}
-
-	id := rand.Int31n(math.MaxInt32)
-	r, err := c.sendCmd("SESSION CREATE STYLE=STREAM ID=%d DESTINATION=%s %s\n", id, dest, c.allOptions())
+	c.id = id
+	r, err := c.sendCmd(
+		"SESSION CREATE STYLE=STREAM ID=%d %s %s DESTINATION=%s %s %s\n",
+		c.id,
+		c.from(),
+		c.to(),
+		dest,
+		c.sigtype(),
+		c.allOptions(),
+	)
 	if err != nil {
-		return -1, "", err
+		return "", err
 	}

 	// TODO: move check into sendCmd()
 	if r.Topic != "SESSION" || r.Type != "STATUS" {
-		return -1, "", fmt.Errorf("Unknown Reply: %+v\n", r)
+		return "", fmt.Errorf("Unknown Reply: %+v\n", r)
 	}

 	result := r.Pairs["RESULT"]
 	if result != "OK" {
-		return -1, "", ReplyError{ResultKeyNotFound, r}
+		return "", ReplyError{ResultKeyNotFound, r}
 	}
-
-	return id, r.Pairs["DESTINATION"], nil
+	c.destination = r.Pairs["DESTINATION"]
+	return c.destination, nil
 }
--- a/stream.go
+++ b/stream.go
@@ -6,7 +6,7 @@ import (

 // StreamConnect asks SAM for a TCP-Like connection to dest, has to be called on a new Client
 func (c *Client) StreamConnect(id int32, dest string) error {
-	r, err := c.sendCmd("STREAM CONNECT ID=%d DESTINATION=%s\n", id, dest)
+	r, err := c.sendCmd("STREAM CONNECT ID=%d %s %s DESTINATION=%s\n", id, c.from(), c.to(), dest)
 	if err != nil {
 		return err
 	}
Author	SHA1	Message	Date
idk	7d820eeaaa	dual-keys by default, tidy up	2020-09-03 16:21:53 -04:00
idk	ac54a46ded	Use dual keys by default	2020-09-03 16:19:12 -04:00
idk	22a3e9f3a7	Merge pull request #3 from bonedaddy/fix/mutex Fix Pass Lock By Value Vet Warning	2020-09-02 12:04:38 +00:00
idk	b7ce5c1061	Merge pull request #2 from bonedaddy/feat/dest#create Enable Basic Destination Creation	2020-09-02 12:03:43 +00:00
postables	7729762ce9	fix pass lock by value warning	2020-08-30 18:34:41 -07:00
postables	13bf63f35a	test: make sure to check the returned error from destination creation	2020-08-30 17:59:30 -07:00
postables	91fc13b151	enable creating I2P destinations	2020-08-30 17:56:05 -07:00
idk	7cf9e8b61e	mutex thing should be better	2020-08-25 16:53:59 -04:00
idk	c7d6848930	Protext non-context-aware dialer with a mutex	2020-08-25 10:31:44 -04:00
idk	eabd2d94f6	Protext non-context-aware dialer with a mutex	2020-08-25 10:27:40 -04:00
idk	76924e5961	add make link target	2020-07-29 13:00:36 -04:00
idk	027983674b	add Makefile to help me automate releases	2020-07-29 12:57:16 -04:00
idk	7521a7862a	Fix multi-lookup utility	2020-07-29 12:54:09 -04:00
idk	c11b90dc47	update release	2020-01-16 15:16:34 -05:00
idk	00969e92f7	update release	2020-01-16 15:16:08 -05:00
idk	129579130d	add missing conn.go file	2019-12-28 10:53:09 -05:00
idk	b43178746e	add missing conn.go file	2019-12-28 10:50:59 -05:00
idk	72dc2b1d74	get rid of outdated examples	2019-12-08 17:02:24 -05:00
idk	0b74205adf	start updating it	2019-12-08 16:57:51 -05:00
idk	d4c9b8c57d	fix modules	2019-08-14 16:42:30 -04:00
idk	27e7865789	fix debug import path and update module	2019-08-14 15:56:58 -04:00
idk	5fd5f21be6	try and fix go mod	2019-07-12 16:46:54 -04:00
idk	d8c0f81c78	chance accept/listen stuff	2019-07-05 03:10:01 -04:00
idk	291b43dd4b	it can't have a destination until one is filled	2019-07-03 22:09:29 -04:00
idk	98ddd74e32	update go modules	2019-06-25 22:20:02 -04:00
idk	9d4fce4593	add compat so I can turn gosam keys into sam3 keys	2019-06-09 22:06:44 -04:00
idk	87a4e609bb	update deb instructions	2019-05-18 18:13:16 -04:00
idk	4830ef434a	never pass empty ports	2019-05-18 11:20:56 -04:00
idk	00cba613a1	fix base32 calculation	2019-05-16 18:56:59 -04:00
idk	6e0cf375b3	fix base32 calculation	2019-05-16 18:56:33 -04:00
idk	802a59bd65	fix timeout minimums	2019-05-11 22:35:42 -04:00
idk	c9b61b818e	add ability to query tnnel id	2019-04-25 23:45:24 -04:00
idk	f794cd513f	make it easy to get the addresses of the gosam tunnels	2019-04-20 23:30:15 -04:00
idk	6f94d156ec	make it easy to get the addresses of the gosam tunnels	2019-04-20 23:29:29 -04:00
idk	6ebe813d0e	make it easy to get the addresses of the gosam tunnels	2019-04-20 23:27:47 -04:00
idk	4694834222	FROM_PORT and TO_PORT support	2019-03-28 00:21:04 -04:00
idk	4a105ff77e	update changelog	2019-03-16 17:19:44 -04:00
idk	e5c90d06eb	tidy up some things, add a destination parameter	2019-03-14 22:56:32 -04:00
idk	4b77bc4d02	fix excessive destination creation	2019-03-14 22:46:17 -04:00
idk	e42d89a43c	try and enable persistent destination	2019-03-14 21:59:12 -04:00
idk	376c392d58	only run offline test by default	2019-02-28 20:36:47 -05:00
idk	88c615b411	only run offline tests by default	2019-02-28 20:32:28 -05:00
idk	4a8fc1acfe	fix module	2019-02-28 15:28:07 -05:00
idk	6509b803bc	incorporate cryptix-debug without the counter	2019-02-28 14:22:55 -05:00
idk	49533844d6	incorporate cryptix-debug without the counter	2019-02-28 14:22:28 -05:00
idk	09c260e7e1	switch it to being a native package so people can build it from source more easily	2019-02-28 14:05:46 -05:00
idk	503c94e7e1	update packaging information	2019-02-28 13:58:01 -05:00
idk	cc91ed6bf0	remove 'commented-out' id	2019-02-27 22:04:04 -05:00
idk	5ffafcd28d	explicitly et invalid initial lastaddr	2019-02-27 22:00:35 -05:00
idk	c40b3af503	correct CONTRIBUTING.md	2019-02-27 20:49:33 -05:00
idk	abd13ace73	correct CONTRIBUTING.md	2019-02-27 20:46:46 -05:00
idk	4778044200	correct CONTRIBUTING.md	2019-02-27 20:46:18 -05:00
idk	bf2bef0f4b	make dialer context aware and avoid redundant session create's	2019-02-27 20:36:16 -05:00
idk	d7af8dafa9	make dialer context aware and avoid redundant session create's	2019-02-27 20:25:36 -05:00
idk	2e7a301855	Don't check version if handshake succeeds, just accept that OK is OK	2019-02-26 23:11:50 -05:00
idk	56cc5bd017	Don't check version if handshake succeeds, just accept that OK is OK	2019-02-26 23:10:10 -05:00
idk	a537690baa	add signature type support	2019-02-24 23:08:01 -05:00
idk	6ea277fc47	Update changelog for 0.1.0+git20190221.2896c83-1 release	2019-02-23 11:43:05 -05:00
idk	d3c0ff150f	updated the changelog	2019-02-23 11:34:58 -05:00
idk	34baf7bec3	added packaging files	2019-02-23 11:28:17 -05:00
idk	ba1f9719c2	added packaging files	2019-02-23 11:26:19 -05:00
idk	8de30dc68f	New upstream version 0.1.0+git20190221.2896c83	2019-02-23 11:22:48 -05:00
idk	430fd0b0bb	added WIP itp to gitignore	2019-02-23 11:04:16 -05:00
idk	7b4edecf96	Intial packaging	2019-02-23 11:01:57 -05:00
idk	2896c839bd	use my go module	2019-02-21 17:40:11 -05:00
idk	c69106a879	add gzip	2019-02-21 17:38:11 -05:00
idk	ca8fd03818	fixed some stuff in contributing	2018-10-02 23:58:21 -04:00
idk	186b20306e	fixed some stuff in contributing	2018-10-02 23:16:42 -04:00
idk	b06ef4ccf8	link examples in contrib guide	2018-09-11 17:04:53 -04:00
idk	f569145156	contributors guide, comment clarity	2018-09-11 17:04:52 -04:00
idk	193ce37241	contributors guide, comment clarity	2018-09-11 16:49:17 -04:00
idk	6cd8e18295	don't use real site in test	2018-08-22 18:02:13 -04:00
idk	69655d5d86	added real SESSION CREATEs to tests	2018-08-22 17:57:50 -04:00
idk	299080f4c2	make validCreate function so the tests look a little nicer.	2018-08-22 10:55:36 -04:00
idk	a57ebd8e7e	return erroneous string in validCmd	2018-08-22 08:57:54 -04:00
idk	aab53e9153	added a validate input function for the tests	2018-08-22 08:57:54 -04:00
idk	90dcde3cac	pass all the options as one string instead of a slice of string.	2018-08-22 08:57:54 -04:00