ConvertToHash test I2PAppContext part

Building upon @zlatinb's MR !14 (closed) , it makes it possible to replace the global context with a TestContext. By using @InjectMocks it's possible to replace the fields of a TestContext object with mocks.

This is done in a separate MR in order not to pollute !13 (merged) with I2PAppContext specific code.

added 1 commit

• 44c3d8cc - ConvertToHashMockTest: Clean up after using TestContext

Compare with previous version

changed the description

Allowing TestContext to clear itself is indeed smarter than having to retrofit all the existing unit tests :)

Please remove the change to the base I2PAppContext as it's tons of whitespace changes. Other than that looks good, approving!

approved this merge request

yeah, good way to do it, ACK after removing the I2PAppContext changes. If I knew how to modify the MR myself, I would, but I don't.

added 1 commit

• 0c4611c0 - Revert ee06171a

Compare with previous version

I reverted the changes in I2PAppContext. Totally forgot they were there.

It should be ready for merging now.

Thanks for reviewing

changed title from ConvertToHash test I2PAppContext part to Ready: ConvertToHash test I2PAppContext part

changed title from Ready: ConvertToHash test I2PAppContext part to ConvertToHash test I2PAppContext part

assigned to @zzz

merged

mentioned in commit 4776080c

I merged this but it fails to build.

Mockito is currently used only in streaming and ministreaming tests; the mockito classpath isn't set up in core build.xml. I'll work on fixing it, but something went wrong here if nobody tried to actually build and run the new tests.

Fixed and pushed. Either you forgot to add core/java/build.xml changes to your MR, or you were not testing with ant.

Thanks for fixing. I was only using gradle. I'll create an MR to add ant to the CI.

mentioned in merge request !14 (closed)

mentioned in merge request !18 (closed)