CTCP ACTION from mozbot/firebot is filtered by I2PTunnel

ctcp action from mozbot/firebot is filtered by I2PTunnel.

From mozbot's stdout:

2024-05-19 19:53:20 UTC (516) Module Infobot: Telling kytv about <3.
2024-05-19 19:53:21 UTC (516) ->#kytv * feels the love! :)

In the I2PTunnel logs:

May 19, 2024, 7:53:21 PM WARN [ Runner 1304] p.i2ptunnel.I2PTunnelIRCClient: outbound BLOCKED: "PRIVMSG #kytv :ACTION feels the love! :)"

This is using the enci2pedia's codebase & factoids as they were 8 years ago and used to work, reproduced with both mozbot and the more recently updated firebot.

The special chars in the log might have been lost with copy & paste.

I see code in IRCFilter.java to allow I2CP ACTION in both directions, so that was the intent, perhaps it broke somewhere along the way, maybe by me...

If you're going to work on it please assign yourself, otherwise assign it to me, but I may not get to it for a while.

reproduced here

I brought an ircd back up at my old hostname (irc.killyourtv.i2p) to play with, so I can take a look at this while I look at other ircv3 things. I'll be mostly away until mid-June, so if I can do anything with this it'll be some time before that can happen.

I know there are important things brewing for 2.6 which would make this one of the lower priority items.

(I don't see an option to change the assignee. Maybe I don't have an appropriate role to be able to do so?)

I reproduced it w/o an ircd, simply on the client side "/me test test test"

plenty of time for 2.6.0, just gotta get the big stuff in first.

I'll assign it to myself but if you get to it first let me know.

assigned to @zzz

added i2ptunnel label

changed milestone to %2.6.0

hot on the trail, as I almost certainly broke it with my IRCv3 fixes two years ago

try this please. I only tested the outbound side.

diff --git a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/irc/IRCFilter.java b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/irc/IRCFilter.java
index 6864e3392..26c6cce14 100644
--- a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/irc/IRCFilter.java
+++ b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/irc/IRCFilter.java
@@ -114,6 +114,8 @@ abstract class IRCFilter {
         {
             String msg;
             msg = field[idx++];
+            if (idx < field.length)
+                msg += ' ' + field[idx];
 
             if(msg.indexOf(0x01) >= 0) // CTCP marker ^A can be anywhere, not just immediately after the ':'
             {
@@ -360,6 +362,8 @@ abstract class IRCFilter {
             if (field.length < idx + 2)
                 return s;  // invalid, allow server response
             String msg = field[idx + 1];
+            if (idx + 2 < field.length)
+                msg += ' ' + field[idx + 2];
         
             if(msg.indexOf(0x01) >= 0) // CTCP marker ^A can be anywhere, not just immediately after the ':'
             {

Looks good.

19:09 --> enci2pedia-ng (//www.mozilla.org/projects/mozbot/) (~u@26nqbrcgye62prvu7jsfatsaaavq7vxcwazozumnzyyggbyxmkta.b32.i2p) has joined #kytv
19:10 <@kytv> enci2pedia-ng: <3
19:10 <enci2pedia-ng> <3 is IRC shorthand for love.
19:10 <@kytv> enci2pedia-ng: <3
19:10  * enci2pedia-ng feels the love! :)

mentioned in commit 9e18bded

Thanks for the report and testing.

In 9e18bded to be 2.5.2-4

closed