Unnecessary boxing in Blocklist
Unnecessary boxing of primitive ints in Blocklist.java - grep of changes since 2.3.0:
+ public Integer causeCode;
+ public final static Integer BANLIST_CODE_SOFT = 0;
+ public final static Integer BANLIST_CODE_HARD = 1;
+ Integer reasonCode;
+ Integer reasonCode = BANLIST_CODE_SOFT; // Default
+ * @param reasonCode Integer handling code.
+ public boolean banlistRouter(Hash peer, String reason, String reasonComment, Integer reasonCode, String transport, long expireOn) {
This is inefficient and a poor coding practice. Use ints.