RAP/RAR flags interaction with subdbs
More questinos than answers, consider this a placeholder issue for now... Ripping out RAP/RAR would be another huge batch of changes, probably not the right time... anyway:
The goal of subdbs is to do a "better" job of isolation than the RAP/RAR flags do, right?
But the recent changes don't remove or deprecate the RAP/RAR flags, and actually add a couple setReceivedAsReply() calls in InboundMessageDistributor. Is this a temporary belt-and-suspenders plan, with RAP/RAR slated to be removed in some future release? If subdbs are "better", then could the RAP/RAR flags actually be interfering with the "correct" operation of the subdbs, and impairing whatever improvements subdbs are supposed to bring? Has this been tested? What's the plan?
Also, I have questions about the 2.3.0 change to KNDF.validate(ls), where the date comparison was changed to a deep equals, with a lot of TODO comments. I don't quite understand the point of that change but it's not clear that the author of the change does either. The code now only messes with the flags if the leasesets are (almost) completely identical, but if so, why mess with the flags at all? I think the change breaks some stuff, but not sure.
Anyway, now for 2.4.0, subnetdbs should impact what that 2.3.0 code is trying to do? Or not? But there's no further changes there...