ACKSender: properly set send time
Opened 18 months ago
Last modified 18 months ago
#2653newenhancement
ACKSender: properly set send time
Reported by:joggerOwned by:zzz Priority: minor Milestone: undecided Component: router/transport Version: 0.9.43 Keywords:
Cc:
Parent Tickets:
Sensitive: no
Description
in retrieveACKBitfields() there is
if (_currentACKs.isEmpty())
_wantACKSendSince = -1;
However if we could not ACK everything, _wantACKSendSince is untouched. If we are currently piggybackACKing there is a good chance outstanding ACKs will be picked up by the next packet. In this case ACKSender could hit in between and cause an extra packet to be sent. This can be prevented by setting _wantACKSendSince to now() in this case.