jrandom authored 20 years ago and zzz committed 20 years ago

new async interface for error notification (e.g. you can get notified of an error prior to it throwing the IOException).
This async is useful since the IOException can be delayed for up to a minute while waiting for the close packet to be delivered.
The alternative is to fire off a new thread to do the closing, and we may want to go there later, but i'm not sure.

shendaras authored 20 years ago and zzz committed 20 years ago

(shendaras)

jrandom authored 20 years ago and zzz committed 20 years ago

(only relevent for people whose socket manager / i2ptunnel / etc are located remote from the router)

jrandom authored 20 years ago and zzz committed 20 years ago

remove semantic inconsistency wrt getRemoteId(false) - it shouldn't ever timeout, since it always returns immediately
javadoc (though i wish i understood the close/close2/sendClose more clearly so i could javadoc that process)

jrandom authored 20 years ago and zzz committed 20 years ago

make sure we kill the threads that failed to ACK, rather than leave them sitting there, waiting forever
logging

jrandom authored 20 years ago and zzz committed 20 years ago

add unique IDs to the various threads for logging / tracing purposes

jrandom authored 20 years ago and zzz committed 20 years ago

removed nested synchronization (which had been causing undetected deadlocks)
made sync blocks smaller, though this may have opened holes related to
resent ACK/SYN/CLOSE packets that are delivered in a race.  I'm not as
fluent in the ministreaming lib code as i should be (yet), but duck's thread
dumps were showing hundreds of threads waiting on a lock that'll never get
released (since the only way to release it would be to receive another
packet, and no more packets can be received until the lock is released, etc)
also, I2PSession is threadsafe - i can see no reason to synchronize on it
(and it was being synchronized on only part of the time?)
also, refactored the charset encoding stuff and minor log tweaking
i've been testing this for the last hour or so, on eepsites and squid (large
and small files), as well as irc, and there haven't been any glitches.  but
it needs more testing before it can be released, obviously.

human authored 20 years ago and zzz committed 20 years ago

InterruptedException (oops!)
(human)

human authored 20 years ago and zzz committed 20 years ago

  better error reporting;
* Added an I2PSocketManager.destroySocketManager() method, that closes all
  the managed sockets and destroys the associated I2PSession.
(human)

human authored 20 years ago and zzz committed 20 years ago

won't be accepted until the server app actually requires an I2PServerSocket
from the I2PSocketManager.
It allows both to add a little bit of functionality, and to fix a nasty bug: it
was possible to hang an app that connects through the I2PSocketManager but
actually doesn't accept() connections (if 2 connection requests were sent
to the app, the I2PSocketManager got stuck waiting forever on
I2PServerSocketImpl.getNewSocket()).