initializer cleanups, reduce rates, javadoc

router/java/src/net/i2p/router/client/ClientListenerRunner.java

@@ -41,8 +41,6 @@ public class ClientListenerRunner implements Runnable {
         _log = _context.logManager().getLog(ClientListenerRunner.class);
         _manager = manager;
         _port = port;
-        _running = false;
-        _listening = false;
         
         String val = context.getProperty(BIND_ALL_INTERFACES);
         _bindAllInterfaces = Boolean.valueOf(val).booleanValue();

router/java/src/net/i2p/router/client/ClientManagerFacadeImpl.java

@@ -43,7 +43,6 @@ public class ClientManagerFacadeImpl extends ClientManagerFacade {
     
     public ClientManagerFacadeImpl(RouterContext context) {
         _context = context;
-        _manager = null;
         _log.debug("Client manager facade created");
     }
     

router/java/src/net/i2p/router/client/LeaseRequestState.java

@@ -33,7 +33,6 @@ class LeaseRequestState {
         _onFailed = onFailed;
         _expiration = expiration;
         _requestedLeaseSet = requested;
-        _successful = false;
     }
     
     /** created lease set from client */

router/java/src/net/i2p/router/client/MessageReceivedJob.java

@@ -47,9 +47,6 @@ class MessageReceivedJob extends JobImpl {
     
     /**
      * Deliver notification to the client that the given message is available.
-     * This is synchronous and returns true if the notification was sent safely,
-     * otherwise it returns false
-     *
      */
     public void messageAvailable(MessageId id, long size) {
         if (_log.shouldLog(Log.DEBUG))
@@ -59,6 +56,7 @@ class MessageReceivedJob extends JobImpl {
         msg.setMessageId(id.getMessageId());
         msg.setSessionId(_runner.getSessionId().getSessionId());
         msg.setSize(size);
+        // has to be >= 0, it is initialized to -1
         msg.setNonce(1);
         msg.setStatus(MessageStatusMessage.STATUS_AVAILABLE);
         try {

router/java/src/net/i2p/router/client/RequestLeaseSetJob.java

@@ -44,9 +44,9 @@ class RequestLeaseSetJob extends JobImpl {
         _onCreate = onCreate;
         _onFail = onFail;
         _requestState = state;
-        ctx.statManager().createRateStat("client.requestLeaseSetSuccess", "How frequently the router requests successfully a new leaseSet?", "ClientMessages", new long[] { 10*60*1000, 60*60*1000, 24*60*60*1000 });
-        ctx.statManager().createRateStat("client.requestLeaseSetTimeout", "How frequently the router requests a new leaseSet but gets no reply?", "ClientMessages", new long[] { 10*60*1000, 60*60*1000, 24*60*60*1000 });
-        ctx.statManager().createRateStat("client.requestLeaseSetDropped", "How frequently the router requests a new leaseSet but the client drops?", "ClientMessages", new long[] { 10*60*1000, 60*60*1000, 24*60*60*1000 });
+        ctx.statManager().createRateStat("client.requestLeaseSetSuccess", "How frequently the router requests successfully a new leaseSet?", "ClientMessages", new long[] { 60*60*1000 });
+        ctx.statManager().createRateStat("client.requestLeaseSetTimeout", "How frequently the router requests a new leaseSet but gets no reply?", "ClientMessages", new long[] { 60*60*1000 });
+        ctx.statManager().createRateStat("client.requestLeaseSetDropped", "How frequently the router requests a new leaseSet but the client drops?", "ClientMessages", new long[] { 60*60*1000 });
     }
     
     public String getName() { return "Request Lease Set"; }