I2P Address: [http://git.idk.i2p]

Skip to content
Snippets Groups Projects
Commit 8a7c3390 authored by zzz's avatar zzz
Browse files

/configclients:

 - Re-enable plugin installation by default
 - Don't show configuration section or update-all button if no plugins installed
parent 2302aee8
No related branches found
No related tags found
No related merge requests found
...@@ -59,7 +59,7 @@ public class ConfigClientsHandler extends FormHandler { ...@@ -59,7 +59,7 @@ public class ConfigClientsHandler extends FormHandler {
} }
if (_action.equals(_("Install Plugin"))) { if (_action.equals(_("Install Plugin"))) {
if (pluginsEnabled && if (pluginsEnabled &&
(_context.getBooleanProperty(ConfigClientsHelper.PROP_ENABLE_PLUGIN_INSTALL) || (_context.getBooleanPropertyDefaultTrue(ConfigClientsHelper.PROP_ENABLE_PLUGIN_INSTALL) ||
isAdvanced())) isAdvanced()))
installPlugin(); installPlugin();
else else
......
...@@ -39,7 +39,12 @@ public class ConfigClientsHelper extends HelperBase { ...@@ -39,7 +39,12 @@ public class ConfigClientsHelper extends HelperBase {
/** @since 0.9.14.1 */ /** @since 0.9.14.1 */
public boolean isPluginInstallEnabled() { public boolean isPluginInstallEnabled() {
return PluginStarter.pluginsEnabled(_context) && return PluginStarter.pluginsEnabled(_context) &&
(_context.getBooleanProperty(PROP_ENABLE_PLUGIN_INSTALL) || isAdvanced()); (_context.getBooleanPropertyDefaultTrue(PROP_ENABLE_PLUGIN_INSTALL) || isAdvanced());
}
/** @since 0.9.15 */
public boolean isPluginUpdateEnabled() {
return !PluginStarter.getPlugins().isEmpty();
} }
/** @since 0.8.3 */ /** @since 0.8.3 */
......
...@@ -105,7 +105,10 @@ input.default { width: 1px; height: 1px; visibility: hidden; } ...@@ -105,7 +105,10 @@ input.default { width: 1px; height: 1px; visibility: hidden; }
<input type="submit" name="action" class="accept" value="<%=intl._("Save WebApp Configuration")%>" /> <input type="submit" name="action" class="accept" value="<%=intl._("Save WebApp Configuration")%>" />
</div></form></div> </div></form></div>
<% if (clientshelper.showPlugins()) { %> <%
if (clientshelper.showPlugins()) {
if (clientshelper.isPluginUpdateEnabled()) {
%>
<h3><a name="pconfig"></a><%=intl._("Plugin Configuration")%></h3><p> <h3><a name="pconfig"></a><%=intl._("Plugin Configuration")%></h3><p>
<%=intl._("The plugins listed below are started by the webConsole client.")%> <%=intl._("The plugins listed below are started by the webConsole client.")%>
</p><div class="wideload"> </p><div class="wideload">
...@@ -116,25 +119,47 @@ input.default { width: 1px; height: 1px; visibility: hidden; } ...@@ -116,25 +119,47 @@ input.default { width: 1px; height: 1px; visibility: hidden; }
<input type="submit" class="cancel" name="foo" value="<%=intl._("Cancel")%>" /> <input type="submit" class="cancel" name="foo" value="<%=intl._("Cancel")%>" />
<input type="submit" name="action" class="accept" value="<%=intl._("Save Plugin Configuration")%>" /> <input type="submit" name="action" class="accept" value="<%=intl._("Save Plugin Configuration")%>" />
</div></form></div> </div></form></div>
<%
<% if (clientshelper.isPluginInstallEnabled()) { %> } // pluginUpdateEnabled
if (clientshelper.isPluginInstallEnabled()) {
%>
<h3><a name="plugin"></a><%=intl._("Plugin Installation")%></h3><p> <h3><a name="plugin"></a><%=intl._("Plugin Installation")%></h3><p>
<%=intl._("Look for available plugins on {0}.", "<a href=\"http://plugins.i2p\">plugins.i2p</a>")%> <%=intl._("Look for available plugins on {0}.", "<a href=\"http://plugins.i2p\">plugins.i2p</a>")%>
<%=intl._("To install a plugin, enter the download URL:")%> <%=intl._("To install a plugin, enter the download URL:")%>
</p><div class="wideload"> </p>
<%
} // pluginInstallEnabled
if (clientshelper.isPluginInstallEnabled() || clientshelper.isPluginUpdateEnabled()) {
%>
<div class="wideload">
<form action="configclients" method="POST"> <form action="configclients" method="POST">
<input type="hidden" name="nonce" value="<%=pageNonce%>" > <input type="hidden" name="nonce" value="<%=pageNonce%>" >
<%
if (clientshelper.isPluginInstallEnabled()) {
%>
<p> <p>
<input type="text" size="60" name="pluginURL" > <input type="text" size="60" name="pluginURL" >
</p><hr><div class="formaction"> </p><hr><div class="formaction">
<input type="submit" name="action" class="default" value="<%=intl._("Install Plugin")%>" /> <input type="submit" name="action" class="default" value="<%=intl._("Install Plugin")%>" />
<input type="submit" class="cancel" name="foo" value="<%=intl._("Cancel")%>" /> <input type="submit" class="cancel" name="foo" value="<%=intl._("Cancel")%>" />
<input type="submit" name="action" class="download" value="<%=intl._("Install Plugin")%>" /> <input type="submit" name="action" class="download" value="<%=intl._("Install Plugin")%>" />
</div><hr><div class="formaction"> </div>
<%
} // pluginInstallEnabled
%>
</div>
<%
if (clientshelper.isPluginUpdateEnabled()) {
%>
<hr><div class="formaction">
<input type="submit" name="action" class="reload" value="<%=intl._("Update All Installed Plugins")%>" /> <input type="submit" name="action" class="reload" value="<%=intl._("Update All Installed Plugins")%>" />
</div></form></div> </div>
<%
} // pluginUpdateEnabled
%>
</form></div>
<% <%
} // pluginInstallEnabled } // pluginInstallEnabled || pluginUpdateEnabled
} // showPlugins } // showPlugins
%> %>
</div></div></body></html> </div></div></body></html>
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment