Console and Eepsite Jetty:
Switch back to QueuedThreadPool (ticket #1395) In Jetty 5/6, the default QTP was not concurrent, so we switched to ThreadPoolExecutor with a fixed-size queue, a set maxThreads, and a RejectedExecutionPolicy of CallerRuns. Unfortunately, CallerRuns causes lockups in Jetty NIO. In addition, no flavor of TPE gives us what QTP does: - TPE direct handoff (which we were using) never queues. This doesn't provide any burst management when maxThreads is reached. CallerRuns was an attempt to work around that. - TPE unbounded queue does not adjust the number of threads. This doesn't provide automatic resource management. - TPE bounded queue does not add threads until the queue is full. This doesn't provide good responsiveness to even small bursts. QTP adds threads as soon as the queue is non-empty. QTP as of Jetty 7 uses concurrent. QTP unbounded queue is the default in Jetty. So switch back to QTP with a bounded queue, which does what we want, which is first expand the thread pool, then start queueing, then reject. ref: http://docs.oracle.com/javase/6/docs/api/java/util/concurrent/ThreadPoolExecutor.html https://wiki.eclipse.org/Jetty/Howto/High_Load
Showing
- apps/routerconsole/java/src/net/i2p/router/web/RouterConsoleRunner.java 47 additions, 15 deletions...sole/java/src/net/i2p/router/web/RouterConsoleRunner.java
- history.txt 4 additions, 0 deletionshistory.txt
- installer/resources/eepsite/jetty.xml 34 additions, 9 deletionsinstaller/resources/eepsite/jetty.xml
- router/java/src/net/i2p/router/RouterVersion.java 2 additions, 2 deletionsrouter/java/src/net/i2p/router/RouterVersion.java
Please register or sign in to comment