clarify the nextInt/nextLong boundaries (thanks oOo)

apps/i2ptunnel/java/src/net/i2p/i2ptunnel/I2PTunnelHTTPClient.java

@@ -138,8 +138,6 @@ public class I2PTunnelHTTPClient extends I2PTunnelClientBase implements Runnable
                 return null;
             }
             int index = I2PAppContext.getGlobalContext().random().nextInt(size);
-            if (index >= size) index = size - 1;
-            if (index < 0) return null;
             String proxy = (String)proxyList.get(index);
             return proxy;
         }

core/java/src/net/i2p/util/RandomSource.java

@@ -33,7 +33,7 @@ public class RandomSource extends SecureRandom {
      * According to the java docs (http://java.sun.com/j2se/1.4.1/docs/api/java/util/Random.html#nextInt(int))
      * nextInt(n) should return a number between 0 and n (including 0 and excluding n).  However, their pseudocode,
      * as well as sun's, kaffe's, and classpath's implementation INCLUDES NEGATIVE VALUES.
-     * WTF.  Ok, so we're going to have it return between 0 and n, since 
+     * WTF.  Ok, so we're going to have it return between 0 and n (including 0, excluding n), since 
      * thats what it has been used for.
      *
      */
@@ -41,18 +41,18 @@ public class RandomSource extends SecureRandom {
         if (n == 0) return 0;
         int val = super.nextInt(n);
         if (val < 0) val = 0 - val;
-        if (val > n) val = val % n;
+        if (val >= n) val = val % n;
         return val;
     }
 
     /**
      * Like the modified nextInt, nextLong(n) returns a random number from 0 through n,
-     * inclusive.
+     * including 0, excluding n.
      */
     public long nextLong(long n) {
         long v = super.nextLong();
         if (v < 0) v = 0 - v;
-        if (v > n) v = v % n;
+        if (v >= n) v = v % n;
         return v;
     }
 

router/java/src/net/i2p/router/networkdb/kademlia/DataPublisherJob.java

@@ -67,7 +67,7 @@ class DataPublisherJob extends JobImpl {
         
         // if there's nothing we *need* to send, only send 10% of the time
         if (explicit.size() <= 0) {
-            if (getContext().random().nextInt(9) <= 8)
+            if (getContext().random().nextInt(10) > 0)
                 return toSend;
         }
         

router/java/src/net/i2p/router/tunnelmanager/TunnelPoolManagerJob.java

@@ -71,7 +71,7 @@ class TunnelPoolManagerJob extends JobImpl {
                 built = true;
             } else {
                 // 10% chance of building a new tunnel
-                if (getContext().random().nextInt(9) > 0) {
+                if (getContext().random().nextInt(10) > 0) {
                     // all good, no need for more inbound tunnels
                     if (_log.shouldLog(Log.DEBUG))
                         _log.debug("Sufficient inbound tunnels (" + curFreeInboundTunnels + ")");
@@ -93,7 +93,7 @@ class TunnelPoolManagerJob extends JobImpl {
                 built = true;
             } else {
                 // 10% chance of building a new tunnel
-                if (getContext().random().nextInt(9) > 0) {
+                if (getContext().random().nextInt(10) > 0) {
                     // all good, no need for more outbound tunnels
                     if (_log.shouldLog(Log.DEBUG))
                         _log.debug("Sufficient outbound tunnels (" + curOutboundTunnels + ")");