-
- Downloads
Use static int constants for State instead of Enums
Enums often require more than twice as much memory as static constants, and should be strictly avoided on Android. https://developer.android.com/training/articles/memory.html#Overhead The advantage of this change is that client library users can directly compare the status values they get from IRouterState to the constants, instead of parsing a string representation of an Enum.
Showing
- app/src/main/java/net/i2p/android/router/MainActivity.java 13 additions, 11 deletionsapp/src/main/java/net/i2p/android/router/MainActivity.java
- app/src/main/java/net/i2p/android/router/MainFragment.java 26 additions, 26 deletionsapp/src/main/java/net/i2p/android/router/MainFragment.java
- app/src/main/java/net/i2p/android/router/service/RouterService.java 14 additions, 32 deletions...in/java/net/i2p/android/router/service/RouterService.java
- client/src/main/aidl/net/i2p/android/router/service/IRouterState.aidl 1 addition, 1 deletion...ain/aidl/net/i2p/android/router/service/IRouterState.aidl
- client/src/main/aidl/net/i2p/android/router/service/IRouterStateCallback.aidl 1 addition, 1 deletion.../net/i2p/android/router/service/IRouterStateCallback.aidl
- client/src/main/java/net/i2p/android/router/service/State.java 30 additions, 0 deletions...t/src/main/java/net/i2p/android/router/service/State.java
Loading
Please register or sign in to comment