Broken Link for hall-of-fame
On the contact page there is a link to the hall-of-fame page at the end of the large table. For me (with javascript disabled and stuff like that) on the live page (within i2p) this links to http://i2p-projekt.i2p/en/site_url(about/hall-of-fame)
. As seems obvious to me the page is actually available at http://i2p-projekt.i2p/en/about/hall-of-fame
and all the other links do work fine for me. So ...
I'm not building/testing, yet, so the following is just theory-based. The code for this is in team.html at the very end and the function call to site_url() is "plain" within the href-String there. In all other places I have noticed, these are only used within the {% trans %} tags, which makes me assume they need that to actually get called ;)
Hence, to me looks like we need a new translation tag here, which accordingly will have side-effects towards translations that I am not aware of. So not quite sure what to do aside from pointing it out at this point. Something like
diff --git a/i2p2www/pages/site/about/team.html b/i2p2www/pages/site/about/team.html
index 7014cdf0..12712263 100644
--- a/i2p2www/pages/site/about/team.html
+++ b/i2p2www/pages/site/about/team.html
@@ -403,7 +403,7 @@ network.
<td valign="top" colspan="2">{% trans %}… and many others{% endtrans %}</td>
</tr>
<tr>
- <td><a href="site_url(about/hall-of-fame)">Hall of Fame!</a></td>
+ <td>{% trans famehall=site_url('about/hall-of-fame') -%}<a href="{{ famehall }}">Hall of Fame!</a>{%- endtrans %}</td>
</tr>
</table>
{% endblock %}
might even do the job? But are there translations available or do they become generated automatically etc.? One of you will have to have a look at this if it's a problem aside from me and ought to be fixed soon ... And if there is any documentation on these tags and possible workflows for adding/changing/removing them, please point me to it while we are at it ;)