Use of Reachability flag is misleading
Opened 6 years ago
Last modified 6 years ago
#1548newdefect
Use of Reachability flag is misleading
Reported by:DjJeshkOwned by:zzz Priority: maintenance Milestone: undecided Component: www/i2p Version: 0.9.19 Keywords:
Cc:
Parent Tickets:
Sensitive: no
Description
I2P version: 0.9.19-9
Java version: Oracle Corporation 1.8.0_45 (Java™ SE Runtime Environment 1.8.0_45-b14)
Wrapper version: 3.5.25
Server version: 8.1.16.v20140903
Servlet version: Jasper JSP 2.1 Engine
Platform: Windows 7 x86 6.1
Processor: Core 2 (45nm) (core2)
Jbigi: Locally optimized library jbigi-windows-core2.dll loaded from file
Encoding: Cp1257
Charset: windows-1257
We should deprecate reachability flag because it negatively impacts network performance if not all transports are open for router. It blocks partial firewalled routers to participate in tunnels. One transport only enabled routers are able to participate normally. Partially firewalled routers should not be blocked to participate in tunnels.
If we remove reachable flag only if all transports are firewalled then it still does not guarantees that two reachable routers are reachable to each other if we talk about NTCP only and UDP only reachable routers. So there is no need to trust reachability at all.
Routerinfos has enough information to determine if specific transport is disabled or enabled with introducers, or enabled without firewall. So ignore reachability flag and leave it for backward compatibility.
Issue caused by this: #1458