From eb73f0aae2a8c305032f6db1d1df4421e6845ba3 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Wed, 26 Feb 2020 17:04:06 +0000
Subject: [PATCH] Fixup rrd4j javadoc errors, tested with JDK 15 b11

---
 apps/jrobin/java/src/org/rrd4j/core/RobinArray.java         | 2 +-
 apps/jrobin/java/src/org/rrd4j/core/RobinMatrix.java        | 2 +-
 apps/jrobin/java/src/org/rrd4j/core/RrdBackendFactory.java  | 6 ------
 .../java/src/org/rrd4j/core/RrdNioBackendFactory.java       | 2 +-
 apps/jrobin/java/src/org/rrd4j/core/RrdSyncThreadPool.java  | 2 +-
 apps/jrobin/java/src/org/rrd4j/core/jrrd/RRDFile.java       | 2 +-
 apps/jrobin/java/src/org/rrd4j/core/jrrd/UnivalArray.java   | 2 +-
 apps/jrobin/java/src/org/rrd4j/data/Source.java             | 4 ++--
 8 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/apps/jrobin/java/src/org/rrd4j/core/RobinArray.java b/apps/jrobin/java/src/org/rrd4j/core/RobinArray.java
index 0ece198c55..79265e57d9 100644
--- a/apps/jrobin/java/src/org/rrd4j/core/RobinArray.java
+++ b/apps/jrobin/java/src/org/rrd4j/core/RobinArray.java
@@ -8,7 +8,7 @@ import java.io.IOException;
  * fixed length array of double values. Each double value represents consolidated, archived
  * value for the specific timestamp. When the underlying array of double values gets completely
  * filled, new values will replace the oldest ones.<p>
- * <p/>
+ *
  * Robin object does not hold values in memory - such object could be quite large.
  * Instead of it, Robin reads them from the backend I/O only when necessary.
  *
diff --git a/apps/jrobin/java/src/org/rrd4j/core/RobinMatrix.java b/apps/jrobin/java/src/org/rrd4j/core/RobinMatrix.java
index 8035716a5c..715eaa8d75 100644
--- a/apps/jrobin/java/src/org/rrd4j/core/RobinMatrix.java
+++ b/apps/jrobin/java/src/org/rrd4j/core/RobinMatrix.java
@@ -8,7 +8,7 @@ import java.io.IOException;
  * fixed length array of double values. Each double value reperesents consolidated, archived
  * value for the specific timestamp. When the underlying array of double values gets completely
  * filled, new values will replace the oldest ones.<p>
- * <p/>
+ *
  * Robin object does not hold values in memory - such object could be quite large.
  * Instead of it, Robin reads them from the backend I/O only when necessary.
  *
diff --git a/apps/jrobin/java/src/org/rrd4j/core/RrdBackendFactory.java b/apps/jrobin/java/src/org/rrd4j/core/RrdBackendFactory.java
index e5ac6acdf8..b6fb8136e6 100644
--- a/apps/jrobin/java/src/org/rrd4j/core/RrdBackendFactory.java
+++ b/apps/jrobin/java/src/org/rrd4j/core/RrdBackendFactory.java
@@ -51,12 +51,6 @@ import java.util.regex.Pattern;
  * {@link org.rrd4j.core.RrdMemoryBackendFactory} class. This backend stores all data in memory. Once
  * JVM exits, all data gets lost. The backend is extremely fast and memory hungry.
  * 
- * <li>{@link org.rrd4j.core.RrdBerkeleyDbBackend}: objects of this class are created from the 
- * {@link org.rrd4j.core.RrdBerkeleyDbBackendFactory} class. It stores RRD data to ordinary disk files 
- * using <a href="http://www.oracle.com/technetwork/database/berkeleydb/overview/index-093405.html">Oracle Berkeley DB</a> Java Edition.
- * 
- * <li>{@link org.rrd4j.core.RrdMongoDBBackend}: objects of this class are created from the {@link org.rrd4j.core.RrdMongoDBBackendFactory} class.
- * It stores data in a {@link com.mongodb.DBCollection} from <a href="http://www.mongodb.org/">MongoDB</a>.
  * </ul>
  * <p>
  * Each backend factory used to be identified by its {@link #getName() name}. Constructors
diff --git a/apps/jrobin/java/src/org/rrd4j/core/RrdNioBackendFactory.java b/apps/jrobin/java/src/org/rrd4j/core/RrdNioBackendFactory.java
index c3e448c39d..bb7d476def 100644
--- a/apps/jrobin/java/src/org/rrd4j/core/RrdNioBackendFactory.java
+++ b/apps/jrobin/java/src/org/rrd4j/core/RrdNioBackendFactory.java
@@ -6,7 +6,7 @@ import java.util.concurrent.ScheduledExecutorService;
 /**
  * Factory class which creates actual {@link org.rrd4j.core.RrdNioBackend} objects. This is the default factory since
  * 1.4.0 version.
- * <h3>Managing the thread pool</h3>
+ * <h2>Managing the thread pool</h2>
  * <p>Each RrdNioBackendFactory is optionally backed by a {@link org.rrd4j.core.RrdSyncThreadPool}, which it uses to sync the memory-mapped files to
  * disk. In order to avoid having these threads live longer than they should, it is recommended that clients create and
  * destroy thread pools at the appropriate time in their application's life time. Failure to manage thread pools
diff --git a/apps/jrobin/java/src/org/rrd4j/core/RrdSyncThreadPool.java b/apps/jrobin/java/src/org/rrd4j/core/RrdSyncThreadPool.java
index de46ef6c1e..facd5e167b 100644
--- a/apps/jrobin/java/src/org/rrd4j/core/RrdSyncThreadPool.java
+++ b/apps/jrobin/java/src/org/rrd4j/core/RrdSyncThreadPool.java
@@ -128,7 +128,7 @@ public class RrdSyncThreadPool
      * If there is a SecurityManager, it uses the group of System.getSecurityManager(), else the group
      * of the thread instantiating this DaemonThreadFactory. Each new thread is created as a daemon thread
      * with priority Thread.NORM_PRIORITY. New threads have names accessible via Thread.getName()
-     * of "<pool-name> Pool [Thread-M]", where M is the sequence number of the thread created by this factory.
+     * of "&lt;pool-name&gt; Pool [Thread-M]", where M is the sequence number of the thread created by this factory.
      */
     static class DaemonThreadFactory implements ThreadFactory
     {
diff --git a/apps/jrobin/java/src/org/rrd4j/core/jrrd/RRDFile.java b/apps/jrobin/java/src/org/rrd4j/core/jrrd/RRDFile.java
index aac650941b..ccc313812d 100644
--- a/apps/jrobin/java/src/org/rrd4j/core/jrrd/RRDFile.java
+++ b/apps/jrobin/java/src/org/rrd4j/core/jrrd/RRDFile.java
@@ -13,7 +13,7 @@ import org.rrd4j.core.InvalidRrdException;
 /**
  * This class is used read information from an RRD file. Writing
  * to RRD files is not currently supported. It uses NIO's RandomAccessFile to read the file
- * <p/>
+ *
  * Currently this can read RRD files that were generated on Solaris (Sparc)
  * and Linux (x86).
  *
diff --git a/apps/jrobin/java/src/org/rrd4j/core/jrrd/UnivalArray.java b/apps/jrobin/java/src/org/rrd4j/core/jrrd/UnivalArray.java
index 5d10be1ecf..2f62df7986 100644
--- a/apps/jrobin/java/src/org/rrd4j/core/jrrd/UnivalArray.java
+++ b/apps/jrobin/java/src/org/rrd4j/core/jrrd/UnivalArray.java
@@ -7,7 +7,7 @@ import java.nio.ByteOrder;
 /**
  * This class is used to read a unival from a file
  * unival is a rrdtool type, defined in rrd_format.h
- * @author Fabrice Bacchella <fbacchella@spamcop.net>
+ * @author Fabrice Bacchella fbacchella@spamcop.net
  *
  */
 class UnivalArray {
diff --git a/apps/jrobin/java/src/org/rrd4j/data/Source.java b/apps/jrobin/java/src/org/rrd4j/data/Source.java
index 6a79c6c5c0..113ce907cd 100644
--- a/apps/jrobin/java/src/org/rrd4j/data/Source.java
+++ b/apps/jrobin/java/src/org/rrd4j/data/Source.java
@@ -34,7 +34,7 @@ abstract class Source {
      * @param tStart
      * @param tEnd
      * @return
-     * @deprecated This method is deprecated. Uses instance of {@link org.rrd4j.data.Variable}, used with {@link org.rrd4j.data.DataProcessor.addDatasource(String, String, Variable)}
+     * @deprecated This method is deprecated. Uses instance of {@link org.rrd4j.data.Variable}, used with DataProcessor.addDatasource(String, String, Variable)
      */
     @Deprecated
     Aggregates getAggregates(long tStart, long tEnd) {
@@ -47,7 +47,7 @@ abstract class Source {
      * @param tEnd
      * @param percentile
      * @return
-     * @deprecated This method is deprecated. Uses instance of {@link org.rrd4j.data.Variable.PERCENTILE}, used with {@link org.rrd4j.data.DataProcessor.addDatasource(String, String, Variable)}
+     * @deprecated This method is deprecated. Uses instance of {@link org.rrd4j.data.Variable.PERCENTILE}, used with DataProcessor.addDatasource(String, String, Variable)
      */
     @Deprecated
     double getPercentile(long tStart, long tEnd, double percentile) {
-- 
GitLab