From e68fbc0243f121060fc61da81bc9e5337f15668f Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Thu, 10 Feb 2011 17:08:10 +0000
Subject: [PATCH] remove debug nulling, was causing NPE at session close
---
core/java/src/net/i2p/data/i2cp/I2CPMessageReader.java | 3 ---
.../src/net/i2p/internal/QueuedI2CPMessageReader.java | 8 +-------
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/core/java/src/net/i2p/data/i2cp/I2CPMessageReader.java b/core/java/src/net/i2p/data/i2cp/I2CPMessageReader.java
index 99990e0b5c..39633881e8 100644
--- a/core/java/src/net/i2p/data/i2cp/I2CPMessageReader.java
+++ b/core/java/src/net/i2p/data/i2cp/I2CPMessageReader.java
@@ -197,9 +197,6 @@ public class I2CPMessageReader {
}
}
_stream = null;
- _listener = null;
- _reader = null;
- _readerThread = null;
}
}
}
diff --git a/core/java/src/net/i2p/internal/QueuedI2CPMessageReader.java b/core/java/src/net/i2p/internal/QueuedI2CPMessageReader.java
index 13c82cc6b5..86f82241be 100644
--- a/core/java/src/net/i2p/internal/QueuedI2CPMessageReader.java
+++ b/core/java/src/net/i2p/internal/QueuedI2CPMessageReader.java
@@ -11,13 +11,11 @@ import net.i2p.util.I2PThread;
* @since 0.8.3
*/
public class QueuedI2CPMessageReader extends I2CPMessageReader {
- private /* final */ I2CPMessageQueue in;
+ private final I2CPMessageQueue in;
public QueuedI2CPMessageReader(I2CPMessageQueue in, I2CPMessageEventListener lsnr) {
super(lsnr);
this.in = in;
- _reader = null;
- _readerThread = null;
_reader = new QueuedI2CPMessageReaderRunner();
_readerThread = new I2PThread(_reader, "I2CP Internal Reader " + (++__readerId), true);
}
@@ -61,10 +59,6 @@ public class QueuedI2CPMessageReader extends I2CPMessageReader {
}
}
}
- super.run(); // Since we are dead, this will do some clean up, nothing else :-)
- in = null;
- _readerThread = null;
- _reader = null;
}
}
}
--
GitLab