From d2bdbcd27d95d53aaf8bcbf34bcd7d7dbf4937eb Mon Sep 17 00:00:00 2001
From: zab2 <zab2@mail.i2p>
Date: Thu, 28 Mar 2019 13:31:39 +0000
Subject: [PATCH] correct io pattern
---
.../java/src/net/i2p/i2ptunnel/access/AccessFilter.java | 6 ++++--
.../i2p/i2ptunnel/access/FileFilterDefinitionElement.java | 3 ++-
.../java/src/net/i2p/i2ptunnel/access/FilterFactory.java | 3 ++-
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/AccessFilter.java b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/AccessFilter.java
index 94c9933e58..f44e81713b 100644
--- a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/AccessFilter.java
+++ b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/AccessFilter.java
@@ -92,8 +92,9 @@ class AccessFilter implements IncomingConnectionFilter {
// if the file already exists, add previously breached b32s
if (file.exists() && file.isFile()) {
- BufferedReader reader = new BufferedReader(new FileReader(file));
+ BufferedReader reader = null;
try {
+ reader = new BufferedReader(new FileReader(file));
String b32;
while((b32 = reader.readLine()) != null)
breached.add(b32);
@@ -102,8 +103,9 @@ class AccessFilter implements IncomingConnectionFilter {
}
}
- BufferedWriter writer = new BufferedWriter(new FileWriter(file));
+ BufferedWriter writer = null;
try {
+ writer = new BufferedWriter(new FileWriter(file));
for (String b32 : breached) {
writer.write(b32);
writer.newLine();
diff --git a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/FileFilterDefinitionElement.java b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/FileFilterDefinitionElement.java
index f9bf4ff4a7..b515badc11 100644
--- a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/FileFilterDefinitionElement.java
+++ b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/FileFilterDefinitionElement.java
@@ -20,8 +20,9 @@ class FileFilterDefinitionElement extends FilterDefinitionElement {
public void update(Map<String, DestTracker> map) throws IOException {
if (!(file.exists() && file.isFile()))
return;
- BufferedReader reader = new BufferedReader(new FileReader(file));
+ BufferedReader reader = null;
try {
+ reader = new BufferedReader(new FileReader(file));
String b32;
while((b32 = reader.readLine()) != null) {
if (map.containsKey(b32))
diff --git a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/FilterFactory.java b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/FilterFactory.java
index fa9558507e..0571e96d05 100644
--- a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/FilterFactory.java
+++ b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/access/FilterFactory.java
@@ -16,8 +16,9 @@ public class FilterFactory {
throws IOException, InvalidDefinitionException {
List<String> linesList = new ArrayList<String>();
- BufferedReader reader = new BufferedReader(new FileReader(definition));
+ BufferedReader reader = null;
try {
+ reader = new BufferedReader(new FileReader(definition));
String line;
while((line = reader.readLine()) != null) {
line = line.trim();
--
GitLab