From cd83c48526e2765ed7bef2e266a09a7a3c9edea5 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Wed, 7 May 2014 14:41:28 +0000
Subject: [PATCH] DSAEngine: Minor cleanup
---
core/java/src/net/i2p/crypto/DSAEngine.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/core/java/src/net/i2p/crypto/DSAEngine.java b/core/java/src/net/i2p/crypto/DSAEngine.java
index b80dac38c6..20e2b3d035 100644
--- a/core/java/src/net/i2p/crypto/DSAEngine.java
+++ b/core/java/src/net/i2p/crypto/DSAEngine.java
@@ -389,7 +389,6 @@ public class DSAEngine {
throw new IllegalArgumentException("Bad key type " + signingKey.getType());
long start = _context.clock().now();
- Signature sig = new Signature();
BigInteger k;
boolean ok = false;
@@ -452,14 +451,13 @@ public class DSAEngine {
for (int i = 0; i < sbytes.length; i++)
out[i + 20 + 20 - sbytes.length] = sbytes[i];
}
- sig.setData(out);
long diff = _context.clock().now() - start;
if (diff > 1000) {
if (_log.shouldLog(Log.WARN)) _log.warn("Took too long to sign (" + diff + "ms)");
}
- return sig;
+ return new Signature(out);
}
/**
@@ -645,7 +643,7 @@ public class DSAEngine {
case RSA:
return "NONEwithRSA";
default:
- throw new IllegalArgumentException();
+ throw new UnsupportedOperationException("Raw signatures unsupported for " + type);
}
}
@@ -657,7 +655,7 @@ public class DSAEngine {
return "NONEwithECDSA";
if (key instanceof RSAKey)
return "NONEwithRSA";
- throw new IllegalArgumentException();
+ throw new UnsupportedOperationException("Raw signatures unsupported for " + key.getClass().getName());
}
//private static final int RUNS = 1000;
--
GitLab