From b573dab05f930f2e37d088e4ffbc241313f37ae3 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Tue, 20 May 2014 13:22:07 +0000
Subject: [PATCH] javadocs
---
.../src/org/klomp/snark/ExtensionHandler.java | 2 +-
core/java/src/net/i2p/data/DataHelper.java | 19 ++++++++++++++++---
2 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/apps/i2psnark/java/src/org/klomp/snark/ExtensionHandler.java b/apps/i2psnark/java/src/org/klomp/snark/ExtensionHandler.java
index abb08473ca..001897764e 100644
--- a/apps/i2psnark/java/src/org/klomp/snark/ExtensionHandler.java
+++ b/apps/i2psnark/java/src/org/klomp/snark/ExtensionHandler.java
@@ -31,7 +31,7 @@ abstract class ExtensionHandler {
public static final int ID_DHT = 3;
/** not using the option bit since the compact format is different */
public static final String TYPE_DHT = "i2p_dht";
- /** Pieces * SHA1 Hash length, + 25% extra for file names, benconding overhead, etc */
+ /** Pieces * SHA1 Hash length, + 25% extra for file names, bencoding overhead, etc */
private static final int MAX_METADATA_SIZE = Storage.MAX_PIECES * 20 * 5 / 4;
private static final int PARALLEL_REQUESTS = 3;
diff --git a/core/java/src/net/i2p/data/DataHelper.java b/core/java/src/net/i2p/data/DataHelper.java
index 9c9cfc27cb..2aadec93bf 100644
--- a/core/java/src/net/i2p/data/DataHelper.java
+++ b/core/java/src/net/i2p/data/DataHelper.java
@@ -525,7 +525,7 @@ public class DataHelper {
return toString(buf, buf.length);
}
- private static final byte[] EMPTY_BUFFER = "".getBytes();
+ private static final byte[] EMPTY_BUFFER = new byte[0];
/**
* Lower-case hex with leading zeros.
@@ -551,10 +551,18 @@ public class DataHelper {
return out.toString();
}
+ /**
+ * Positive decimal without leading zeros.
+ * @param data may be null (returns "0")
+ * @param len unused
+ * @return (new BigInteger(1, buf)).toString()
+ * @deprecated unused
+ */
public static String toDecimalString(byte buf[], int len) {
- if (buf == null) buf = EMPTY_BUFFER;
+ if (buf == null)
+ return "0";
BigInteger val = new BigInteger(1, buf);
- return val.toString(10);
+ return val.toString();
}
/**
@@ -568,6 +576,11 @@ public class DataHelper {
return bi.toString(16);
}
+ /**
+ * @param val non-null, may have leading minus sign
+ * @return minimum-length representation (with possible leading 0 byte)
+ * @deprecated unused
+ */
public final static byte[] fromHexString(String val) {
BigInteger bv = new BigInteger(val, 16);
return bv.toByteArray();
--
GitLab