From a00b9bb0c717b7ab10cb8f96ee3f01c35abea8d6 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Wed, 27 May 2020 11:54:06 +0000
Subject: [PATCH] Console: Handle bad param on /peers
---
.../net/i2p/router/web/helpers/PeerHelper.java | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/apps/routerconsole/java/src/net/i2p/router/web/helpers/PeerHelper.java b/apps/routerconsole/java/src/net/i2p/router/web/helpers/PeerHelper.java
index ead330ebd7..90a5dfe3dc 100644
--- a/apps/routerconsole/java/src/net/i2p/router/web/helpers/PeerHelper.java
+++ b/apps/routerconsole/java/src/net/i2p/router/web/helpers/PeerHelper.java
@@ -111,22 +111,34 @@ public class PeerHelper extends HelperBase {
SortedMap<String, Transport> transports = _context.commSystem().getTransports();
if (_transport != null && !_transport.equals("upnp")) {
+ boolean rendered = false;
for (Map.Entry<String, Transport> e : transports.entrySet()) {
String style = e.getKey();
Transport t = e.getValue();
if (style.equals("NTCP") && "ntcp".equals(_transport)) {
NTCPTransport nt = (NTCPTransport) t;
render(nt, out, urlBase, sortFlags);
+ rendered = true;
+ break;
} else if (style.equals("SSU") && "ssu".equals(_transport)) {
UDPTransport ut = (UDPTransport) t;
render(ut, out, urlBase, sortFlags);
- } else {
+ rendered = true;
+ break;
+ } else if (style.equals(_transport)) {
// pluggable (none yet)
t.renderStatusHTML(out, urlBase, sortFlags);
+ rendered = true;
+ break;
}
}
- if (!transports.isEmpty()) {
+ if (rendered) {
out.write(getTransportsLegend());
+ } else {
+ out.write("<p class=\"infohelp\">" +
+ "Transport not enabled: " +
+ DataHelper.escapeHTML(_transport) +
+ "</p>");
}
} else if (_transport == null) {
StringBuilder buf = new StringBuilder(4*1024);
--
GitLab