From 621862afa94e1730438077193460d28f78054c5c Mon Sep 17 00:00:00 2001
From: zzz <zzz@i2pmail.org>
Date: Wed, 8 Feb 2023 09:25:42 -0500
Subject: [PATCH] NetDB: Replace Set with List in ExpireLeasesJob for
efficiency
---
.../i2p/router/networkdb/kademlia/ExpireLeasesJob.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/router/java/src/net/i2p/router/networkdb/kademlia/ExpireLeasesJob.java b/router/java/src/net/i2p/router/networkdb/kademlia/ExpireLeasesJob.java
index 23d50e0707..7cb516e647 100644
--- a/router/java/src/net/i2p/router/networkdb/kademlia/ExpireLeasesJob.java
+++ b/router/java/src/net/i2p/router/networkdb/kademlia/ExpireLeasesJob.java
@@ -8,9 +8,9 @@ package net.i2p.router.networkdb.kademlia;
*
*/
-import java.util.HashSet;
+import java.util.ArrayList;
+import java.util.List;
import java.util.Map;
-import java.util.Set;
import net.i2p.data.DatabaseEntry;
import net.i2p.data.Hash;
@@ -41,7 +41,7 @@ class ExpireLeasesJob extends JobImpl {
public String getName() { return "Expire Lease Sets Job"; }
public void runJob() {
- Set<Hash> toExpire = selectKeysToExpire();
+ List<Hash> toExpire = selectKeysToExpire();
_log.info("Leases to expire: " + toExpire);
for (Hash key : toExpire) {
_facade.fail(key);
@@ -57,8 +57,8 @@ class ExpireLeasesJob extends JobImpl {
* don't have any leases that haven't yet passed, even with the CLOCK_FUDGE_FACTOR)
*
*/
- private Set<Hash> selectKeysToExpire() {
- Set<Hash> toExpire = new HashSet<Hash>(128);
+ private List<Hash> selectKeysToExpire() {
+ List<Hash> toExpire = new ArrayList<Hash>(128);
for (Map.Entry<Hash, DatabaseEntry> entry : _facade.getDataStore().getMapEntries()) {
DatabaseEntry obj = entry.getValue();
if (obj.isLeaseSet()) {
--
GitLab