From 4fe24790fde526a08db987fa8c95421e2d8967b5 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Sat, 12 Dec 2015 23:14:39 +0000
Subject: [PATCH] RouterInfo: Log the full RI, not the hash of the data (which
is useless) on signature verification fail, in an attempt to find the culprit
---
.../java/src/net/i2p/data/router/RouterInfo.java | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/router/java/src/net/i2p/data/router/RouterInfo.java b/router/java/src/net/i2p/data/router/RouterInfo.java
index 299a51e960..ef3fed9fdf 100644
--- a/router/java/src/net/i2p/data/router/RouterInfo.java
+++ b/router/java/src/net/i2p/data/router/RouterInfo.java
@@ -487,16 +487,10 @@ public class RouterInfo extends DatabaseEntry {
if (!_isValid) {
Log log = I2PAppContext.getGlobalContext().logManager().getLog(RouterInfo.class);
- byte data[] = null;
- try {
- data = getBytes();
- } catch (DataFormatException dfe) {
- log.error("Error validating", dfe);
- return;
- }
- log.error("Invalid [" + SHA256Generator.getInstance().calculateHash(data).toBase64()
- + (log.shouldLog(Log.WARN) ? ("]\n" + toString()) : ""),
- new Exception("Signature failed"));
+ // TODO change to warn
+ //if (log.shouldWarn()) {
+ log.error("Sig verify fail: " + toString(), new Exception("from"));
+ //}
}
}
--
GitLab