diff --git a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/I2PTunnelConnectClient.java b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/I2PTunnelConnectClient.java index 1014a986b71438b91a75c2650be2d156c2041a4e..37b7f8e4543634353314deae0fed5b4f6a1cbec4 100644 --- a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/I2PTunnelConnectClient.java +++ b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/I2PTunnelConnectClient.java @@ -305,7 +305,8 @@ public class I2PTunnelConnectClient extends I2PTunnelHTTPClientBase implements R else response = SUCCESS_RESPONSE; Runnable onTimeout = new OnTimeout(s, s.getOutputStream(), targetRequest, usingWWWProxy, currentProxy, requestId); - I2PTunnelRunner runner = new I2PTunnelRunner(s, i2ps, sockLock, data, response, mySockets, onTimeout); + // starts itself + new I2PTunnelRunner(s, i2ps, sockLock, data, response, mySockets, onTimeout); } catch (SocketException ex) { _log.info(getPrefix(requestId) + "Error trying to connect", ex); handleConnectClientException(ex, out, targetRequest, usingWWWProxy, currentProxy, requestId); diff --git a/apps/streaming/java/src/net/i2p/client/streaming/Connection.java b/apps/streaming/java/src/net/i2p/client/streaming/Connection.java index 239c77d1b2ec8271f8a2d69899f0b37820a90c8e..0eb8fe66ff2b9b68583194d4642ad6a5131fb16d 100644 --- a/apps/streaming/java/src/net/i2p/client/streaming/Connection.java +++ b/apps/streaming/java/src/net/i2p/client/streaming/Connection.java @@ -347,7 +347,7 @@ class Connection { _log.debug("Resend in " + timeout + " for " + packet); // schedules itself - ResendPacketEvent rpe = new ResendPacketEvent(packet, timeout); + new ResendPacketEvent(packet, timeout); } // warning, getStatLog() can be null diff --git a/apps/susidns/src/java/src/i2p/susi/dns/AddressbookBean.java b/apps/susidns/src/java/src/i2p/susi/dns/AddressbookBean.java index 9aa327c052377ab46cadbf1d6eef773fe65238fa..2ada2b3b639b8e663c4c52eb8665098fce11acff 100644 --- a/apps/susidns/src/java/src/i2p/susi/dns/AddressbookBean.java +++ b/apps/susidns/src/java/src/i2p/susi/dns/AddressbookBean.java @@ -300,7 +300,8 @@ public class AddressbookBean } else { boolean valid = true; try { - Destination dest = new Destination(destination); + // just to check validity + new Destination(destination); } catch (DataFormatException dfe) { valid = false; } diff --git a/apps/systray/java/src/net/i2p/apps/systray/UrlLauncher.java b/apps/systray/java/src/net/i2p/apps/systray/UrlLauncher.java index 93d9d36bba49eea1957a09ffb1a9ecaffa5eef20..67643b6776722be1943ec7c18465180d0ce2e61b 100644 --- a/apps/systray/java/src/net/i2p/apps/systray/UrlLauncher.java +++ b/apps/systray/java/src/net/i2p/apps/systray/UrlLauncher.java @@ -225,7 +225,8 @@ public class UrlLauncher { private boolean validateUrlFormat(String urlString) { try { - URL url = new URL(urlString); + // just to check validity + new URL(urlString); } catch (MalformedURLException e) { return false; } diff --git a/core/java/src/net/i2p/crypto/TrustedUpdate.java b/core/java/src/net/i2p/crypto/TrustedUpdate.java index 0b0b35b6416128a8e1a399f638969eb849196527..939742d43f02e88ef0083a1fc4f1624f2d2ce4c0 100644 --- a/core/java/src/net/i2p/crypto/TrustedUpdate.java +++ b/core/java/src/net/i2p/crypto/TrustedUpdate.java @@ -129,10 +129,10 @@ JXQAnA28vDmMMMH/WPbC5ixmJeGGNUiR public static final int HEADER_BYTES = Signature.SIGNATURE_BYTES + VERSION_BYTES; private static final String PROP_TRUSTED_KEYS = "router.trustedUpdateKeys"; - private static I2PAppContext _context; + private final I2PAppContext _context; - private Log _log; - private Map<SigningPublicKey, String> _trustedKeys; + private final Log _log; + private final Map<SigningPublicKey, String> _trustedKeys; private String _newVersion; /** 172 */ private static final int KEYSIZE_B64_BYTES = 2 + (SigningPublicKey.KEYSIZE_BYTES * 4 / 3); @@ -155,7 +155,6 @@ JXQAnA28vDmMMMH/WPbC5ixmJeGGNUiR _context = context; _log = _context.logManager().getLog(TrustedUpdate.class); _trustedKeys = new HashMap(4); - _newVersion = null; String propertyTrustedKeys = context.getProperty(PROP_TRUSTED_KEYS); @@ -273,9 +272,9 @@ JXQAnA28vDmMMMH/WPbC5ixmJeGGNUiR private static final boolean genKeysCLI(String publicKeyFile, String privateKeyFile) { FileOutputStream fileOutputStream = null; - _context = I2PAppContext.getGlobalContext(); + I2PAppContext context = I2PAppContext.getGlobalContext(); try { - Object signingKeypair[] = _context.keyGenerator().generateSigningKeypair(); + Object signingKeypair[] = context.keyGenerator().generateSigningKeypair(); SigningPublicKey signingPublicKey = (SigningPublicKey) signingKeypair[0]; SigningPrivateKey signingPrivateKey = (SigningPrivateKey) signingKeypair[1]; diff --git a/router/java/src/net/i2p/router/networkdb/kademlia/KBucketImpl.java b/router/java/src/net/i2p/router/networkdb/kademlia/KBucketImpl.java index bd7c62fdeb5399644a99fc6da5b503df0514ca67..98ed326868a12b296a8a68afdc0cd3276ebb279d 100644 --- a/router/java/src/net/i2p/router/networkdb/kademlia/KBucketImpl.java +++ b/router/java/src/net/i2p/router/networkdb/kademlia/KBucketImpl.java @@ -379,7 +379,7 @@ class KBucketImpl implements KBucket { } private static void testRand() { - StringBuilder buf = new StringBuilder(2048); + //StringBuilder buf = new StringBuilder(2048); int low = 1; int high = 3; Log log = I2PAppContext.getGlobalContext().logManager().getLog(KBucketImpl.class);