From 1bcb9b24b62f3fadf7029bbbf5c3320a1669594a Mon Sep 17 00:00:00 2001 From: zzz <zzz@mail.i2p> Date: Sat, 7 Jun 2014 13:16:19 +0000 Subject: [PATCH] * Console: Fix NPE in summary bar --- .../java/src/net/i2p/router/web/SummaryHelper.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/apps/routerconsole/java/src/net/i2p/router/web/SummaryHelper.java b/apps/routerconsole/java/src/net/i2p/router/web/SummaryHelper.java index 3c868417d2..f7f6700a56 100644 --- a/apps/routerconsole/java/src/net/i2p/router/web/SummaryHelper.java +++ b/apps/routerconsole/java/src/net/i2p/router/web/SummaryHelper.java @@ -158,8 +158,13 @@ public class SummaryHelper extends HelperBase { switch (status) { case CommSystemFacade.STATUS_OK: RouterAddress ra = routerInfo.getTargetAddress("NTCP"); + if (ra == null) + return _("OK"); + byte[] ip = ra.getIP(); + if (ip == null) + return _("ERR-Unresolved TCP Address"); // TODO set IPv6 arg based on configuration? - if (ra == null || TransportUtil.isPubliclyRoutable(ra.getIP(), true)) + if (TransportUtil.isPubliclyRoutable(ip, true)) return _("OK"); return _("ERR-Private TCP Address"); case CommSystemFacade.STATUS_DIFFERENT: -- GitLab