From 184b6179e50d5f74c3a191ba2bd1ae51b970c7eb Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Mon, 8 Oct 2018 14:24:46 +0000
Subject: [PATCH] i2psnark: Sync field access (findbugs)
---
.../java/src/org/klomp/snark/web/BasicServlet.java | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/apps/i2psnark/java/src/org/klomp/snark/web/BasicServlet.java b/apps/i2psnark/java/src/org/klomp/snark/web/BasicServlet.java
index 8e10532b69..07e9bedbb8 100644
--- a/apps/i2psnark/java/src/org/klomp/snark/web/BasicServlet.java
+++ b/apps/i2psnark/java/src/org/klomp/snark/web/BasicServlet.java
@@ -157,12 +157,15 @@ class BasicServlet extends HttpServlet
*/
public File getResource(String pathInContext)
{
- if (_resourceBase==null)
- return null;
File r = null;
if (!pathInContext.contains("..") &&
!pathInContext.endsWith("/")) {
- File f = new File(_resourceBase, pathInContext);
+ File f;
+ synchronized (this) {
+ if (_resourceBase==null)
+ return null;
+ f = new File(_resourceBase, pathInContext);
+ }
if (f.exists())
r = f;
}
@@ -178,8 +181,6 @@ class BasicServlet extends HttpServlet
*/
public HttpContent getContent(String pathInContext)
{
- if (_resourceBase==null)
- return null;
HttpContent r = null;
if (_warBase != null && pathInContext.startsWith(_warBase)) {
r = new JarContent(pathInContext);
--
GitLab