diff --git a/core/java/src/net/i2p/util/Clock.java b/core/java/src/net/i2p/util/Clock.java index 25600259c6b786f60f8ba33932b156b1c4830a8d..521facd2d583d6743d0493fa94e69d67567569e8 100644 --- a/core/java/src/net/i2p/util/Clock.java +++ b/core/java/src/net/i2p/util/Clock.java @@ -71,21 +71,27 @@ public class Clock implements Timestamper.UpdateListener { long delta = offsetMs - _offset; if (!force) { if ((offsetMs > MAX_OFFSET) || (offsetMs < 0 - MAX_OFFSET)) { - getLog().error("Maximum offset shift exceeded [" + offsetMs + "], NOT HONORING IT"); + Log log = getLog(); + if (log.shouldLog(Log.WARN)) + log.warn("Maximum offset shift exceeded [" + offsetMs + "], NOT HONORING IT"); return; } // only allow substantial modifications before the first 10 minutes if (_alreadyChanged && (System.currentTimeMillis() - _startedOn > 10 * 60 * 1000)) { if ( (delta > MAX_LIVE_OFFSET) || (delta < 0 - MAX_LIVE_OFFSET) ) { - getLog().log(Log.CRIT, "The clock has already been updated, but you want to change it by " + Log log = getLog(); + if (log.shouldLog(Log.WARN)) + log.warn("The clock has already been updated, but you want to change it by " + delta + " to " + offsetMs + "? Did something break?"); return; } } if ((delta < MIN_OFFSET_CHANGE) && (delta > 0 - MIN_OFFSET_CHANGE)) { - getLog().debug("Not changing offset since it is only " + delta + "ms"); + Log log = getLog(); + if (log.shouldLog(Log.DEBUG)) + log.debug("Not changing offset since it is only " + delta + "ms"); _alreadyChanged = true; return; } @@ -102,7 +108,9 @@ public class Clock implements Timestamper.UpdateListener { } _context.statManager().addRateData("clock.skew", delta, 0); } else { - getLog().log(Log.INFO, "Initializing clock offset to " + offsetMs + "ms from " + _offset + "ms"); + Log log = getLog(); + if (log.shouldLog(Log.INFO)) + log.info("Initializing clock offset to " + offsetMs + "ms from " + _offset + "ms"); } _alreadyChanged = true; _offset = offsetMs; diff --git a/router/java/src/net/i2p/router/RouterClock.java b/router/java/src/net/i2p/router/RouterClock.java index b3318cda3e96b292342cc5fc85b55aff1e643eaf..5bcafc8865fb766b05de0e4d2ef3cf8cef271561 100644 --- a/router/java/src/net/i2p/router/RouterClock.java +++ b/router/java/src/net/i2p/router/RouterClock.java @@ -95,14 +95,18 @@ public class RouterClock extends Clock { long delta = offsetMs - _offset; if (!force) { if ((offsetMs > MAX_OFFSET) || (offsetMs < 0 - MAX_OFFSET)) { - getLog().error("Maximum offset shift exceeded [" + offsetMs + "], NOT HONORING IT"); + Log log = getLog(); + if (log.shouldLog(Log.WARN)) + log.warn("Maximum offset shift exceeded [" + offsetMs + "], NOT HONORING IT"); return; } // only allow substantial modifications before the first 10 minutes if (_alreadyChanged && (System.currentTimeMillis() - _startedOn > 10 * 60 * 1000)) { if ( (delta > MAX_LIVE_OFFSET) || (delta < 0 - MAX_LIVE_OFFSET) ) { - getLog().log(Log.WARN, "The clock has already been updated, ignoring request to change it by " + Log log = getLog(); + if (log.shouldLog(Log.WARN)) + log.warn("The clock has already been updated, ignoring request to change it by " + delta + " to " + offsetMs, new Exception()); return; } @@ -118,7 +122,9 @@ public class RouterClock extends Clock { // only listen to a worse stratum if it's been a while if (_alreadyChanged && stratum > _lastStratum && System.currentTimeMillis() - _lastChanged < MIN_DELAY_FOR_WORSE_STRATUM) { - getLog().debug("Ignoring update from a stratum " + stratum + + Log log = getLog(); + if (log.shouldLog(Log.DEBUG)) + log.debug("Ignoring update from a stratum " + stratum + " clock, we recently had an update from a stratum " + _lastStratum + " clock"); return; } @@ -142,7 +148,9 @@ public class RouterClock extends Clock { "ms to " + predictedPeerClockSkew + "ms. Bad time server?"); return; } else { - getLog().debug("Approving clock offset " + offsetMs + "ms (current " + _offset + + Log log = getLog(); + if (log.shouldLog(Log.DEBUG)) + log.debug("Approving clock offset " + offsetMs + "ms (current " + _offset + "ms) since it would decrease peer clock skew from " + currentPeerClockSkew + "ms to " + predictedPeerClockSkew + "ms."); } @@ -167,7 +175,9 @@ public class RouterClock extends Clock { _context.statManager().addRateData("clock.skew", delta); _desiredOffset = offsetMs; } else { - getLog().log(Log.INFO, "Initializing clock offset to " + offsetMs + "ms, Stratum " + stratum); + Log log = getLog(); + if (log.shouldLog(Log.INFO)) + log.info("Initializing clock offset to " + offsetMs + "ms, Stratum " + stratum); _alreadyChanged = true; _offset = offsetMs; _desiredOffset = offsetMs;