From a9abf3babf9c12d907e4a8b3774ae8470a91dcd0 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Tue, 3 Dec 2019 15:53:49 +0000
Subject: [PATCH] less code inside synch block

---
 .../router/transport/OutboundMessageRegistry.java  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/router/java/src/net/i2p/router/transport/OutboundMessageRegistry.java b/router/java/src/net/i2p/router/transport/OutboundMessageRegistry.java
index f73634babe..eb59cfc20c 100644
--- a/router/java/src/net/i2p/router/transport/OutboundMessageRegistry.java
+++ b/router/java/src/net/i2p/router/transport/OutboundMessageRegistry.java
@@ -293,14 +293,14 @@ public class OutboundMessageRegistry {
                 for (MessageSelector sel : removing) {
                     OutNetMessage msg = null;
                     List<OutNetMessage> msgs = null;
+                    Object o;
                     synchronized (_selectorToMessage) {
-                        Object o = _selectorToMessage.remove(sel);
-                        if (o instanceof OutNetMessage) {
-                            msg = (OutNetMessage)o;
-                        } else if (o instanceof List) {
-                            //msgs = new ArrayList((List)o);
-                            msgs = (List<OutNetMessage>)o;
-                        }
+                        o = _selectorToMessage.remove(sel);
+                    }
+                    if (o instanceof OutNetMessage) {
+                        msg = (OutNetMessage)o;
+                    } else if (o instanceof List) {
+                        msgs = (List<OutNetMessage>)o;
                     }
                     if (msg != null) {
                         _activeMessages.remove(msg);
-- 
GitLab