From ea7ddaf6d591399f19f3702075fdaa25217e3a25 Mon Sep 17 00:00:00 2001 From: zzz Date: Thu, 18 Apr 2019 13:17:45 +0000 Subject: [PATCH] Console: Improve error message when graphs disabled (ticket #2452) --- .../src/net/i2p/router/web/helpers/GraphHelper.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/apps/routerconsole/java/src/net/i2p/router/web/helpers/GraphHelper.java b/apps/routerconsole/java/src/net/i2p/router/web/helpers/GraphHelper.java index 69dd7fe32..0ba4afeb6 100644 --- a/apps/routerconsole/java/src/net/i2p/router/web/helpers/GraphHelper.java +++ b/apps/routerconsole/java/src/net/i2p/router/web/helpers/GraphHelper.java @@ -19,6 +19,7 @@ import net.i2p.router.web.NavHelper; import net.i2p.router.web.StatSummarizer; import net.i2p.router.web.SummaryListener; import net.i2p.stat.Rate; +import net.i2p.util.SystemVersion; /** * /graphs.jsp, including form, and /graph.jsp @@ -436,11 +437,17 @@ public class GraphHelper extends FormHandler { @Override public String getAllMessages() { if (StatSummarizer.isDisabled(_context)) { - addFormError("Graphing not supported with this JVM: " + - System.getProperty("java.vendor") + ' ' + + addFormError("Graphing not supported with this JVM or OS"); + addFormNotice("JVM: " + System.getProperty("java.vendor") + ' ' + System.getProperty("java.version") + " (" + System.getProperty("java.runtime.name") + ' ' + System.getProperty("java.runtime.version") + ')'); + addFormNotice("OS: " + System.getProperty("os.name") + ' ' + + System.getProperty("os.arch") + ' ' + + System.getProperty("os.version")); + if (!SystemVersion.isMac() && !SystemVersion.isWindows()) + addFormNotice("Installing the fonts-dejavu package and then restarting I2P may resolve the issue"); + addFormNotice("Check logs for more information"); if (_context.getProperty(PROP_REFRESH, 0) >= 0) { // force no refresh, save silently _context.router().saveConfig(PROP_REFRESH, "-1");