From dc5bfb224d5769c13a9cab06687ef6185cd571f4 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Thu, 26 Jan 2017 20:59:26 +0000
Subject: [PATCH] javadoc fixes part 4 (ticket #1894)

---
 core/java/src/net/i2p/crypto/eddsa/EdDSAEngine.java            | 2 +-
 core/java/src/net/i2p/crypto/eddsa/math/GroupElement.java      | 2 ++
 .../net/i2p/crypto/eddsa/math/ed25519/Ed25519FieldElement.java | 3 +++
 .../crypto/eddsa/math/ed25519/Ed25519LittleEndianEncoding.java | 1 +
 core/java/src/net/i2p/crypto/elgamal/ElGamalSigEngine.java     | 2 +-
 5 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/core/java/src/net/i2p/crypto/eddsa/EdDSAEngine.java b/core/java/src/net/i2p/crypto/eddsa/EdDSAEngine.java
index 5fd1557e5..f693b946d 100644
--- a/core/java/src/net/i2p/crypto/eddsa/EdDSAEngine.java
+++ b/core/java/src/net/i2p/crypto/eddsa/EdDSAEngine.java
@@ -435,7 +435,7 @@ public final class EdDSAEngine extends Signature {
     }
 
     /**
-     * @deprecated replaced with <a href="#engineSetParameter(java.security.spec.AlgorithmParameterSpec)">
+     * @deprecated replaced with <a href="#engineSetParameter(java.security.spec.AlgorithmParameterSpec)">this</a>
      */
     @Override
     protected void engineSetParameter(String param, Object value) {
diff --git a/core/java/src/net/i2p/crypto/eddsa/math/GroupElement.java b/core/java/src/net/i2p/crypto/eddsa/math/GroupElement.java
index 3a6c57b82..712fa7085 100644
--- a/core/java/src/net/i2p/crypto/eddsa/math/GroupElement.java
+++ b/core/java/src/net/i2p/crypto/eddsa/math/GroupElement.java
@@ -33,6 +33,7 @@ public class GroupElement implements Serializable {
      * <li>P1P1: Completed representation ((X:Z), (Y:T)) satisfying x=X/Z, y=Y/T.
      * <li>PRECOMP: Precomputed representation (y+x, y-x, 2dxy).
      * <li>CACHED: Cached representation (Y+X, Y-X, Z, 2dT)
+     * </ul>
      */
     public enum Representation {
         /** Projective (P^2): (X:Y:Z) satisfying x=X/Z, y=Y/Z */
@@ -220,6 +221,7 @@ public class GroupElement implements Serializable {
      * <li>If v * β = -u multiply β with i=sqrt(-1).
      * <li>Set x := β.
      * <li>If sign(x) != bit 255 of s then negate x.
+     * </ul>
      *
      * @param curve The curve.
      * @param s The encoded point.
diff --git a/core/java/src/net/i2p/crypto/eddsa/math/ed25519/Ed25519FieldElement.java b/core/java/src/net/i2p/crypto/eddsa/math/ed25519/Ed25519FieldElement.java
index 53cff91a0..7f773e456 100644
--- a/core/java/src/net/i2p/crypto/eddsa/math/ed25519/Ed25519FieldElement.java
+++ b/core/java/src/net/i2p/crypto/eddsa/math/ed25519/Ed25519FieldElement.java
@@ -58,6 +58,7 @@ public class Ed25519FieldElement extends FieldElement {
      * Postconditions:
      * <p><ul>
      * <li>|h| bounded by 1.1*2^26,1.1*2^25,1.1*2^26,1.1*2^25,etc.
+     * </ul>
      *
      * @param val The field element to add.
      * @return The field element this + val.
@@ -86,6 +87,7 @@ public class Ed25519FieldElement extends FieldElement {
      * Postconditions:
      * <p><ul>
      * <li>|h| bounded by 1.1*2^26,1.1*2^25,1.1*2^26,1.1*2^25,etc.
+     * </ul>
      *
      * @param val The field element to subtract.
      * @return The field element this - val.
@@ -111,6 +113,7 @@ public class Ed25519FieldElement extends FieldElement {
      * Postconditions:
      * <p><ul>
      * <li>|h| bounded by 1.1*2^25,1.1*2^24,1.1*2^25,1.1*2^24,etc.
+     * </ul>
      *
      * @return The field element (-1) * this.
      */
diff --git a/core/java/src/net/i2p/crypto/eddsa/math/ed25519/Ed25519LittleEndianEncoding.java b/core/java/src/net/i2p/crypto/eddsa/math/ed25519/Ed25519LittleEndianEncoding.java
index 670da6471..611a0a1d8 100644
--- a/core/java/src/net/i2p/crypto/eddsa/math/ed25519/Ed25519LittleEndianEncoding.java
+++ b/core/java/src/net/i2p/crypto/eddsa/math/ed25519/Ed25519LittleEndianEncoding.java
@@ -213,6 +213,7 @@ public class Ed25519LittleEndianEncoding extends Encoding {
      * Preconditions:
      * <p><ul>
      * <li>|x| bounded by 1.1*2^26,1.1*2^25,1.1*2^26,1.1*2^25,etc.
+     * </ul>
      *
      * @return true if x is in {1,3,5,...,q-2}, false otherwise.
      */
diff --git a/core/java/src/net/i2p/crypto/elgamal/ElGamalSigEngine.java b/core/java/src/net/i2p/crypto/elgamal/ElGamalSigEngine.java
index b44dc5fbe..b3f26703d 100644
--- a/core/java/src/net/i2p/crypto/elgamal/ElGamalSigEngine.java
+++ b/core/java/src/net/i2p/crypto/elgamal/ElGamalSigEngine.java
@@ -147,7 +147,7 @@ public final class ElGamalSigEngine extends Signature {
     }
 
     /**
-     * @deprecated replaced with <a href="#engineSetParameter(java.security.spec.AlgorithmParameterSpec)">
+     * @deprecated replaced with <a href="#engineSetParameter(java.security.spec.AlgorithmParameterSpec)">this</a>
      */
     @Override
     protected void engineSetParameter(String param, Object value) {