From 9aa36562b903c37dc8d045634f17b00ea6ed6c29 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Mon, 11 May 2020 20:12:40 +0000
Subject: [PATCH] i2psnark: Remove onclick on folder page

---
 .../org/klomp/snark/web/I2PSnarkServlet.java  | 12 ++---
 apps/i2psnark/resources/js/folder.js          | 50 +++++++++++++++++++
 2 files changed, 56 insertions(+), 6 deletions(-)

diff --git a/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java b/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java
index 9a58bfeb8..7d11305b7 100644
--- a/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java
+++ b/apps/i2psnark/java/src/org/klomp/snark/web/I2PSnarkServlet.java
@@ -3686,7 +3686,7 @@ public class I2PSnarkServlet extends BasicServlet {
                 if ((!complete) && (!item.isDirectory())) {
                     if (!inOrder) {
                         buf.append("<label class=\"priorityHigh\" title=\"").append(_t("Download file at high priority")).append("\">" +
-                                   "\n<input type=\"radio\" onclick=\"priorityclicked();\" class=\"prihigh\" value=\"5\" name=\"pri.").append(fileIndex).append("\" ");
+                                   "\n<input type=\"radio\" class=\"prihigh\" value=\"5\" name=\"pri.").append(fileIndex).append("\" ");
                         if (priority > 0)
                             buf.append("checked=\"checked\"");
                         buf.append('>')
@@ -3694,14 +3694,14 @@ public class I2PSnarkServlet extends BasicServlet {
                     }
 
                     buf.append("<label class=\"priorityNormal\" title=\"").append(_t("Download file at normal priority")).append("\">" +
-                               "\n<input type=\"radio\" onclick=\"priorityclicked();\" class=\"prinorm\" value=\"0\" name=\"pri.").append(fileIndex).append("\" ");
+                               "\n<input type=\"radio\" class=\"prinorm\" value=\"0\" name=\"pri.").append(fileIndex).append("\" ");
                     if (priority == 0 || (inOrder && priority >= 0))
                         buf.append("checked=\"checked\"");
                     buf.append('>')
                        .append(_t("Normal")).append("</label>");
 
                     buf.append("<label class=\"prioritySkip\" title=\"").append(_t("Do not download this file")).append("\">" +
-                               "\n<input type=\"radio\" onclick=\"priorityclicked();\" class=\"priskip\" value=\"-9\" name=\"pri.").append(fileIndex).append("\" ");
+                               "\n<input type=\"radio\" class=\"priskip\" value=\"-9\" name=\"pri.").append(fileIndex).append("\" ");
                     if (priority < 0)
                         buf.append("checked=\"checked\"");
                     buf.append('>')
@@ -3716,12 +3716,12 @@ public class I2PSnarkServlet extends BasicServlet {
             buf.append("<thead><tr id=\"setPriority\"><th class=\"headerpriority\" colspan=\"5\">" +
                        "<span class=\"script\">");
             if (!inOrder) {
-                buf.append("<a class=\"control\" id=\"setallhigh\" href=\"javascript:void(null);\" onclick=\"setallhigh();\">")
+                buf.append("<a class=\"control\" id=\"setallhigh\" href=\"#\">")
                    .append(toImg("clock_red")).append(_t("Set all high")).append("</a>\n");
             }
-            buf.append("<a class=\"control\" id=\"setallnorm\" href=\"javascript:void(null);\" onclick=\"setallnorm();\">")
+            buf.append("<a class=\"control\" id=\"setallnorm\" href=\"#\">")
                .append(toImg("clock")).append(_t("Set all normal")).append("</a>\n" +
-                       "<a class=\"control\" id=\"setallskip\" href=\"javascript:void(null);\" onclick=\"setallskip();\">")
+                       "<a class=\"control\" id=\"setallskip\" href=\"#\">")
                .append(toImg("cancel")).append(_t("Skip all")).append("</a></span>\n" +
                        "<input type=\"submit\" class=\"accept\" value=\"").append(_t("Save priorities"))
                .append("\" name=\"savepri\" >\n" +
diff --git a/apps/i2psnark/resources/js/folder.js b/apps/i2psnark/resources/js/folder.js
index e5bec44ad..53eb7ba41 100644
--- a/apps/i2psnark/resources/js/folder.js
+++ b/apps/i2psnark/resources/js/folder.js
@@ -1,6 +1,49 @@
 const setupbuttons=()=>{
 	let sp = document.forms[0].savepri;
 	if ( sp ) updatesetallbuttons(), sp.disabled = true, sp.className = 'disabled';
+
+	var buttons = document.getElementsByClassName("prihigh");
+	for(index = 0; index < buttons.length; index++)
+	{
+		var button = buttons[index];
+                if (!button.disabled)
+			addClickHandler(button);
+	}
+	buttons = document.getElementsByClassName("prinorm");
+	for(index = 0; index < buttons.length; index++)
+	{
+		var button = buttons[index];
+                if (!button.disabled)
+	 		addClickHandler(button);
+	}
+	buttons = document.getElementsByClassName("priskip");
+	for(index = 0; index < buttons.length; index++)
+	{
+		var button = buttons[index];
+                if (!button.disabled)
+			addClickHandler(button);
+	}
+	var button = document.getElementById('setallhigh');
+	if (!button.disabled) {
+		button.addEventListener("click", function() {
+			setallhigh();
+			event.preventDefault();
+	        });
+	}
+	button = document.getElementById('setallnorm');
+	if (!button.disabled) {
+		button.addEventListener("click", function() {
+			setallnorm();
+			event.preventDefault();
+	        });
+	}
+	button = document.getElementById('setallskip');
+	if (!button.disabled) {
+		button.addEventListener("click", function() {
+			setallskip();
+			event.preventDefault();
+	        });
+	}
 }
 
 const priorityclicked=()=>{
@@ -62,6 +105,13 @@ const setallskip=()=>{
 	form.savepri.className = 'accept';
 }
 
+function addClickHandler(elem)
+{
+	elem.addEventListener("click", function() {
+		priorityclicked();
+        });
+}
+
 document.addEventListener("DOMContentLoaded", function() {
     setupbuttons();
 }, true);