zzz/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Crypto: Verify RSA sigs after signing

Browse Source 
to detect corrupted sigs and prevent RSA fault attack
ref: https://eprint.iacr.org/2023/1711.pdf
This commit is contained in:
zzz
2024-01-29 08:09:57 -05:00
parent 2482b1dc18
commit 777da8dfb1
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
core/java/src/net/i2p/crypto/DSAEngine.java
View File

@@ -633,6 +633,17 @@ public final class DSAEngine {
jsig.initSign(privKey, _context.random());
jsig.update(data, offset, len);
sigbytes = jsig.sign();
if (type.getBaseAlgorithm() == SigAlgo.RSA) {
// verify to prevent corrupted sig key factoring
// (RSA fault attack) https://eprint.iacr.org/2023/1711.pdf
SigningPrivateKey priv = SigUtil.fromJavaKey(privKey, type);
SigningPublicKey pub = priv.toPublic();
PublicKey pubKey = SigUtil.toJavaKey(pub);
jsig.initVerify(pubKey);
jsig.update(data, offset, len);
if (!jsig.verify(sigbytes))
throw new GeneralSecurityException("Verify of RSA Signature failed");
}
}
return SigUtil.fromJavaSig(sigbytes, type);
}
@@ -681,6 +692,17 @@ public final class DSAEngine {
jsig.initSign(privKey, _context.random());
jsig.update(hash.getData());
sigbytes = jsig.sign();
if (type.getBaseAlgorithm() == SigAlgo.RSA) {
// verify to prevent corrupted sig key factoring
// (RSA fault attack) https://eprint.iacr.org/2023/1711.pdf
SigningPrivateKey priv = SigUtil.fromJavaKey(privKey, type);
SigningPublicKey pub = priv.toPublic();
PublicKey pubKey = SigUtil.toJavaKey(pub);
jsig.initVerify(pubKey);
jsig.update(hash.getData());
if (!jsig.verify(sigbytes))
throw new GeneralSecurityException("Verify of RSA Signature failed");
}
}
return SigUtil.fromJavaSig(sigbytes, type);
}