zzz/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup buf.append(s.substring(a, b)) -> buf.append(s, a, b)

Browse Source 
all over, for object churn
This commit is contained in:
zzz
2023-01-31 07:31:02 -05:00
parent 07a796bcf6
commit 1e28557ce2
16 changed files with 25 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/routerconsole/java/src/net/i2p/router/web/helpers/FileDumpHelper.java
View File

@@ -147,7 +147,7 @@ public class FileDumpHelper extends HelperBase {
buf.append("<br>");
if (linkrev)
buf.append("<a href=\"").append(LINK).append(s).append("\">");
buf.append("<span class=\"revision\"><tt>").append(s.substring(0, 20)).append("</tt>" +
buf.append("<span class=\"revision\"><tt>").append(s, 0, 20).append("</tt>" +
"<br>" +
"<tt>").append(s.substring(20)).append("</tt></span>");
if (linkrev)

14
apps/routerconsole/java/src/net/i2p/router/web/helpers/NetDbRenderer.java
View File

@@ -730,7 +730,7 @@ class NetDbRenderer {
buf.append(" <b>(").append(_t("Encrypted")).append(")</b>");
buf.append("</th>");
if (_context.clientManager().isLocal(key)) {
buf.append("<th><a href=\"tunnels#" + key.toBase64().substring(0,4) + "\">" + _t("Local") + "</a> ");
buf.append("<th><a href=\"tunnels#").append(key.toBase64(), 0, 4).append("\">").append(_t("Local")).append("</a> ");
boolean unpublished = ! _context.clientManager().shouldPublishLeaseSet(key);
if (unpublished)
buf.append("<b>").append(_t("Unpublished")).append("</b> ");
@@ -739,7 +739,7 @@ class NetDbRenderer {
if (in != null && in.getDestinationNickname() != null)
buf.append(DataHelper.escapeHTML(in.getDestinationNickname()));
else
buf.append(dest.toBase64().substring(0, 6));
buf.append(dest.toBase64(), 0, 6);
buf.append("</th></tr>\n");
// we don't show a b32 or addressbook links if encrypted
if (type != DatabaseEntry.KEY_TYPE_ENCRYPTED_LS2) {
@@ -772,7 +772,7 @@ class NetDbRenderer {
String b32 = key.toBase32();
buf.append("<code>");
if (dest != null)
buf.append(dest.toBase64().substring(0, 6));
buf.append(dest.toBase64(), 0, 6);
else
buf.append("n/a");
buf.append("</code></th>" +
@@ -839,7 +839,7 @@ class NetDbRenderer {
}
if (type == DatabaseEntry.KEY_TYPE_LEASESET) {
buf.append("</td></tr>\n<tr><td colspan=\"2\"><b>Encryption Key:</b> ELGAMAL_2048 ")
.append(ls.getEncryptionKey().toBase64().substring(0, 20))
.append(ls.getEncryptionKey().toBase64(), 0, 20)
.append("&hellip;");
} else if (type == DatabaseEntry.KEY_TYPE_LS2) {
LeaseSet2 ls2 = (LeaseSet2) ls;
@@ -851,7 +851,7 @@ class NetDbRenderer {
else
buf.append("Unsupported type ").append(pk.getUnknownTypeCode());
buf.append(' ')
.append(pk.toBase64().substring(0, 20))
.append(pk.toBase64(), 0, 20)
.append("&hellip;");
}
}
@@ -1183,7 +1183,7 @@ class NetDbRenderer {
private void renderRouterInfo(StringBuilder buf, RouterInfo info, boolean isUs, boolean full) {
String hash = info.getIdentity().getHash().toBase64();
buf.append("<table class=\"netdbentry\">" +
"<tr id=\"").append(hash.substring(0, 6)).append("\"><th colspan=\"2\"");
"<tr id=\"").append(hash, 0, 6).append("\"><th colspan=\"2\"");
if (isUs) {
buf.append(" id=\"our-info\"><b>").append(_t("Our Router Identity")).append(":</b> <code>")
.append(hash).append("</code></th><th>");
@@ -1199,7 +1199,7 @@ class NetDbRenderer {
}
if (!full) {
buf.append("<a title=\"").append(_t("View extended router info"))
.append("\" class=\"viewfullentry\" href=\"netdb?r=").append(hash.substring(0, 6))
.append("\" class=\"viewfullentry\" href=\"netdb?r=").append(hash, 0, 6)
.append("\" >[").append(_t("Full entry")).append("]</a>");
}
}

2
apps/routerconsole/java/src/net/i2p/router/web/helpers/SummaryHelper.java
View File

@@ -635,7 +635,7 @@ public class SummaryHelper extends HelperBase {
buf.append("server.png\" alt=\"Server\" title=\"").append(_t("Hidden Service")).append("\">");
else
buf.append("client.png\" alt=\"Client\" title=\"").append(_t("Client")).append("\">");
buf.append("</td><td align=\"left\"><b><a href=\"tunnels#").append(h.toBase64().substring(0,4));
buf.append("</td><td align=\"left\"><b><a href=\"tunnels#").append(h.toBase64(), 0, 4);
buf.append("\" target=\"_top\" title=\"").append(_t("Show tunnels")).append("\">");
// Increase permitted max length of tunnel name & handle overflow with css
if (name.length() <= 32)