Revert ee06171a2f

They were due to an autoformatting of the editor and not necessary for the merge request.

apps/routerconsole/jsp/confignet.jsp

@@ -46,7 +46,7 @@
   </td>
  </tr>
  <tr>
-  <th id="upnpconfig"><%=intl._t("UPnP Configuration")%>&nbsp;<a href="peers?tx=upnp">[<%=intl._t("UPnP Status")%>]</a></th>
+  <th id="upnpconfig"><%=intl._t("UPnP Configuration")%>&nbsp;<a href="peers#upnp">[<%=intl._t("UPnP Status")%>]</a></th>
  </tr>
  <tr>
   <td>

core/java/src/net/i2p/util/Addresses.java

@@ -122,9 +122,10 @@ public abstract class Addresses {
      *
      *  Warning, very slow on Windows, appx. 200ms + 50ms/interface
      *
+     *  @return a sorted set of all addresses including wildcard
      *  @param includeLocal whether to include local
      *  @param includeIPv6 whether to include IPV6
-     *  @return a sorted set of all addresses including wildcard
+     *  @return a Set of all addresses
      *  @since 0.8.3
      */
     public static SortedSet<String> getAddresses(boolean includeLocal, boolean includeIPv6) {
@@ -140,10 +141,11 @@ public abstract class Addresses {
      *
      *  Warning, very slow on Windows, appx. 200ms + 50ms/interface
      *
+     *  @return a sorted set of all addresses
      *  @param includeSiteLocal whether to include private like 192.168.x.x
      *  @param includeLoopbackAndWildcard whether to include 127.x.x.x and 0.0.0.0
      *  @param includeIPv6 whether to include IPV6
-     *  @return a sorted set of all addresses
+     *  @return a Set of all addresses
      *  @since 0.9.4
      */
     public static SortedSet<String> getAddresses(boolean includeSiteLocal,
@@ -161,11 +163,12 @@ public abstract class Addresses {
      *
      *  Warning, very slow on Windows, appx. 200ms + 50ms/interface
      *
+     *  @return a sorted set of all addresses
      *  @param includeSiteLocal whether to include private like 192.168.x.x
      *  @param includeLoopbackAndWildcard whether to include 127.x.x.x and 0.0.0.0
      *  @param includeIPv6 whether to include IPV6
      *  @param includeIPv6Temporary whether to include IPV6 temporary addresses
-     *  @return a sorted set of all addresses
+     *  @return a Set of all addresses
      *  @since 0.9.46
      */
     public static SortedSet<String> getAddresses(boolean includeSiteLocal,
@@ -399,7 +402,7 @@ public abstract class Addresses {
      *  @since 0.9.3
      */
     public static byte[] getIP(String host) {
-        if (host == null || host.isEmpty())
+        if (host == null)
             return null;
         byte[] rv;
         synchronized (_IPAddress) {

core/java/test/junit/net/i2p/TestContext.java

@@ -0,0 +1,17 @@
+package net.i2p;
+
+public class TestContext extends I2PAppContext {
+
+    public TestContext() {
+        TestContext.setGlobalContext(this);
+    }
+
+    /**
+     * Allows overriding the existing I2PAppContext with a test context who's fields we may mock as we like
+     *
+     * @param ctx Our test context to replace the global context with
+     */
+    public static void setGlobalContext(TestContext ctx){
+        _globalAppContext = ctx;
+    }
+}

core/java/test/junit/net/i2p/util/AddressesTest.java

@@ -1,145 +0,0 @@
-package net.i2p.util;
-
-import org.junit.Test;
-
-import java.net.Inet6Address;
-import java.net.UnknownHostException;
-
-import static org.junit.Assert.*;
-
-/**
- * @since 0.9.49
- */
-public class AddressesTest {
-
-    @Test
-    public void getIPNull() {
-        assertNull(Addresses.getIP(null));
-    }
-
-    @Test
-    public void getIPEmptyString() {
-        assertNull(Addresses.getIP(""));
-    }
-
-    @Test
-    public void getIPWithIPString() {
-        byte[] address = {
-            1, 2, 3, 4
-        };
-        assertArrayEquals(address, Addresses.getIP("1.2.3.4"));
-    }
-
-    @Test
-    public void getPort() {
-        assertEquals(80, Addresses.getPort("80"));
-    }
-
-    @Test
-    public void getPort__invalidPort() {
-        String[] strings = {
-            "",
-            " 80",
-            "-100",
-            "a",
-            "99999",
-            null
-        };
-        for (String string : strings) {
-            assertEquals(0, Addresses.getPort(string));
-        }
-    }
-
-    @Test
-    public void isIPAddress() {
-        assertTrue(Addresses.isIPAddress("127.0.0.1"));
-        assertTrue(Addresses.isIPAddress("::1"));
-    }
-
-    @Test
-    public void isIPv6Address() {
-        assertTrue(Addresses.isIPv6Address("::1"));
-        assertFalse(Addresses.isIPv6Address(""));
-    }
-
-    @Test
-    public void isIPv4Address() {
-        assertTrue(Addresses.isIPv4Address("127.0.0.1"));
-        assertFalse(Addresses.isIPv4Address(""));
-    }
-
-    /**
-     * Should always return false when the address isn't in the cache
-     */
-    @Test
-    public void isDynamic() throws UnknownHostException {
-        String host = "localhost";
-        byte[] address = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1};
-        assertFalse(Addresses.isDynamic((Inet6Address) Inet6Address.getByAddress(host, address)));
-    }
-
-    /**
-     * Should always return false when the address isn't in the cache
-     */
-    @Test
-    public void isDeprecated() throws UnknownHostException {
-        String host = "localhost";
-        byte[] address = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1};
-        assertFalse(Addresses.isDeprecated((Inet6Address) Inet6Address.getByAddress(host, address)));
-    }
-
-    @Test
-    public void testToString() {
-        byte[] address = {127, 0, 0, 1};
-        assertEquals("127.0.0.1", Addresses.toString(address));
-    }
-
-    @Test
-    public void testToString__ipv4withPort() {
-        byte[] address = {127, 0, 0, 1};
-        assertEquals("127.0.0.1:80", Addresses.toString(address, 80));
-    }
-
-    @Test
-    public void testToString__ipv6withPort() {
-        byte[] address = {
-            0, 0, 0, 0,
-            0, 0, 0, 0,
-            0, 0, 0, 0,
-            0, 0, 0, 1,
-        };
-        assertEquals("[0:0:0:0:0:0:0:1]:80", Addresses.toString(address, 80));
-    }
-
-    @Test
-    public void testToString__null() {
-        assertEquals("null", Addresses.toString(null));
-    }
-
-    @Test
-    public void testToString__nullWithPort() {
-        assertEquals("null:80", Addresses.toString(null, 80));
-    }
-
-    @Test
-    public void testToString__badLength() {
-        byte[] address = {1};
-        assertTrue(Addresses.toString(address).startsWith("bad IP length"));
-    }
-
-    @Test
-    public void testToString__badLengthWithPort() {
-        byte[] address = {1};
-        String string = Addresses.toString(address, 80);
-        String expectedStartString = "(bad IP length";
-        assertTrue(
-            String.format("%s doesn't start with: %s", string, expectedStartString),
-            string.startsWith(expectedStartString)
-        );
-        String expectedEndString = "80";
-        assertTrue(
-            String.format("%s doesn't end with: %s", string, expectedEndString),
-            string.endsWith(expectedEndString)
-        );
-    }
-}

core/java/test/junit/net/i2p/util/ConvertToHashMockTest.java

@@ -0,0 +1,51 @@
+package net.i2p.util;
+
+import net.i2p.TestContext;
+import net.i2p.client.naming.NamingService;
+import net.i2p.data.Destination;
+import net.i2p.data.Hash;
+import org.junit.AfterClass;
+import org.junit.Before;
+
+import org.junit.Test;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import static org.mockito.Mockito.*;
+import static org.junit.Assert.*;
+
+public class ConvertToHashMockTest{
+
+    @Mock private NamingService namingService;
+    @Mock private Destination destination;
+    @Mock private Hash hash;
+
+    @InjectMocks TestContext testContext;
+
+    @Before
+    public void before() {
+        MockitoAnnotations.initMocks(this);
+    }
+
+    /**
+     * Reset the global context after all tests in the class are done.
+     *
+     * We would otherwise pollute the other tests that depend on I2PAppContext
+     */
+    @AfterClass
+    public static void afterClass(){
+        TestContext.setGlobalContext(null);
+    }
+
+    @Test
+    public void testMockedDestination() {
+        when(namingService.lookup("zzz.i2p")).thenReturn(destination);
+        when(destination.calculateHash()).thenReturn(hash);
+
+        assertSame(hash, ConvertToHash.getHash("zzz.i2p"));
+
+        verify(namingService).lookup("zzz.i2p");
+        verify(destination).calculateHash();
+    }
+}

core/java/test/junit/net/i2p/util/ConvertToHashTest.java

@@ -1,69 +0,0 @@
-package net.i2p.util;
-
-import net.i2p.data.Hash;
-import org.junit.Test;
-
-import static org.junit.Assert.*;
-
-public class ConvertToHashTest {
-    private static final String zzzDotI2pBase32Hash = "lhbd7ojcaiofbfku7ixh47qj537g572zmhdc4oilvugzxdpdghua";
-    private static final String zzzDotI2pBase64Hash = "WcI~uSICHFCVVPoufn4J7v5u~1lhxi45C60Nm43jMeg=";
-    private static final String zzzDotI2pBase64Dest = "GKapJ8koUcBj~jmQzHsTYxDg2tpfWj0xjQTzd8BhfC9c3OS5fwPBNajgF-eOD6eCjFTqTlorlh7Hnd8kXj1qblUGXT-tDoR9~YV8dmXl51cJn9MVTRrEqRWSJVXbUUz9t5Po6Xa247Vr0sJn27R4KoKP8QVj1GuH6dB3b6wTPbOamC3dkO18vkQkfZWUdRMDXk0d8AdjB0E0864nOT~J9Fpnd2pQE5uoFT6P0DqtQR2jsFvf9ME61aqLvKPPWpkgdn4z6Zkm-NJOcDz2Nv8Si7hli94E9SghMYRsdjU-knObKvxiagn84FIwcOpepxuG~kFXdD5NfsH0v6Uri3usE3XWD7Pw6P8qVYF39jUIq4OiNMwPnNYzy2N4mDMQdsdHO3LUVh~DEppOy9AAmEoHDjjJxt2BFBbGxfdpZCpENkwvmZeYUyNCCzASqTOOlNzdpne8cuesn3NDXIpNnqEE6Oe5Qm5YOJykrX~Vx~cFFT3QzDGkIjjxlFBsjUJyYkFjBQAEAAcAAA==";
-
-
-    @Test
-    public void getHashNullPeer() {
-        assertNull(ConvertToHash.getHash(null));
-    }
-
-    @Test
-    public void getHashB64() {
-        Hash hash = ConvertToHash.getHash(zzzDotI2pBase64Hash);
-        assertNotNull(hash);
-        assertEquals(hash.toBase64(), zzzDotI2pBase64Hash);
-    }
-
-    @Test
-    public void getHashB64DotI2P() {
-        Hash hash = ConvertToHash.getHash(zzzDotI2pBase64Hash + ".i2p");
-        assertNotNull(hash);
-        assertEquals(hash.toBase64(), zzzDotI2pBase64Hash);
-    }
-
-    @Test
-    public void getHashDestinationB64() {
-        Hash hash = ConvertToHash.getHash(zzzDotI2pBase64Dest);
-        assertNotNull(hash);
-        assertEquals(hash.toBase64(), zzzDotI2pBase64Hash);
-    }
-
-    @Test
-    public void getHashDestinationB64DotI2P() {
-        Hash hash = ConvertToHash.getHash(zzzDotI2pBase64Dest + ".i2p");
-        assertNotNull(hash);
-        assertEquals(hash.toBase64(), zzzDotI2pBase64Hash);
-    }
-
-    @Test
-    public void getHashB32() {
-        Hash hash = ConvertToHash.getHash(zzzDotI2pBase32Hash);
-        assertNotNull(hash);
-        assertEquals(hash.toBase32(), zzzDotI2pBase32Hash + ".b32.i2p");
-    }
-
-    @Test
-    public void getHashB32DotI2P() {
-        String zzzB32I2P = zzzDotI2pBase32Hash + ".b32.i2p";
-        Hash hash = ConvertToHash.getHash(zzzB32I2P);
-        assertNotNull(hash);
-        assertEquals(hash.toBase32(), zzzB32I2P);
-    }
-
-    /**
-     * The case where a destination cannot be resolved at all
-     */
-    @Test
-    public void getHashResolveDestinationFail() {
-        assertNull(ConvertToHash.getHash("unknown.i2p"));
-    }
-}

history.txt

@@ -1,22 +1,3 @@
-2021-01-20 zzz
- * Console: Fix link to UPnP status
- * SSU: Fix deadlock with router restart
-
-2021-01-14 zzz
- * Router:
-   - Change default encryption type to ECIES-X25519 (proposal 156)
-   - Move Sybil subsystem from console to router
-   - Limit max addresses in RI
-
-2021-01-13 zzz
- * Jetty: Fix URI in request logs
-
-2021-01-12 zzz
- * i2psnark: Don't decrement downloaded counter after receiving bad piece
-
-2021-01-11 zzz
- * Console: Delete rrd files for no-longer-configured stats at startup
-
 2021-01-08 zzz
  * i2ptunnel: Disable shared clients (DSA) (part 2)
  * SSU: Fix bandwidth estimator deadlock (ticket #2798)

router/java/src/net/i2p/router/RouterVersion.java

@@ -18,7 +18,7 @@ public class RouterVersion {
     /** deprecated */
     public final static String ID = "Monotone";
     public final static String VERSION = CoreVersion.VERSION;
-    public final static long BUILD = 14;
+    public final static long BUILD = 13;
 
     /** for example "-test" */
     public final static String EXTRA = "";

router/java/src/net/i2p/router/transport/udp/UDPTransport.java

@@ -2455,7 +2455,7 @@ public class UDPTransport extends TransportImpl implements TimedWeightedPriority
                 // warning, this calls back into us with allowRebuildRouterInfo = false,
                 // via CSFI.createAddresses->TM.getAddresses()->updateAddress()->REA
                 if (allowRebuildRouterInfo)
-                    rebuildRouterInfo();
+                    _context.router().rebuildRouterInfo();
             } else {
                 addr = null;
             }
@@ -2510,35 +2510,11 @@ public class UDPTransport extends TransportImpl implements TimedWeightedPriority
                 // warning, this calls back into us with allowRebuildRouterInfo = false,
                 // via CSFI.createAddresses->TM.getAddresses()->updateAddress()->REA
                 if (allowRebuildRouterInfo)
-                    rebuildRouterInfo();
+                    _context.router().rebuildRouterInfo();
             }
         }
     }
 
-    /**
-     *  Avoid deadlocks part 999
-     *  @since 0.9.49
-     */
-    private void rebuildRouterInfo() {
-        (new RebuildEvent()).schedule(0);
-    }
-
-    /**
-     *  @since 0.9.49
-     */
-    private class RebuildEvent extends SimpleTimer2.TimedEvent {
-        /**
-         *  Caller must schedule
-         */
-        public RebuildEvent() {
-            super(_context.simpleTimer2());
-        }
-        public void timeReached() {
-            _context.router().rebuildRouterInfo(true);
-        }
-    }
-
-
     /**
      *  Simple fetch of stored IP and port, since
      *  we don't put them in the real, published RouterAddress anymore