I2P_Developers/i2p.firefox
3
0
Fork 1
Code Issues 14 Pull Requests Packages Projects Releases Wiki Activity

Check return value of renameTo, if false throw an IOException.

Browse Source
This commit is contained in:
idk
2021-08-18 14:57:30 -04:00
parent 1b35c8dc8b
commit 8aefcff4b1
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
java/net/i2p/router/WindowsUpdatePostProcessor.java
View File

@@ -55,12 +55,7 @@ public class WindowsUpdatePostProcessor implements UpdatePostProcessor {
return; return;
} }
try { this.positionedFile = moveUpdateInstaller(file);
this.positionedFile = moveUpdateInstaller(file);
} catch(IOException ioe) {
_log.error("Error positioning update installer", ioe);
return;
}
this.version = version; this.version = version;
if (!hook.compareAndSet(false,true)) { if (!hook.compareAndSet(false,true)) {
@@ -76,12 +71,14 @@ public class WindowsUpdatePostProcessor implements UpdatePostProcessor {
private File moveUpdateInstaller(File file) throws IOException { private File moveUpdateInstaller(File file) throws IOException {
RouterContext i2pContext = i2pRouter.getContext(); RouterContext i2pContext = i2pRouter.getContext();
if (i2pContext != null) { if (i2pContext != null) {
File appDir = i2pContext.getConfigDir();
File newFile = new File(workDir(), file.getName()); File newFile = new File(workDir(), file.getName());
file.renameTo(newFile); boolean renamedStatus = file.renameTo(newFile);
return newFile; if (renamedStatus)
return newFile;
else
throw new IOException("WindowsUpdatePostProcesssor unable to move file to working directory, update will fail");
} }
return null; throw new IOException("Router context not available to WindowsUpdatePostProcesssor, unable to find working directory, update will fail");
} }
private File workDir() throws IOException{ private File workDir() throws IOException{