Review "about" popup #13

Closed
opened 2025-04-21 14:44:33 -04:00 by idk · 3 comments
Owner

1.6.0: The "About" popup contains a call for donations and links to donate page on website, but you recently removed that page. Review and adjust the popup text as necessary.

1.6.0: The "About" popup contains a call for donations and links to donate page on website, but you recently removed that page. Review and adjust the popup text as necessary.
idk self-assigned this 2025-04-21 14:44:33 -04:00
idk closed this issue 2025-04-21 14:44:33 -04:00
Author
Owner

It appears that the about popup was changed, but this issue was not closed. @idk if you're done, please close

It appears that the about popup was changed, but this issue was not closed. @idk if you're done, please close
Author
Owner

agreed, clearly this is minor

agreed, clearly this is minor
Author
Owner

Ack, will go over it again today. Probably won't do another release for this one, I did the release for the other because of the warning in the play console about zip path traversal. We weren't vulnerable because we only unzip our own zip files(certificates_zip) and not arbitrary ones from user input, but we were triggering the automated security checks and that triggers a manual review and that slows releases down and makes a hassle, so taking care of it yesterday keeps that to a minimum.

Ack, will go over it again today. Probably won't do another release for this one, I did the release for the other because of the warning in the play console about zip path traversal. We weren't vulnerable because we only unzip our own zip files(certificates_zip) and not arbitrary ones from user input, but we were triggering the automated security checks and that triggers a manual review and that slows releases down and makes a hassle, so taking care of it yesterday keeps that to a minimum.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: I2P_Developers/i2p.android.base#13
No description provided.