Findbugs in imported core code

2013-11-20 09:15:12 +00:00
parent 796dbc5d2e
commit a7a7e96188
2 changed files with 14 additions and 6 deletions
--- a/core/java/src/gnu/crypto/hash/Sha256Standalone.java
+++ b/core/java/src/gnu/crypto/hash/Sha256Standalone.java
@@ -95,7 +95,7 @@ public class Sha256Standalone extends BaseHashStandalone {
   private static final int[] w = new int[64];

   /** caches the result of the correctness test, once executed. */
-   private static Boolean valid;
+   private static volatile Boolean valid;

   /** 256-bit interim result. */
   private int h0, h1, h2, h3, h4, h5, h6, h7;
@@ -218,7 +218,7 @@ public class Sha256Standalone extends BaseHashStandalone {
         md.update((byte) 0x62); // b
         md.update((byte) 0x63); // c
         String result = "broken"; //Util.toString(md.digest());
-         valid = new Boolean(DIGEST0.equals(result));
+         valid = Boolean.valueOf(DIGEST0.equals(result));
      }

      return valid.booleanValue();