javadoc, final, private, volatile

core/java/src/net/i2p/client/I2PClient.java

@@ -21,6 +21,9 @@ import net.i2p.data.Destination;
 /**
  * Define the standard means of interacting with the I2P system
  *
+ * An I2PClient contains no state, it is just a facility for creating private key files
+ * and generating sesssions from existing private key files.
+ *
  * @author jrandom
  */
 public interface I2PClient {

core/java/src/net/i2p/client/I2PClientImpl.java

@@ -25,14 +25,18 @@ import net.i2p.data.SigningPrivateKey;
 import net.i2p.data.SigningPublicKey;
 
 /**
- * Base client implementation
+ * Base client implementation.
+ * An I2PClient contains no state, it is just a facility for creating private key files
+ * and generating sesssions from existing private key files.
  *
  * @author jrandom
  */
 class I2PClientImpl implements I2PClient {
 
     /**
-     * Create the destination with a null payload
+     * Create the destination with a null payload.
+     * This is not bound to the I2PClient, you must supply the data back again
+     * in createSession().
      *
      * @param destKeyStream location to write out the destination, PrivateKey, and SigningPrivateKey,
      *                      format is specified in {@link net.i2p.data.PrivateKeyFile PrivateKeyFile}

core/java/src/net/i2p/client/I2PSessionImpl.java

@@ -515,9 +515,9 @@ abstract class I2PSessionImpl implements I2PSession, I2CPMessageReader.I2CPMessa
      *  Needs work.
      */
     protected class AvailabilityNotifier implements Runnable {
-        private List _pendingIds;
-        private List _pendingSizes;
-        private boolean _alive;
+        private final List _pendingIds;
+        private final List _pendingSizes;
+        private volatile boolean _alive;
  
         public AvailabilityNotifier() {
             _pendingIds = new ArrayList(2);