diff --git a/router/java/src/net/i2p/router/message/GarlicMessageHandler.java b/router/java/src/net/i2p/router/message/GarlicMessageHandler.java index e065b3a24..c44ec2f05 100644 --- a/router/java/src/net/i2p/router/message/GarlicMessageHandler.java +++ b/router/java/src/net/i2p/router/message/GarlicMessageHandler.java @@ -19,9 +19,11 @@ import net.i2p.router.RouterContext; /** * HandlerJobBuilder to build jobs to handle GarlicMessages * - * This is essentially unused, as InNetMessagePool short circuits tunnel messages, - * and the garlics are handled in InboundMessageDistributor. - * Unless we get a garlic message not down a tunnel? + * This is the handler for garlic message not received down a tunnel, which is the + * case for floodfills receiving netdb messages. + * It is not the handler for garlic messages received down a tunnel, + * as InNetMessagePool short circuits tunnel messages, + * and those garlic messages are handled in InboundMessageDistributor. */ public class GarlicMessageHandler implements HandlerJobBuilder { private final RouterContext _context; diff --git a/router/java/src/net/i2p/router/message/HandleGarlicMessageJob.java b/router/java/src/net/i2p/router/message/HandleGarlicMessageJob.java index 4fd5342d5..6dbff9678 100644 --- a/router/java/src/net/i2p/router/message/HandleGarlicMessageJob.java +++ b/router/java/src/net/i2p/router/message/HandleGarlicMessageJob.java @@ -25,9 +25,11 @@ import net.i2p.util.Log; * as if they arrived locally. Other instructions are not yet implemented (but * need to be. soon) * - * This is essentially unused, as InNetMessagePool short circuits tunnel messages, - * and the garlics are handled in InboundMessageDistributor. - * Unless we get a garlic message not down a tunnel? + * This is the handler for garlic message not received down a tunnel, which is the + * case for floodfills receiving netdb messages. + * It is not the handler for garlic messages received down a tunnel, + * as InNetMessagePool short circuits tunnel messages, + * and those garlic messages are handled in InboundMessageDistributor. */ class HandleGarlicMessageJob extends JobImpl implements GarlicMessageReceiver.CloveReceiver { private final Log _log; @@ -49,8 +51,8 @@ class HandleGarlicMessageJob extends JobImpl implements GarlicMessageReceiver.Cl super(context); _log = context.logManager().getLog(HandleGarlicMessageJob.class); getContext().statManager().createRateStat("crypto.garlic.decryptFail", "How often garlic messages are undecryptable", "Encryption", new long[] { 5*60*1000, 60*60*1000, 24*60*60*1000 }); - if (_log.shouldLog(Log.WARN)) - _log.warn("Garlic Message not down a tunnel??? from [" + from + "]", new Exception("I did it")); + if (_log.shouldLog(Log.DEBUG)) + _log.debug("Garlic Message not down a tunnel from [" + from + "]"); _message = msg; //_from = from; //_fromHash = fromHash;