diff --git a/apps/i2psnark/resources/js/configui.js b/apps/i2psnark/resources/js/configui.js index 336068313..e1fa1328c 100644 --- a/apps/i2psnark/resources/js/configui.js +++ b/apps/i2psnark/resources/js/configui.js @@ -4,8 +4,8 @@ // as a formal dedication to the public domain and in circumstances where // a public domain is not usable. -var oldTheme = "ubergine"; -var change = false; +var __i2psnark_oldTheme = "ubergine"; +var __i2psnark_change = false; function swapStyleSheet(theme) { // https://stackoverflow.com/questions/14292997/changing-style-sheet-javascript @@ -17,13 +17,13 @@ function initThemeSwitcher() { if (theme == null) { return; } - oldtheme = theme.value; + __i2psnark_oldtheme = theme.value; theme.onclick = function() { - if (change) { + if (__i2psnark_change) { swapStyleSheet(theme.value); } else { // skip the first click to avoid the flash - change = true; + __i2psnark_change = true; } } } diff --git a/apps/i2psnark/resources/js/folder.js b/apps/i2psnark/resources/js/folder.js index 0fe1351aa..022fa4879 100644 --- a/apps/i2psnark/resources/js/folder.js +++ b/apps/i2psnark/resources/js/folder.js @@ -6,21 +6,21 @@ const setupbuttons=()=>{ if ( sp ) updatesetallbuttons(), sp.disabled = true, sp.className = 'disabled'; var buttons = document.getElementsByClassName("prihigh"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; if (!button.disabled) addClickHandler(button); } buttons = document.getElementsByClassName("prinorm"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; if (!button.disabled) addClickHandler(button); } buttons = document.getElementsByClassName("priskip"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; if (!button.disabled) @@ -55,9 +55,9 @@ const priorityclicked=()=>{ } const updatesetallbuttons=()=>{ - let notNorm = true, notHigh = true, notSkip = true, i = 0, len, ele, elems = document.forms[0].elements; - for( len = elems.length ; i < len && (notNorm || notHigh || notSkip) ; ) { - ele = elems[i++]; + let notNorm = true, notHigh = true, notSkip = true, i = 0, elems = document.forms[0].elements; + for (var len = elems.length ; i < len && (notNorm || notHigh || notSkip) ; ) { + var ele = elems[i++]; if (ele.type == 'radio' && !ele.checked) { if (ele.className == 'prinorm') notNorm = false; else if (ele.className == 'prihigh') notHigh = false; @@ -70,9 +70,9 @@ const updatesetallbuttons=()=>{ } const setallnorm=()=>{ - let i = 0, ele, elems, len, form = document.forms[0]; - for ( elems = form.elements, len = elems.length ; i < len ; ) { - ele = elems[i++]; + let i = 0, form = document.forms[0]; + for (var elems = form.elements, len = elems.length ; i < len ; ) { + var ele = elems[i++]; if (ele.type == 'radio' && ele.className === 'prinorm') ele.checked = true; } document.getElementById('setallnorm').className = 'controld'; @@ -83,9 +83,9 @@ const setallnorm=()=>{ } const setallhigh=()=>{ - let i = 0, len, ele, elems, form = document.forms[0]; - for( elems = form.elements, len = elems.length; i < len ; ) { - ele = elems[i++]; + let i = 0, form = document.forms[0]; + for (var elems = form.elements, len = elems.length ; i < len ; ) { + var ele = elems[i++]; if (ele.type == 'radio' && ele.className === 'prihigh') ele.checked = true; } document.getElementById('setallnorm').className = 'control'; @@ -96,9 +96,9 @@ const setallhigh=()=>{ } const setallskip=()=>{ - let i = 0, len, ele, elems, form = document.forms[0]; - for( elems = form.elements, len = elems.length; i < len ; ) { - ele = elems[i++]; + let i = 0, form = document.forms[0]; + for (var elems = form.elements, len = elems.length ; i < len ; ) { + var ele = elems[i++]; if (ele.type == 'radio' && ele.className === 'priskip') ele.checked = true; } document.getElementById('setallnorm').className = 'control'; diff --git a/apps/i2ptunnel/jsp/js/copy.js b/apps/i2ptunnel/jsp/js/copy.js index a826d1ee2..74b9e3eaf 100644 --- a/apps/i2ptunnel/jsp/js/copy.js +++ b/apps/i2ptunnel/jsp/js/copy.js @@ -3,7 +3,7 @@ function initCopyLink() { var buttons = document.getElementsByClassName("tunnelHostnameCopy"); - for (index = 0; index < buttons.length; index++) { + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addClickHandler(button); } diff --git a/apps/i2ptunnel/jsp/js/delete.js b/apps/i2ptunnel/jsp/js/delete.js index ad8d9ef14..7e8ee5c89 100644 --- a/apps/i2ptunnel/jsp/js/delete.js +++ b/apps/i2ptunnel/jsp/js/delete.js @@ -4,7 +4,7 @@ function initDelete() { var buttons = document.getElementsByClassName("delete"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addClickHandler(button); diff --git a/apps/i2ptunnel/jsp/js/tableSlider.js b/apps/i2ptunnel/jsp/js/tableSlider.js index 31588c05b..04d401a14 100644 --- a/apps/i2ptunnel/jsp/js/tableSlider.js +++ b/apps/i2ptunnel/jsp/js/tableSlider.js @@ -3,9 +3,9 @@ function initTables() { -var hideableTables = document.querySelectorAll("table.tunnelConfig th"); + var hideableTables = document.querySelectorAll("table.tunnelConfig th"); -hideableTables.forEach(function(configTable) { + hideableTables.forEach(function(configTable) { function lookupTableRow() { for (var i = 0, row; (row = configTable.offsetParent.rows[i]); i++) { if (configTable.parentNode == row) { @@ -64,6 +64,7 @@ hideableTables.forEach(function(configTable) { iiframe.height = adjustHeight; } }; + showAllControls() for (var i = 0, row; (row = hideableTables[0].offsetParent.rows[i]); i++) { row.style.visibility = "visible"; diff --git a/apps/routerconsole/jsp/js/ajax.js b/apps/routerconsole/jsp/js/ajax.js index 37bf418a7..c21048df6 100644 --- a/apps/routerconsole/jsp/js/ajax.js +++ b/apps/routerconsole/jsp/js/ajax.js @@ -4,7 +4,7 @@ // as a formal dedication to the public domain and in circumstances where // a public domain is not usable. -var fails = 0; +var __ajax_fails = 0; /** * @@ -14,15 +14,15 @@ var fails = 0; function ajax(url, target, refresh) { // native XMLHttpRequest object if (window.XMLHttpRequest) { - req = new XMLHttpRequest(); - req.onreadystatechange = function() {ajaxDone(url, target, refresh);}; + var req = new XMLHttpRequest(); + req.onreadystatechange = function() {ajaxDone(req, url, target, refresh);}; req.open("GET", url, true); // IE https://www.jamesmaurer.com/ajax-refresh-problem-w-ie-not-refreshing.asp req.setRequestHeader("If-Modified-Since","Sat, 1 Jan 2000 00:00:00 GMT"); req.send(null); // IE/Windows ActiveX version } else if (window.ActiveXObject) { - req = new ActiveXObject("Microsoft.XMLDOM"); + var req = new ActiveXObject("Microsoft.XMLDOM"); if (req) { req.onreadystatechange = function() {ajaxDone(target);}; req.open("GET", url, true); @@ -38,18 +38,18 @@ function ajax(url, target, refresh) { * @param refresh as of 0.9.58, if less than or equal to zero, do not reschedule * */ -function ajaxDone(url, target, refresh) { +function ajaxDone(req, url, target, refresh) { // only if req is "loaded" if (req.readyState == 4) { // only if "OK" if (req.status == 200) { - fails = 0; - results = req.responseText; + __ajax_fails = 0; + const results = req.responseText; document.getElementById(target).innerHTML = results; //document.getElementsbyClassName("hideifdown").style.display="block"; - } else if (fails == 0) { + } else if (__ajax_fails == 0) { // avoid spurious message if cancelled by user action - fails++; + __ajax_fails++; } else { document.getElementById(target).innerHTML = failMessage; //document.getElementByClassName("hideifdown").style.display="none"; @@ -57,7 +57,7 @@ function ajaxDone(url, target, refresh) { // conditionally display graph so ajax call doesn't interfere with refreshGraph.js var graph = document.getElementById("sb_graphcontainer"); - if (graph) { + if (graph) { graph.style.backgroundImage = "url(/viewstat.jsp?stat=bw.combined&periodCount=20&width=220&height=50&hideLegend=true&hideGrid=true&time=" + new Date().getTime(); } diff --git a/apps/routerconsole/jsp/js/configclients.js b/apps/routerconsole/jsp/js/configclients.js index b6e8c99a7..4ffa5506b 100644 --- a/apps/routerconsole/jsp/js/configclients.js +++ b/apps/routerconsole/jsp/js/configclients.js @@ -7,7 +7,7 @@ function initConfigClients() { var buttons = document.getElementsByClassName("delete"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addCCClickHandler(button); diff --git a/apps/routerconsole/jsp/js/configstats.js b/apps/routerconsole/jsp/js/configstats.js index 92a8a0731..8de2c6b1b 100644 --- a/apps/routerconsole/jsp/js/configstats.js +++ b/apps/routerconsole/jsp/js/configstats.js @@ -4,11 +4,12 @@ // as a formal dedication to the public domain and in circumstances where // a public domain is not usable. +var __configstats_checkAll = false; + function initConfigStats() { - checkAll = false; var buttons = document.getElementsByClassName("script"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; // toggle-foo @@ -23,7 +24,7 @@ function addCSClickHandler(elem, category) function toggleAll(category) { var inputs = document.getElementsByTagName("input"); - for(index = 0; index < inputs.length; index++) + for (var index = 0; index < inputs.length; index++) { var classes = inputs[index].className.split(' '); for (var idx = 0; idx < classes.length; idx++) @@ -46,11 +47,11 @@ function toggleAll(category) // don't toggle this one continue; } - if (checkAll == false) + if (__configstats_checkAll == false) { inputs[index].checked = 1; } - else if (checkAll == true) + else if (__configstats_checkAll == true) { inputs[index].checked = 0; } @@ -58,13 +59,13 @@ function toggleAll(category) } if(category == '*') { - if (checkAll == false) + if (__configstats_checkAll == false) { - checkAll = true; + __configstats_checkAll = true; } - else if (checkAll == true) + else if (__configstats_checkAll == true) { - checkAll = false; + __configstats_checkAll = false; } } } diff --git a/apps/routerconsole/jsp/js/configui.js b/apps/routerconsole/jsp/js/configui.js index 59ab35c09..2cd7634ef 100644 --- a/apps/routerconsole/jsp/js/configui.js +++ b/apps/routerconsole/jsp/js/configui.js @@ -4,7 +4,7 @@ // as a formal dedication to the public domain and in circumstances where // a public domain is not usable. -var oldTheme = "light"; +var __configui_oldTheme = "light"; function swapStyleSheet(theme) { // https://stackoverflow.com/questions/14292997/changing-style-sheet-javascript @@ -18,7 +18,7 @@ function disableButtons(disabled) { } function resetStyleSheet() { - swapStyleSheet(oldTheme); + swapStyleSheet(__configui_oldTheme); document.getElementById("themeForm").reset(); disableButtons(true); } @@ -33,7 +33,7 @@ function initThemeSwitcher() { disableButtons(false); } if (dark.checked) { - oldTheme = "dark"; + __configui_oldTheme = "dark"; } var light = document.getElementById("light"); light.onclick = function() { diff --git a/apps/routerconsole/jsp/js/resetScroll.js b/apps/routerconsole/jsp/js/resetScroll.js index ecd68b16a..914176759 100644 --- a/apps/routerconsole/jsp/js/resetScroll.js +++ b/apps/routerconsole/jsp/js/resetScroll.js @@ -7,7 +7,7 @@ function initResetScroll() { var buttons = document.getElementsByClassName("resetScrollLeft"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addBlurHandler(button); diff --git a/apps/routerconsole/jsp/js/stats.js b/apps/routerconsole/jsp/js/stats.js index 200bcb13d..b6203b58c 100644 --- a/apps/routerconsole/jsp/js/stats.js +++ b/apps/routerconsole/jsp/js/stats.js @@ -7,7 +7,7 @@ function initStats() { var buttons = document.getElementsByClassName("onchange"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addSChangeHandler(button); diff --git a/apps/routerconsole/jsp/js/welcomeajax.js b/apps/routerconsole/jsp/js/welcomeajax.js index b4237e48e..928b90f1c 100644 --- a/apps/routerconsole/jsp/js/welcomeajax.js +++ b/apps/routerconsole/jsp/js/welcomeajax.js @@ -4,20 +4,20 @@ // as a formal dedication to the public domain and in circumstances where // a public domain is not usable. -var fails = 0; +var __welcome_fails = 0; function ajax(url, target, refresh) { // native XMLHttpRequest object if (window.XMLHttpRequest) { - req = new XMLHttpRequest(); - req.onreadystatechange = function() {ajaxDone(url, target, refresh);}; + var req = new XMLHttpRequest(); + req.onreadystatechange = function() {ajaxDone(req, url, target, refresh);}; req.open("GET", url, true); // IE https://www.jamesmaurer.com/ajax-refresh-problem-w-ie-not-refreshing.asp req.setRequestHeader("If-Modified-Since","Sat, 1 Jan 2000 00:00:00 GMT"); req.send(null); // IE/Windows ActiveX version } else if (window.ActiveXObject) { - req = new ActiveXObject("Microsoft.XMLDOM"); + var req = new ActiveXObject("Microsoft.XMLDOM"); if (req) { req.onreadystatechange = function() {ajaxDone(target);}; req.open("GET", url, true); @@ -28,7 +28,7 @@ function ajax(url, target, refresh) { } } -function ajaxDone(url, target, refresh) { +function ajaxDone(req, url, target, refresh) { // only if req is "loaded" if (req.readyState == 4) { var fail = false; @@ -37,7 +37,7 @@ function ajaxDone(url, target, refresh) { // only if "OK" if (req.status == 200) { // output 1 for complete, 0 + status string for in progress - fails = 0; + __welcome_fails = 0; var status; // IE doesn't support startsWith() if (req.responseText.indexOf("1") == 0) { @@ -51,9 +51,9 @@ function ajaxDone(url, target, refresh) { } document.getElementById("xhr2").innerHTML = status; document.getElementById(target).innerHTML = results; - } else if (fails == 0) { + } else if (__welcome_fails == 0) { // avoid spurious message if cancelled by user action - fails++; + __welcome_fails++; } else { document.getElementById(target).innerHTML = failMessage; running = false; diff --git a/apps/susidns/src/js/messages.js b/apps/susidns/src/js/messages.js index c3b036846..a5f10b45f 100644 --- a/apps/susidns/src/js/messages.js +++ b/apps/susidns/src/js/messages.js @@ -4,7 +4,7 @@ function HideMessages() { var hideableMessages = document.getElementsByClassName("messages"); if (hideableMessages.length > 0) { - for (key in hideableMessages) { + for (var key in hideableMessages) { if (hideableMessages[key] != null) { hideableMessages[key].remove() } @@ -60,8 +60,7 @@ function ToggleImportFormTableView() { function ToggleHowView(){ var pHow = document.getElementsByClassName("howitworks"); - var i; - for (i = 0; i < pHow.length; i++) { + for (var i = 0; i < pHow.length; i++) { pHow[i].classList.toggle("invisible"); } var idHow = document.getElementById("howitworks"); @@ -72,8 +71,7 @@ function ToggleHowView(){ function ToggleWhatView(){ var pWhat = document.getElementsByClassName("whatitis"); - var i; - for (i = 0; i < pWhat.length; i++) { + for (var i = 0; i < pWhat.length; i++) { pWhat[i].classList.toggle("invisible"); } var idWhat = document.getElementById("whatitis"); @@ -99,8 +97,7 @@ function initClickables() { var d = document.getElementById("emptybook"); if (d == null) { var x = document.getElementsByName("hostname"); - var i; - for (i = 0; i < x.length; i++) { + for (var i = 0; i < x.length; i++) { if (x[i].value == "") { var buttonView = document.getElementById("addnewaddrbutton"); if (buttonView != null) { diff --git a/apps/susimail/src/js/compose.js b/apps/susimail/src/js/compose.js index 8bad94829..2c5c09ced 100644 --- a/apps/susimail/src/js/compose.js +++ b/apps/susimail/src/js/compose.js @@ -1,12 +1,13 @@ /* @license http://www.gnu.org/licenses/gpl-2.0.html GPL-2.0 */ /* see also licenses/LICENSE-GPLv2.txt */ -let beforePopup = true; -window.addEventListener('beforeunload', (e)=>{if (beforePopup) e.returnValue=true;} ); +var __susimail_beforePopup = true; function initPopup() { + window.addEventListener('beforeunload', (e)=>{if (__susimail_beforePopup) e.returnValue=true;} ); + var buttons = document.getElementsByClassName("beforePopup"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addClickHandler5(button); @@ -16,7 +17,7 @@ function initPopup() { function addClickHandler5(elem) { elem.addEventListener("click", function() { - beforePopup = false; + __susimail_beforePopup = false; }); } diff --git a/apps/susimail/src/js/folder.js b/apps/susimail/src/js/folder.js index 0288a4602..7cc1e9ca1 100644 --- a/apps/susimail/src/js/folder.js +++ b/apps/susimail/src/js/folder.js @@ -3,19 +3,19 @@ function initButtons() { var buttons = document.getElementsByClassName("delete1"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addClickHandler1(button); } buttons = document.getElementsByClassName("markall"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addClickHandler2(button); } buttons = document.getElementsByClassName("clearselection"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addClickHandler3(button); @@ -23,7 +23,7 @@ function initButtons() { // TODO delete button, to show really-delete section or popup buttons = document.getElementsByClassName("tdclick"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addClickHandler4(button); @@ -45,7 +45,7 @@ function addClickHandler2(elem) form.markall.disabled = true; form.clearselection.disabled = false; var buttons = document.getElementsByClassName("delete1"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; button.checked = true; @@ -62,7 +62,7 @@ function addClickHandler3(elem) form.markall.disabled = false; form.clearselection.disabled = true; var buttons = document.getElementsByClassName("delete1"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; button.checked = false; @@ -83,7 +83,7 @@ function deleteboxclicked() { var hasAll = true; var hasNone = true; var form = document.forms[3]; - for(i = 0; i < form.elements.length; i++) { + for (var i = 0; i < form.elements.length; i++) { var elem = form.elements[i]; if (elem.type == 'checkbox') { if (elem.checked) { diff --git a/apps/susimail/src/js/iframer.js b/apps/susimail/src/js/iframer.js index d2901766b..f72ed0cc8 100644 --- a/apps/susimail/src/js/iframer.js +++ b/apps/susimail/src/js/iframer.js @@ -5,7 +5,7 @@ function setupFrame() { var frames = document.getElementsByClassName("iframedsusi"); - for(index = 0; index < frames.length; index++) + for (var index = 0; index < frames.length; index++) { var frame = frames[index]; frame.addEventListener("load", function() { diff --git a/apps/susimail/src/js/markdown.js b/apps/susimail/src/js/markdown.js index 3030ba310..4e3ccaad8 100644 --- a/apps/susimail/src/js/markdown.js +++ b/apps/susimail/src/js/markdown.js @@ -3,7 +3,7 @@ function initMarkdown() { var mailbodies = document.getElementsByClassName("mailbody"); - for(index = 0; index < mailbodies.length; index++) + for (var index = 0; index < mailbodies.length; index++) { var mailbody = mailbodies[index]; if (mailbody.nodeName === "P") { diff --git a/apps/susimail/src/js/notifications.js b/apps/susimail/src/js/notifications.js index 4d176251c..3146a1ae9 100644 --- a/apps/susimail/src/js/notifications.js +++ b/apps/susimail/src/js/notifications.js @@ -3,7 +3,7 @@ function initNotifications() { var buttons = document.getElementsByClassName("notifications"); - for(index = 0; index < buttons.length; index++) + for (var index = 0; index < buttons.length; index++) { var button = buttons[index]; addClickHandler6(button);