From 2b9ffc1270ef6c12e7444450073cdfd725feb367 Mon Sep 17 00:00:00 2001 From: zzz Date: Sat, 13 Jun 2015 15:14:21 +0000 Subject: [PATCH] javadoc fixes after review --- core/java/src/net/i2p/client/I2PSessionImpl.java | 2 +- core/java/src/net/i2p/client/SubSession.java | 14 ++------------ .../src/net/i2p/router/TunnelManagerFacade.java | 2 +- .../i2p/router/client/ClientConnectionRunner.java | 2 +- 4 files changed, 5 insertions(+), 15 deletions(-) diff --git a/core/java/src/net/i2p/client/I2PSessionImpl.java b/core/java/src/net/i2p/client/I2PSessionImpl.java index 429459d7b..aeaea7d34 100644 --- a/core/java/src/net/i2p/client/I2PSessionImpl.java +++ b/core/java/src/net/i2p/client/I2PSessionImpl.java @@ -882,7 +882,7 @@ public abstract class I2PSessionImpl implements I2PSession, I2CPMessageReader.I2 * a subsession: * BandwidthLimitsMessage, DestReplyMessage * - * The following types may not ontain a valid session ID + * The following types may not contain a valid session ID * even when intended for a subsession, so we must take special care: * SessionStatusMessage * diff --git a/core/java/src/net/i2p/client/SubSession.java b/core/java/src/net/i2p/client/SubSession.java index e115099b4..eb2a2364f 100644 --- a/core/java/src/net/i2p/client/SubSession.java +++ b/core/java/src/net/i2p/client/SubSession.java @@ -1,14 +1,5 @@ package net.i2p.client; -/* - * free (adj.): unencumbered; not under the control of others - * Written by jrandom in 2003 and released into the public domain - * with no warranty of any kind, either expressed or implied. - * It probably won't make your computer catch on fire, or eat - * your children, but it might. Use at your own risk. - * - */ - import java.io.IOException; import java.io.InputStream; import java.util.ArrayList; @@ -126,7 +117,6 @@ class SubSession extends I2PSessionMuxedImpl { */ @Override public boolean isClosed() { - // FIXME return super.isClosed() || _primary.isClosed(); } @@ -293,8 +283,8 @@ class SubSession extends I2PSessionMuxedImpl { } /** - * This may not work???????????, as the reply does not contain a session ID, so - * it won't be routed back to us? + * This won't be called, as the reply does not contain a session ID, so + * it won't be routed back to us */ @Override public int[] bandwidthLimits() throws I2PSessionException { diff --git a/router/java/src/net/i2p/router/TunnelManagerFacade.java b/router/java/src/net/i2p/router/TunnelManagerFacade.java index 208ae81c2..5b3e000ac 100644 --- a/router/java/src/net/i2p/router/TunnelManagerFacade.java +++ b/router/java/src/net/i2p/router/TunnelManagerFacade.java @@ -149,7 +149,7 @@ public interface TunnelManagerFacade extends Service { /** * Add another destination to the same tunnels. - * Must have same encryption key an a different signing key. + * Must have same encryption key and a different signing key. * @throws IllegalArgumentException if not * @return success * @since 0.9.21 diff --git a/router/java/src/net/i2p/router/client/ClientConnectionRunner.java b/router/java/src/net/i2p/router/client/ClientConnectionRunner.java index aaa106a78..b58f06462 100644 --- a/router/java/src/net/i2p/router/client/ClientConnectionRunner.java +++ b/router/java/src/net/i2p/router/client/ClientConnectionRunner.java @@ -53,7 +53,7 @@ import net.i2p.util.SimpleTimer; /** * Bridge the router and the client - managing state for a client. * - * As of release 0.9.19, multiple sessions are supported on a single + * As of release 0.9.21, multiple sessions are supported on a single * I2CP connection. These sessions share tunnels and some configuration. * * @author jrandom