findbugs all over

apps/i2psnark/java/src/org/klomp/snark/web/Sorters.java

@@ -185,7 +185,6 @@ class Sorters {
 
         private static int getStatus(Snark snark) {
             long remaining = snark.getRemainingLength(); 
-            long needed = snark.getNeededLength(); 
             if (snark.isStopped()) {
                 if (remaining < 0)
                     return 0;

apps/susimail/src/src/org/mortbay/util/ByteArrayPool.java

@@ -15,6 +15,7 @@
 
 package org.mortbay.util;
 
+import java.util.concurrent.atomic.AtomicInteger;
 
 /* ------------------------------------------------------------ */
 /** Byte Array Pool
@@ -29,7 +30,7 @@ public class ByteArrayPool
         Integer.getInteger("org.mortbay.util.ByteArrayPool.pool_size",8).intValue();
     
     public static final ThreadLocal __pools=new BAThreadLocal();
-    public static int __slot;
+    public static final AtomicInteger __slot = new AtomicInteger();
     
     /* ------------------------------------------------------------ */
     /** Get a byte array from the pool of known size.
@@ -94,7 +95,7 @@ public class ByteArrayPool
         }
 
         // slot.
-        int s = __slot++;
+        int s = __slot.getAndIncrement();
         if (s<0)s=-s;
         pool[s%pool.length]=b;
     }