diff --git a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/web/IndexBean.java b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/web/IndexBean.java index 2c671af12..363c9a60b 100644 --- a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/web/IndexBean.java +++ b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/web/IndexBean.java @@ -458,8 +458,13 @@ public class IndexBean { String port = tun.getListenPort(); if (port.length() == 0) return "" + _("Port not set") + ""; - if (Addresses.getPort(port) == 0) + int iport = Addresses.getPort(port); + if (iport == 0) return "" + _("Invalid port") + ' ' + port + ""; + if (iport < 1024) + return "" + + _("Warning - ports less than 1024 are not recommended") + + ": " + port + ""; return port; } return "" + _("Port not set") + ""; diff --git a/apps/routerconsole/java/src/net/i2p/router/web/ConfigNetHandler.java b/apps/routerconsole/java/src/net/i2p/router/web/ConfigNetHandler.java index 208997fd0..cd1f103ca 100644 --- a/apps/routerconsole/java/src/net/i2p/router/web/ConfigNetHandler.java +++ b/apps/routerconsole/java/src/net/i2p/router/web/ConfigNetHandler.java @@ -216,9 +216,14 @@ public class ConfigNetHandler extends FormHandler { } if (oldAutoPort != _ntcpAutoPort || ! oldNPort.equals(_ntcpPort)) { if (_ntcpPort.length() > 0 && !_ntcpAutoPort) { - if (Addresses.getPort(_ntcpPort) != 0) { + int port = Addresses.getPort(_ntcpPort); + if (port != 0) { changes.put(ConfigNetHelper.PROP_I2NP_NTCP_PORT, _ntcpPort); addFormNotice(_("Updating TCP port to {0}", _ntcpPort)); + if (port < 1024) { + addFormError(_("Warning - ports less than 1024 are not recommended")); + error = true; + } } else { addFormError(_("Invalid port") + ": " + _ntcpPort); error = true; @@ -235,11 +240,17 @@ public class ConfigNetHandler extends FormHandler { if ( (_udpPort != null) && (_udpPort.length() > 0) ) { String oldPort = _context.getProperty(UDPTransport.PROP_INTERNAL_PORT, "unset"); if (!oldPort.equals(_udpPort)) { - if (Addresses.getPort(_udpPort) != 0) { + int port = Addresses.getPort(_udpPort); + if (port != 0) { changes.put(UDPTransport.PROP_INTERNAL_PORT, _udpPort); changes.put(UDPTransport.PROP_EXTERNAL_PORT, _udpPort); addFormNotice(_("Updating UDP port to {0}", _udpPort)); - restartRequired = true; + if (port < 1024) { + addFormError(_("Warning - ports less than 1024 are not recommended")); + error = true; + } else { + restartRequired = true; + } } else { addFormError(_("Invalid port") + ": " + _udpPort); error = true;